Public: anyone can read this; the crew can change it.
Design: the spend tables are plain §5 `.table`s, and `.spend-table` leaves §5d #4003
The spend tables are now plain §5 tables, and .spend-table is gone from the codebase and from §5d (#3972, part of #2678 / #3615). There are no screenshots: headless chromium won't start in this sandbox because it can't open a unix socket.
stopped closed without shipping deploy b35f41b
The spend tables are now plain §5 tables, and .spend-table is gone from the codebase and from §5d (#3972, part of #2678 / #3615). There are no screenshots: headless chromium won't start in this sandbox because it can't open a unix socket.
src/web/pages/spend.ts: the five by-dimension tables and the costliest-runs table are now<table class="table mt" data-by="…">. The gap above them comes from.mtinstyle/base.ts, and the caption hasclass="muted".src/web/pages/board.ts: the.spend-tablerules are deleted. The issue said three, but there were only two:margin-topand the caption rule..spend-totalsstays, and the style comment now says only that rule is left on the board.src/web/style/components.ts: §5 had no rule for table captions, and without the old one the caption would be centred (the browser default). I added.table caption { text-align: left; }to §5's table so it stays left-aligned. The other captions in the app are.sr-only, so nothing else looks different.docs/DESIGN.md§5d: thepages/board.tsbullet now lists only.spend-totals.bun scripts/design-lint.tspasses, and--updateleft the baseline as it was.- Test: the board test in
test/credentials.test.tsnow checks that the board's HTML has nospend-tableand does have<table class="table mt" data-by="top">. It still checks thebyKindtable and the costliest-runs caption.
One visible change: the gap above each table goes from 8 px to 12 px, because .mt is 12 px.
bun x tsc --noEmit is clean, and bun test passes for test/credentials.test.ts, test/design-lint.test.ts and test/review-design.test.ts.
To try it: sign in as an admin on this pull's preview and open /board (or /settings/spend). The spend panel's tables should look as before, apart from the slightly bigger gap. Running git grep spend-table returns nothing.
🤖 Generated with Claude Code
Declined: already done on main in 5184c154 Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5w543dsd6vwbacfks68wkbj
The spend tables are now plain §5 tables, and
.spend-tableis gone from the codebase and from §5d (#3972, part of #2678 / #3615). There are no screenshots: headless chromium won't start in this sandbox because it can't open a unix socket.src/web/pages/spend.ts: the five by-dimension tables and the costliest-runs table are now<table class="table mt" data-by="…">. The gap above them comes from.mtinstyle/base.ts, and the caption hasclass="muted".src/web/pages/board.ts: the.spend-tablerules are deleted. The issue said three, but there were only two:margin-topand the caption rule..spend-totalsstays, and the style comment now says only that rule is left on the board.src/web/style/components.ts: §5 had no rule for table captions, and without the old one the caption would be centred (the browser default). I added.table caption { text-align: left; }to §5's table so it stays left-aligned. The other captions in the app are.sr-only, so nothing else looks different.docs/DESIGN.md§5d: thepages/board.tsbullet now lists only.spend-totals.bun scripts/design-lint.tspasses, and--updateleft the baseline as it was.test/credentials.test.tsnow checks that the board's HTML has nospend-tableand does have<table class="table mt" data-by="top">. It still checks thebyKindtable and the costliest-runs caption.One visible change: the gap above each table goes from 8 px to 12 px, because
.mtis 12 px.bun x tsc --noEmitis clean, andbun testpasses fortest/credentials.test.ts,test/design-lint.test.tsandtest/review-design.test.ts.To try it: sign in as an admin on this pull's preview and open
/board(or/settings/spend). The spend panel's tables should look as before, apart from the slightly bigger gap. Runninggit grep spend-tablereturns nothing.🤖 Generated with Claude Code
Closes #3972