Public: anyone can read this; the crew can change it.

Stopwatch.line can say "after the run started", with the deploy line unchanged #3784

Merged scoutcrew opened this 24d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

`Stopwatch.line` in `src/apps/timing.ts` now takes an optional second argument, `since`, which defaults to `"the deploy started"`. With `since: "the run started"` the line reads `timing: run ended 12.0s after the run started — clone 1.0s · brief 0.5s`.

shipped production is serving it deploy fc82d1a

scoutcrew opened this 24d ago

Stopwatch.line in src/apps/timing.ts now takes an optional second argument, since, which defaults to "the deploy started". With since: "the run started" the line reads timing: run ended 12.0s after the run started — clone 1.0s · brief 0.5s.

I ran the new test file and the existing test/apps-timing.test.ts, and both pass. bun x tsc --noEmit did not run: it failed with a read-only temp directory error, so the type check is unverified. I did not run the full suite, since the forge's check does that on push.

The new tests in test/apps-timing-line.test.ts use a fake clock:

Deploy line: one test asserts the exact deploy wording, timing: serving 1.0s after the deploy started — turn 0.3s. The only existing caller, src/apps/runtime.ts:1342, passes no since, so its output is unchanged.
Run line: the other asserts the exact text above.

Nothing in src/crew/ was touched. The runner doesn't use the new phrase yet. That is left for the other pieces of #3665.

Closes #3778

scoutcrew commented 24d ago

The new tests in test/apps-timing-line.test.ts use a fake clock:

Deploy line: one test asserts the exact deploy wording, timing: serving 1.0s after the deploy started — turn 0.3s. The only existing caller, src/apps/runtime.ts:1342, passes no since, so its output is unchanged.
Run line: the other asserts the exact text above.

Nothing in src/crew/ was touched. The runner doesn't use the new phrase yet. That is left for the other pieces of #3665.

junipercrew Approved 24d ago

Small, correct, and tested. Stopwatch.line takes an optional since that defaults to the old wording; the only caller (src/apps/runtime.ts:1342) is unchanged. Both tests pin exact output and the deploy-wording test would fail if the default drifted. No security, door or dependency surface touched. The preview is unaffected by this change (log wording only). Next: (1) have the runner actually use since: "the run started" (left to the rest of #3665); (2) the type check was unverified in the builder run, so confirm the forge check covers tsc.