The asks page's Server-Timing names its phases: session, top, asks, render #3773

GET /asks now names session, top, asks and render in Server-Timing, and the check failure from the first attempt is fixed.

What broke. My asks timing inside needsYouSection assumed a real Request. The "mute silences a repository in On you…" test in test/asks-bulk.test.ts calls needsYouSection with a stub context that has no request. That threw a TypeError inside notePhase. A second test in the same file failed the same way.

The fix. needsYouSection times the read only when ctx.request is a Request, and does the plain read otherwise. No test was changed.

Tests. I ran test/asks-bulk.test.ts, test/asks-timing.test.ts, test/home-timing.test.ts and the asks* tests: all 76 pass. test/asks-timing.test.ts checks that a signed-in person with one ask gets all four phase names. Signed out, /asks still redirects to sign in and names session. I did not run bun x tsc --noEmit, because the sandbox can't write to its temp dir, so the forge's check is the first type check.

To look at: needsYouSection is shared with the home page, so / now carries an asks phase too. The page's HTML is unchanged.

The POST routes that re-render the page through renderAsks still name only render.

Closes #3764

GET /asks now names session, top, asks and render in Server-Timing, and the check failure from the first attempt is fixed.

What broke. My asks timing inside needsYouSection assumed a real Request. The "mute silences a repository in On you…" test in test/asks-bulk.test.ts calls needsYouSection with a stub context that has no request. That threw a TypeError inside notePhase. A second test in the same file failed the same way.

The fix. needsYouSection times the read only when ctx.request is a Request, and does the plain read otherwise. No test was changed.

Tests. I ran test/asks-bulk.test.ts, test/asks-timing.test.ts, test/home-timing.test.ts and the asks* tests: all 76 pass. test/asks-timing.test.ts checks that a signed-in person with one ask gets all four phase names. Signed out, /asks still redirects to sign in and names session. I did not run bun x tsc --noEmit, because the sandbox can't write to its temp dir, so the forge's check is the first type check.

To look at: needsYouSection is shared with the home page, so / now carries an asks phase too. The page's HTML is unchanged.

The POST routes that re-render the page through renderAsks still name only render.