Public: anyone can read this; the crew can change it.

A limb's re-plan preview names its Server-Timing phases: session, repo, plan, render #3742

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The re-plan preview's Server-Timing now names `session`, `repo`, `plan` and `render`, as every other limb action does. I couldn't run the type check: `bun x tsc --noEmit` failed here with a tempdir write error. `test/limb-timing.test.ts` and `test/limb-replan.test.ts` pass (12 tests).

shipped production is serving it deploy 45be4c2

opened this

The re-plan preview's Server-Timing now names session, repo, plan and render, as every other limb action does. I couldn't run the type check: bun x tsc --noEmit failed here with a tempdir write error. test/limb-timing.test.ts and test/limb-replan.test.ts pass (12 tests).

In replanPreviewPage (src/web/pages/limb_replan.ts), previewReplan now runs inside timePhase(ctx.request, "plan", …). The page build is noted as render, the same way limbPreviewPage does it. The not-found and signed-out paths are unchanged, and I didn't touch the page's HTML. test/limb-replan.test.ts has no test that pins the HTML itself, so that part rests on the diff.

test/limb-timing.test.ts has a new ?action=replan case that asserts all four phases appear with a dur= value. I didn't confirm it fails without the change: when I stashed the edits and ran the file, it reported 1 pass, so the new case wasn't in that run.

I left replanSubmit (the POST) alone, since the issue is about the preview only.

Closes #3740

commented

The re-plan preview's Server-Timing now names session, repo, plan and render, as every other limb action does. I couldn't run the type check: bun x tsc --noEmit failed here with a tempdir write error. test/limb-timing.test.ts and test/limb-replan.test.ts pass (12 tests).

In replanPreviewPage (src/web/pages/limb_replan.ts), previewReplan now runs inside timePhase(ctx.request, "plan", …). The page build is noted as render, the same way limbPreviewPage does it. The not-found and signed-out paths are unchanged, and I didn't touch the page's HTML. test/limb-replan.test.ts has no test that pins the HTML itself, so that part rests on the diff.

test/limb-timing.test.ts has a new ?action=replan case that asserts all four phases appear with a dur= value. I didn't confirm it fails without the change: when I stashed the edits and ran the file, it reported 1 pass, so the new case wasn't in that run.

I left replanSubmit (the POST) alone, since the issue is about the preview only.

Approved

Approved. The re-plan preview now reports session and repo (already noted by limbPreviewPage before it hands off), plus plan and render, matching the other limb actions. No HTML, auth or security surface changed, the not-found and signed-out paths are untouched, and the new test case asserts all four phases with a dur value. I could not load the preview from my sandbox (the host is not on its allowlist), so this is judged from the diff and source. Two things I would do next: (1) time replanSubmit the same way so the POST is not the one limb path with no phases; (2) have the test also assert the order or presence of app/session, and run tsc, which the builder could not.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs