Public: anyone can read this; the crew can change it.

Design: the finder's footnote uses the design system, and finder-note leaves §5d #3676

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/3624-design-the-finder-s-footnote-uses-the-de → main 1 commit fork

  • Merged. scout/3624-design-the-finder-s-footnote-uses-the-de was merged into main as cb70dcb.

Review

Sign in to review this change.
5 files changed +5 −4
docs/DESIGN.md −1
@@ -392,7 +392,6 @@ gone, so this list only shrinks.
392392 - **`style/content.ts`, review verdicts** — the body under a verdict: `.review-body`
393393 - **`style/content.ts`, apps, runs, and the crew** — run pages, their logs and checks (a pull's look is §5's **look**): `.app-url` `.check-progress` `.check-steps` `.ln-forge` `.ln-pulse` `.ln-say` `.ln-tool` `.ln-you` `.log-tail-row` `.pinned-failures` `.pinned-slot` `.run-actions` `.run-jump` `.run-live` `.run-steer` `.run-summary` `.step-state` `.tests-bar` `.tests-words` `.txt` `.who`
394394 - **`style/content.ts`, the code browser: explorer beside content** — the explorer column's own parts: `.code-main` `.code-split` `.ex-empty` `.ex-find` `.ex-head` `.ex-list` `.ex-name` `.ex-ref` `.ex-twist` `.explorer-toggle`
395 - **`style/content.ts`, the finder** — the finder's footnote: `.finder-note`
396395 - **`style/content.ts`, the editor** — the editor's parts beyond the §5 row: `.editor-mirror` `.editor-path` `.editor-preview` `.editor-stack` `.editor-tab` `.mirrored` `.ml`
397396 - **`style/content.ts`, search results** — search results, the inbox's ask cards, the client list and the claim link: `.ask-acts` `.ask-card` `.ask-group` `.ask-kind` `.ask-meta` `.ask-more-acts` `.ask-pick` `.ask-pick-hit` `.ask-short` `.ask-waiting` `.claim-link-box` `.forges-sent` `.live-toggle` `.needs-you` `.no-hits`
398397 - **`pages/board.ts`** — the spend tables `spend.ts` draws, first on the board (the board itself is §5's **board**): `.spend-table` `.spend-totals`
src/web/client.ts +1 −1
@@ -878,7 +878,7 @@ export const codeJs = /* js */ `
878878 if (!dlg || !dlg.showModal) { location.href = repoBase + '/tree/' + encodeURIComponent(repoRef); return; }
879879 var input = dlg.querySelector('.palette-input');
880880 var list = dlg.querySelector('.palette-list');
881 var note = dlg.querySelector('.finder-note');
881 var note = dlg.querySelector('.palette-foot > span');
882882 var at = 0;
883883
884884 function render(rows) {
src/web/pages/explorer.ts +1 −1
@@ -274,7 +274,7 @@ export function finderDialog(): Html {
274274 />
275275 <div class="palette-list" role="listbox" aria-label="Files"></div>
276276 <div class="palette-foot">
277 <span class="finder-note"></span><span class="spacer"></span> <kbd>↑</kbd
277 <span class="muted small num"></span><span class="spacer"></span> <kbd>↑</kbd
278278 ><kbd>↓</kbd> navigate <kbd>↵</kbd> open <kbd>esc</kbd> close
279279 </div>
280280 </dialog>`;
src/web/style/content.ts −1
@@ -1049,7 +1049,6 @@ form.inline { display: inline; margin-left: auto; }
10491049 overflow: hidden; text-overflow: ellipsis; white-space: nowrap; max-width: 45%;
10501050 }
10511051 .finder .palette-item .grow { font-family: var(--mono); font-size: 12.5px; }
1052 .finder-note { color: var(--faint); font-variant-numeric: tabular-nums; }
10531052
10541053 /* ---- the editor ---- */
10551054 .editor-head {
test/web-code.test.ts +3
@@ -307,6 +307,9 @@ describe("the code browser on the web", () => {
307307 // The fallback is a real, populated tree of links in the same page.
308308 expect(html).toContain('class="ex-file"');
309309 expect(html).toContain(`data-paths="/alice/beacon/paths/main"`);
310 // The footnote is drawn with §5 text utilities, not a one-off class.
311 expect(html).not.toContain("finder-note");
312 expect(html).toContain('<span class="muted small num"></span>');
310313 });
311314
312315 // ---- branches ----

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs