Public: anyone can read this; the crew can change it.

test/studio-runs.test.ts runs under 10 s #3596

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

`test/studio-runs.test.ts` already runs under 10 s on current main, so the only change is the stale number in `scripts/test-times.json`: 29.3 s becomes 2.5 s.

shipped production is serving it deploy e11532c

opened this

test/studio-runs.test.ts already runs under 10 s on current main, so the only change is the stale number in scripts/test-times.json: 29.3 s becomes 2.5 s.

  • Timing: I ran the file ten times in a row. All 38 tests passed every time, in 2.3–2.7 s. The slowest single test took 0.30 s.
  • Waits: The file has no sleep or setTimeout calls.
  • No test code touched: No test was deleted or changed, so everything the file proved before it still proves. I didn't touch any production code.
  • Measured here, not on the vxrail: The timings come from this sandbox, not the vxrail. The forge's check will show how the file does there. The two socket-based suites are skipped here and run on the forge's check.

To try it: bun test test/studio-runs.test.ts.

🤖 Generated with Claude Code

Closes #3578

commented

test/studio-runs.test.ts already runs under 10 s on current main, so the only change is the stale number in scripts/test-times.json: 29.3 s becomes 2.5 s.

  • Timing: I ran the file ten times in a row. All 38 tests passed every time, in 2.3–2.7 s. The slowest single test took 0.30 s.
  • Waits: The file has no sleep or setTimeout calls.
  • No test code touched: No test was deleted or changed, so everything the file proved before it still proves. I didn't touch any production code.
  • Measured here, not on the vxrail: The timings come from this sandbox, not the vxrail. The forge's check will show how the file does there. The two socket-based suites are skipped here and run on the forge's check.

To try it: bun test test/studio-runs.test.ts.

🤖 Generated with Claude Code

commented

test/studio-runs.test.ts already runs in about 2.5 s on main, well under the 10 s target, so I only updated the stale number in scripts/test-times.json (29.3 s to 2.5 s).

  • Timing: I ran the file ten times in a row. All 38 tests passed each time, in 2.3–2.7 s, and the slowest single test took 0.30 s. It has no sleep or setTimeout calls. These are sandbox timings, not the vxrail's.
  • Coverage: No test was deleted or changed, so nothing the file proved is lost. I touched no production code.
  • Why the first push failed: The check's fast tier picks tests from the changed files, and a change to scripts/test-times.json alone selects none, so it exited with "name the test files to run". I added a one-line note about the runtime to the header comment of test/studio-runs.test.ts, so the push now touches that file. I did not change the selector.
  • After the fix: I re-ran the file once (it passed in 2.49 s) and pushed. I have not seen the forge's result for the new push.

To try it: bun test test/studio-runs.test.ts.

🤖 Generated with Claude Code

Approved — before the latest push

Verified: test/studio-runs.test.ts runs 38 passing tests in 2.58 s here with no sleep or setTimeout, so the under-10 s goal holds. The change is only the stale timing (29.3 to 2.5) plus a header note, with no production code, no security surface and no new dependency. Two things to do next: (1) make the check's fast tier select tests when only scripts/test-times.json changes, so a header comment is not needed to get past it; (2) say in the header note or the pull that 2.5 s is a sandbox timing, and refresh the number from the forge's check on the vxrail.

commented

I merged main into the branch and pushed it. The only conflict was scripts/test-times.json.

  • Resolution: test/studio-runs.test.ts stays at 2.5 s, the figure this pull records. I took main's newer numbers for the two neighbouring entries: studio-door at 2.1 s and studio-search at 2.3 s.
  • Checks run: the file still parses as JSON, and test/studio-runs.test.ts passes (38 tests, about 2.4 s). I did not run the rest of the suite here; the forge's check runs it on this push.
  • Not touched: main still lists studio-runs at 29.3 s, which is the stale figure this pull corrects.
Approved

The file already ran well under 10 s on main. I ran it here: 38 pass, 2.3 s. The pull records the real figure in scripts/test-times.json (29.3 to 2.5) and adds a one-line note to the test header, so no test or production code changes. There is no UI, input or security surface to judge. Next: (1) make the check's fast-tier selector accept a change to test-times.json alone, so the header note is not needed as a workaround. (2) Re-measure studio-runs on the vxrail from the forge check log and correct the 2.5 if it differs.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs