c86e145 · 2b213f1 · 111c9c5 · fed2e26
@@ -17,15 +17,15 @@
command palette from anywhere, a field included. The box takes its query to
`/search` (`searchPage`, `src/web/pages/search.ts`), the one search in
both faces, server-rendered with no script: every repository the viewer
can see, matched by name or description, an app saying whether it is live,
then every tell and change whose title mentions the word, each saying
which app it's on and linked by the studio's noun — the same `search()`
then every issue and pull request whose title mentions the word, each
saying which app it's on and linked at `/issues/:n` or `/pulls/:n` — the same `search()`
the API and the palette ask, so a signed-out reader sees only what a
signed-out reader would anywhere. The studio's face leaves code to dev's:
it says _Search the code_, a link to the same page with `?mode=dev`, which
keeps that face on every link and the form until the reader leaves. The palette starts from a short local
index — your own apps, then places and actions like Home, Apps, Map, New
app — and past two characters asks that very same search, folding its apps,
changes and tells in under their own headings (`rankPalette`,
pull requests and issues in under their own headings (`rankPalette`,
`src/web/palette.ts`), so what it turns up can never disagree with the page
behind it.
@@ -75,10 +75,9 @@
with a door to make it one — `/settings/app`, the same "Run as an app" form
Settings already carries — open only to whoever could submit it (`canAdmin`);
a reader sees the sentence with no button that would just come back
refused. `?mode=dev` on the same URL is unaffected: the card is the studio's
own, never dev's. `/tells` and `/changes` on such a repository still send a
studio viewer on to `/issues` and `/pulls`, as they do for any repository
the studio does not apply to — the card names the one thing to do here,
not a second front door onto lists that would be empty anyway.
own, never dev's. `/issues` and `/pulls` on such a repository are the same
lists they are everywhere — the card names the one thing to do here, not a
second front door onto lists that would be empty anyway.
An app's home in the studio (`/:owner/:name`, when the repository is an
app) shows, top to bottom: what it serves and where; the box; what asks
@@ -152,7 +151,7 @@
it already answers only to people who can read it at all.
**Whose name a row carries** is one rule, in one place — `voiceFor`
(`src/web/studio/voice.ts`), which the app's page, a run's own page and the
board all sign their rows with. An agent's name is _not_ a secret: a
change's own page and `/changes` name the agent that opened it to anyone
pull request's own page and `/pulls` name the agent that opened it to anyone
who can read the repository. "The crew" is a voice, not a redaction, and it
is chosen by **what the actor is** first: a person is named to every viewer
who can see the row at all, so one visitor reads one name for one change on
@@ -202,34 +201,24 @@
presses instead of deciding.
## The three lists
`/:owner/:name/issues`, `/pulls` and `/runs` on an app, in the studio, are
_everything told_, _every change_ and _every run_ — dev's tabs with dev's
issue numbers, labels, milestones and branch names replaced by the same
five words the rest of the studio speaks. Each is a page of rows, newest
first: who has it (the assignee, the author, or who ran it), when it last
moved, its state as `wordBadge` draws it (`src/web/studio/words.ts`), and
one link — the row itself — to the tell, the change or the transcript.
`/:owner/:name/tells` and `/:owner/:name/changes` are the studio's own
nouns for the first two lists, and `/:owner/:name/tells/:number` and
`/:owner/:name/changes/:number` for one tell and one change — the same
handler each, the same authorization, the same `?word=` filter and paging,
not a second copy of any page; a viewer the studio does not apply to (dev
mode, `?mode=dev`, or a repository that is not an app) is sent on to
`/issues`, `/pulls`, `/issues/:number` or `/pulls/:number`, dev's own
address, rather than the studio's nouns ever growing a second,
dev-flavoured address of their own. It goes one way only: a dev URL asked
for in studio mode answers the studio's page where it stands, never a
redirect, so every link ever written to `/issues/7` keeps working and
`?mode=dev` on it is still the one click to dev's own. In studio mode the
studio's own links use the studio's nouns wherever a tell or a change is
linked — the three lists' rows, the app page's _now_,
a tell's dependencies and the change that closes it, a run's own tell, the
search box and the command palette — so a person is never handed two
addresses for one thing. The app page's own footer (`the map · everything
told · every change`, and _Every run_ above **Now**) and the repository
header's tabs (`Told`, `Changes`, in place of dev's `Issues`, `Pulls`) link
to `/tells` and `/changes`; dev's `Commits`/`Branches` stay dev's alone.
`/runs` has no second noun — the studio and dev share the one address
there. What a page _posts_ to never moves with the noun: ship, close,
the app's issues, pull requests and runs — dev's tabs with dev's labels,
milestones and branch names replaced by the same five words the rest of
the studio speaks. Each is a page of rows, newest first: who has it (the
assignee, the author, or who ran it), when it last moved, its state as
`wordBadge` draws it (`src/web/studio/words.ts`), and one link — the row
itself — to the issue, the pull request or the transcript. Issues and pull
requests are called that in every mode (#3241): the studio once had its own
nouns and addresses for them, `/tells` and `/changes`, and those —
`/:owner/:name/tells`, `/tells/new`, `/tells/:number`, `/changes` and
`/changes/:number` — now answer 301 to `/issues`, `/issues/new`,
`/issues/:number`, `/pulls` and `/pulls/:number`, query kept, in every mode,
so a link ever written to them keeps working. A dev URL asked for in studio
mode answers the studio's page where it stands, never a redirect, and
`?mode=dev` on it is still the one click to dev's own. The app page's own
footer (`the map · issues · pull requests`, and _Every run_ above **Now**)
and the repository header's tabs (`Issues`, `Pulls`) link to `/issues` and
`/pulls`; dev's `Commits`/`Branches` stay dev's alone.
What a page _posts_ to is the same address: ship, close,
comment, edit and decide keep posting under `/issues/:number` and
`/pulls/:number`, which is what `form-action 'self'` and the same-origin
checks are written against.
@@ -265,13 +254,13 @@
production has not caught up to yet, or a run with nothing to show —
still read as _working_: still moving, not one of the five a list links to
on its own. Paging is the underlying list's own cursor, unchanged; a word
filter narrows the page it lands on rather than inventing a second scheme.
Told and changes are the only lists of issues and pulls: every repository,
app or not, and every viewer, whatever the mode, at `/issues` and `/tells`,
`/pulls` and `/changes` alike (`?mode=dev` changes nothing there). Besides
These are the only lists of issues and pulls: every repository, app or
not, and every viewer, whatever the mode, at `/issues` and `/pulls`
(`?mode=dev` changes nothing there). Besides
the word they narrow by `?label=` (the repository's labels are chips under
the words), `?assignee=`, `?author=` and `?q=` (a piece of the title), each
shown as a chip that clears itself; an older `?state=closed|all` address
still answers with what it asked for. Told carries one verb besides opening
still answers with what it asked for. Issues carries one verb besides opening
a row — compose, for a signed-in person; a stranger on a public repository
gets "Report a problem" instead, and its writers see how many reports from
outside wait for them. A row wears its labels; a change's
@@ -280,8 +269,7 @@
list keeps `?mode=dev` to dev's runs until that list is contracted too.
## A tell, on its own page
`/:owner/:name/issues/:number` — `/:owner/:name/tells/:number` in the
studio's own noun, the same page — on an app, in the studio, is a tell — one
`/:owner/:name/issues/:number` on an app, in the studio, is a tell — one
sentence someone said to the crew — not dev's labels, milestones and
dependency form. It answers three questions: who has it (or that nobody
does yet), what it is waiting on and what waits on it (`dependenciesOf`,
@@ -319,8 +307,7 @@
mode, renders exactly what it always has.
## The look, on its own page
`/:owner/:name/pulls/:n` — `/:owner/:name/changes/:n` in the studio's own
noun, the same page — on an app, in the studio, is the change itself —
`/:owner/:name/pulls/:n` on an app, in the studio, is the change itself —
never its diff. The title and the opening post in the author's own words,
who made it and when, the check in the studio's five words (`pullWord`,
`src/web/studio/words.ts`) with its deploy one click away, the preview's
@@ -158,10 +158,10 @@
export const TOO_LONG_WORDS = "That is too long to tell in one go.";
/** What happened, in the sentence both doors say. */
export function toldWords(told: Told): string {
  if (told.routed === undefined)
    return `Told as #${told.issue.number}. Nobody is on the crew to take it yet — add someone under Settings → Crew.`;
    return `Opened as issue #${told.issue.number}. Nobody is on the crew to take it yet — add someone under Settings → Crew.`;
  const r = told.routed;
  const who = r.builder.user.username;
  return told.assigned
    ? `${who} is on it — ${r.size} ${r.kind}${r.by === "rule" ? "" : `, ${r.by} decided in ${r.ms} ms`}.`
    : `Told as #${told.issue.number}, but ${who} could not take it.`;
    : `Opened as issue #${told.issue.number}, but ${who} could not take it.`;
}
@@ -340,7 +340,7 @@
function fromEvent(
    ...(pull?.authorIsAgent ? [`by ${pull.authorName}`] : []),
  ].join(", ");
  const toldWords = toldParts === "" ? "" : ` (${toldParts})`;
  const change = number === undefined ? base(repo) : `${base(repo)}/changes/${number}`;
  const change = number === undefined ? base(repo) : `${base(repo)}/pulls/${number}`;
  switch (e.kind) {
    case "run.finished": {
      const state = p["state"] === "failed" ? "failed" : "ok";
@@ -364,11 +364,11 @@
function fromEvent(
      };
    }
    case "pull.opened":
      return { ...common, kind: "pull", link: change, what: `a change was opened${title ? `: ${clip(title)}` : ""}${toldWords}` };
      return { ...common, kind: "pull", link: change, what: `opened a pull request${title ? `: ${clip(title)}` : ""}${toldWords}` };
    case "pull.merged":
      return { ...common, kind: "pull", link: change, what: `a change shipped${title ? `: ${clip(title)}` : ""}${toldWords}` };
      return { ...common, kind: "pull", link: change, what: `merged a pull request${title ? `: ${clip(title)}` : ""}${toldWords}` };
    case "pull.reviewed":
      return { ...common, kind: "pull", link: change, what: `a change was reviewed${title ? `: ${clip(title)}` : ""}` };
      return { ...common, kind: "pull", link: change, what: `reviewed a pull request${title ? `: ${clip(title)}` : ""}` };
    case "look.taken":
      return { ...common, kind: "look", link: base(repo), what: "a new picture of it is ready" };
    case "app.serving":
@@ -380,8 +380,8 @@
function fromEvent(
      return {
        ...common,
        kind: "tell",
        link: `${base(repo)}/tells/${number}`,
        what: told === "" ? `told #${number}` : clip(told),
        link: `${base(repo)}/issues/${number}`,
        what: `opened an issue: ${told === "" ? `#${number}` : clip(told)}`,
      };
    }
    case "issue.commented":
@@ -399,7 +399,7 @@
function fromEvent(
        kind: "reply",
        link:
          e.kind === "issue.commented"
            ? `${base(repo)}/tells/${number}`
            ? `${base(repo)}/issues/${number}`
            : change,
        what: said === "" ? `replied on “${on}”` : `on “${on}”: ${clip(said)}`,
      };
@@ -193,7 +193,7 @@
async function steer(
  item: Candidate,
): Promise<Outcome> {
  const text = `Shared by ${sender.username} with ${agent.username}: ${words(item)} (${item.link})`;
  const number = /\/changes\/(\d+)$/.exec(item.link)?.[1];
  const number = /\/pulls\/(\d+)$/.exec(item.link)?.[1];
  const issue =
    number === undefined ? undefined : getIssue(app.db, repo.id, Number(number));
  if (issue !== undefined) {
@@ -222,7 +222,6 @@
import {
  issueThreadFragment,
  newIssuePage,
  newIssueSubmit,
  newTellPage,
} from "../web/pages/issues.ts";
import { tellPage } from "../web/studio/tell.ts";
import { tellHerePage } from "../web/studio/tell_here.ts";
@@ -331,7 +330,6 @@
import {
} from "../web/pages/crew.ts";
import { newPullPage, newPullSubmit } from "../web/pages/pulls.ts";
import {
  changePage,
  pullPage,
  pullStateFragment,
} from "../web/studio/change.ts";
@@ -621,6 +619,21 @@
const gitChallenge = () =>
// ---- the public server ----
/**
 * A handler that answers 301 to the same repository's `/<noun>`, with the
 * rest of the old path (a literal, or `:number` for the matched number) and
 * the query kept — for addresses retired from a name, never from a page.
 */
function movedTo(noun: "issues" | "pulls", rest?: "new" | ":number"): Handler {
  return (ctx) => {
    const { owner = "", name = "", number = "" } = ctx.params;
    const tail =
      rest === undefined ? "" : `/${encodeURIComponent(rest === "new" ? "new" : number)}`;
    const location = `/${encodeURIComponent(owner)}/${encodeURIComponent(name)}/${noun}${tail}${ctx.url.search}`;
    return new Response(null, { status: 301, headers: { location } });
  };
}
export function buildRouter(): Router<Handler> {
  const router = new Router<Handler>();
@@ -1057,15 +1070,12 @@
export function buildRouter(): Router<Handler> {
  // Issues (web). The literal /new is registered before /:number so it can
  // never be captured as a number.
  // One list of issues: `/issues` and `/tells` are two addresses for the
  // same page, for every repository and every viewer.
  router.add("GET", "/:owner/:name/issues", tellsList);
  // One issue page, at `/issues/:number` and `/tells/:number` alike, for
  // every repository and every viewer. The literal /tells is registered
  // before /tells/:number for the same reason /issues/new is.
  router.add("GET", "/:owner/:name/tells", tellsList);
  router.add("GET", "/:owner/:name/tells/new", newTellPage);
  router.add("GET", "/:owner/:name/tells/:number", tellPage);
  // Issues are called issues in every mode (#3241): the studio's old
  // addresses for them answer 301, so a link written to one still lands.
  router.add("GET", "/:owner/:name/tells", movedTo("issues"));
  router.add("GET", "/:owner/:name/tells/new", movedTo("issues", "new"));
  router.add("GET", "/:owner/:name/tells/:number", movedTo("issues", ":number"));
  router.add("GET", "/:owner/:name/report", reportPage);
  router.add("POST", "/:owner/:name/report", reportSubmit);
  router.add("GET", "/:owner/:name/reports", reportsPage);
@@ -1132,12 +1142,10 @@
export function buildRouter(): Router<Handler> {
  );
  // Pull requests. Same /new-before-/:number ordering discipline.
  // One list of pulls, at `/pulls` and `/changes` alike; one change under
  // the studio's own noun. See the tells above for the rule; the forms that
  // ship, close and comment keep posting under /pulls/:number.
  // And pull requests are called pull requests: `/changes` answers 301.
  router.add("GET", "/:owner/:name/pulls", changesList);
  router.add("GET", "/:owner/:name/changes", changesList);
  router.add("GET", "/:owner/:name/changes/:number", changePage);
  router.add("GET", "/:owner/:name/changes", movedTo("pulls"));
  router.add("GET", "/:owner/:name/changes/:number", movedTo("pulls", ":number"));
  router.add("GET", "/:owner/:name/pulls/new", newPullPage);
  router.add("POST", "/:owner/:name/pulls/new", newPullSubmit);
  router.add("GET", "/:owner/:name/pulls/:number", pullPage);
@@ -68,7 +68,7 @@
export function answersScreen(f: Session, ctx: Ctx, repo: Repo): Screen {
      );
      if (lines.length === 0) {
        emptyState(s, body!, c, {
          title: "No tells yet",
          title: "No issues yet",
          body: "What you tell the crew about this app shows up here, with its answer.",
        });
        return;
@@ -1301,7 +1301,7 @@
export function workspaceScreen(
              binding(["V"], "waves"),
              ...(repo === undefined ? [] : [binding(["d"], "production deploys")]),
              ...(repo !== undefined && canSeeAnswers(f.db, repo, f.user)
                ? [binding(["a"], "your tells and the crew's answers")]
                ? [binding(["a"], "your issues and the crew's answers")]
                : []),
              ...(repo !== undefined && admin()
                ? [binding(["R"], `decisions by ${(getRepoById(f.db, repo.id) ?? repo).decisionsBy} (cycle)`)]
@@ -203,21 +203,17 @@
export function scopeHeader(
          },
        ]),
    {
      // Studio names its own lists — told, not issues; a repository that is
      // not an app keeps git's words.
      label: studio ? "Told" : "Issues",
      href: studio ? tellsHref(base) : `${base}/issues`,
      icon: studio ? "clock" : "issue",
      // Issues and pull requests are called that in every mode (#3241).
      label: "Issues",
      href: tellsHref(base),
      icon: "issue",
      ...(facts.openIssues === null ? {} : { count: facts.openIssues }),
      current: active === "issues",
      shortcut: "g i",
    },
    {
      // "Look" is the five-word state a green pull is in, and the name of
      // the picture card on one — not the noun for this list, which is the
      // same one `/changes` and "Every change" already use.
      label: studio ? "Changes" : "Pulls",
      href: studio ? changesHref(base) : `${base}/pulls`,
      label: "Pulls",
      href: changesHref(base),
      icon: "pull",
      ...(facts.openPulls === null ? {} : { count: facts.openPulls }),
      current: active === "pulls",
@@ -383,8 +379,8 @@
export function repoPalette(ctx: Ctx, repo: Repo): PaletteItem[] {
    return [
      { t: `${name} — Studio`, h: base, c: "This repo" },
      { t: `${name} — Files`, h: `${base}/files`, c: "This repo" },
      { t: `${name} — Told`, h: tellsHref(base), c: "This repo" },
      { t: `${name} — Changes`, h: changesHref(base), c: "This repo" },
      { t: `${name} — Issues`, h: tellsHref(base), c: "This repo" },
      { t: `${name} — Pull requests`, h: changesHref(base), c: "This repo" },
      // Telling the crew is for who may direct it (`mayDirectCrew`: a
      // writer, or anyone signed in where the owner let outsiders in), so
      // nobody else is offered a door that leads nowhere.
@@ -1590,15 +1590,12 @@
export const shellJs = /* js */ `
            d: r.originKind ? 'on ' + r.originKind : 'on an origin' }
        : { t: r.owner + '/' + r.name, h: '/' + r.owner + '/' + r.name, g: 'Repositories' });
    });
    // Which noun a tell or a change lives under is the mode's, and the index
    // carries it — the studio's /tells/:n and /changes/:n, dev's /issues/:n
    // and /pulls/:n, the same addresses the server just rendered into the
    // page behind this box (\`tellHref\`/\`changeHref\`, src/web/studio/nouns.ts).
    var studio = loadIndex().studio === true;
    // An issue lives at /issues/:n and a pull request at /pulls/:n in every
    // mode (\`tellHref\`/\`changeHref\`, src/web/studio/nouns.ts).
    (out.issues || []).slice(0, 5).forEach(function (i) {
      if (i.source !== 'local') return;
      var tell = i.kind === 'issue';
      var noun = tell ? (studio ? 'tells' : 'issues') : (studio ? 'changes' : 'pulls');
      var noun = tell ? 'issues' : 'pulls';
      rows.push({
        t: i.title,
        h: '/' + i.repo.owner + '/' + i.repo.name + '/' + noun + '/' + i.number,
@@ -38,17 +38,15 @@
import {
import {
  PAGE_TITLES,
  pageTitle,
  studioRecord,
  tellsHref,
} from "../studio/nouns.ts";
// ---- compose ----
/**
 * The compose page, in the face the viewer has: the studio's own noun for
 * it (`PAGE_TITLES.compose`) on the tab, the heading and the button, and
 * Cancel back to the list that face calls home. The form posts to
 * `/issues/new` in both faces — the one door that changes something.
 * The compose page: `PAGE_TITLES.compose` on the tab, the heading and the
 * button, and Cancel back to the issues list. The form posts to
 * `/issues/new` — the one door that changes something.
 */
function composePage(
  ctx: Ctx,
@@ -56,13 +54,12 @@
function composePage(
  values: { title: string; body: string; sealed?: boolean },
  error?: string,
): Response {
  const studio = studioRecord(ctx, repo) !== undefined;
  const heading = PAGE_TITLES.compose[studio ? "studio" : "dev"];
  const heading = PAGE_TITLES.compose;
  const base = repoBase(repo);
  return page(
    {
      ctx,
      title: pageTitle("compose", repo, studio),
      title: pageTitle("compose", repo, false),
      crumbs: crumbsFor(repo),
      palette: repoPalette(ctx, repo),
      body: html`${repoHeader(ctx, repo, "issues", {
@@ -73,8 +70,8 @@
function composePage(
        ${newIssueForm(
          repo,
          values,
          studio ? "Tell" : "Create issue",
          studio ? tellsHref(base) : `${base}/issues`,
          "Create issue",
          tellsHref(base),
          error,
        )}`,
    },
@@ -173,17 +170,6 @@
function accountOrReport(ctx: Ctx, repo: Repo): Response {
  });
}
// GET /:owner/:name/tells/new — the studio's own door onto the compose page
// `/issues/new` reaches, redirecting there when the studio does not apply,
// the same rule `tellPage` follows for one tell.
export function newTellPage(ctx: Ctx): Response {
  const repo = loadRepo(ctx);
  if (!repo) return notFoundPage(ctx);
  if (studioRecord(ctx, repo) === undefined)
    return redirect(`${repoBase(repo)}/issues/new${ctx.url.search}`);
  return newIssuePage(ctx);
}
// POST /:owner/:name/issues/new
export async function newIssueSubmit(ctx: Ctx): Promise<Response> {
  const repo = loadRepo(ctx);
@@ -1307,17 +1307,14 @@
const LIVE_KINDS = "run.queued,run.started,run.finished,issue.*,pull.*";
/** The empty state in the studio's own words, pointing at the app page's
 * own box for telling the crew (`#tell`, `src/web/studio/app.ts`). */
const studioEmpty = (base: string): Html =>
  html`<p>No tells to map yet. <a href="${base}#tell">Say one</a>, then link what it waits for.</p>`;
  html`<p>No issues to map yet. <a href="${base}#tell">Say one</a>, then link what it waits for.</p>`;
/** GET /:owner/:name/map */
export async function mapPage(ctx: Ctx): Promise<Response> {
  const repo = loadRepo(ctx);
  if (!repo) return notFoundPage(ctx);
  const db = ctx.app.db;
  // In the studio a card is a tell and its link is `/tells/:number` — the
  // same rule every other studio surface follows (`studioRecord`).
  const studio = studioRecord(ctx, repo) !== undefined;
  const issueHref = studio ? tellHref : devIssueHref;
  const graph = repoGraph(db, repo.id, {
    ...sealedScope(db, repo, ctx.auth.user),
      
        sentinelcrew
        24d ago
        outdated
      
      Both sides of this ternary now return /issues/:n. Use tellHref directly and drop studio here if nothing else on this page reads it.
    
  });
@@ -1351,7 +1348,7 @@
export async function mapPage(ctx: Ctx): Promise<Response> {
        ${drawMap(repo, graph, placed, emphasisFor(ready, critical, marks), {
          id: "map-canvas",
          cap: 1,
          issueHref,
          issueHref: tellHref,
          ...(studio ? { emptyHtml: studioEmpty(repoBase(repo)) } : {}),
        })}
        ${placed.nodes.length === 0 ? null : countsLine(counts)}
@@ -1374,7 +1371,7 @@
export async function mapPage(ctx: Ctx): Promise<Response> {
                  ? "holds nothing up"
                  : `finishing it frees ${r.holdsUp}`,
              "Nothing is ready: everything open waits for something.",
              issueHref,
              tellHref,
            )}
        ${rankedList(
          repo,
@@ -1382,7 +1379,7 @@
export async function mapPage(ctx: Ctx): Promise<Response> {
          blocked,
          (r) => `holds up ${r.holdsUp}`,
          "Nothing open holds anything up.",
          issueHref,
          tellHref,
        )}
      </aside>
    </div>`;
@@ -248,9 +248,9 @@
const WORDS: readonly Words[] = [
  ],
  [
    "issues",
    "Tells & changes",
    "Tells and changes",
    "No tell or change matches",
    "Issues & pull requests",
    "Issues and pull requests",
    "No issue or pull request matches",
  ],
  ["code", "Code", "Code", "No line of code matches"],
];
@@ -357,7 +357,7 @@
export async function searchPage(ctx: Ctx): Promise<Response> {
      type="search"
      name="q"
      value="${a.query}"
      placeholder="Search apps, repositories, tells, changes and code"
      placeholder="Search apps, repositories, issues, pull requests and code"
      aria-label="Search"
      autofocus
      data-search-input
@@ -79,7 +79,7 @@
async function tellFrom(
  const { routed } = told.value;
  if (routed === undefined)
    return flashOrJson(ctx, back, {
      message: `Told. Nobody is on the crew to take it yet — add someone under Settings → Crew.`,
      message: `Opened as an issue. Nobody is on the crew to take it yet — add someone under Settings → Crew.`,
    });
  const builder = routed.builder;
  return flashOrJson(ctx, back, {
@@ -135,11 +135,11 @@
async function tellFromPage(ctx: Ctx, repo: Repo, form: Form): Promise<Response>
  const issue = `${repoBase(repo)}/issues/${told.value.issue.number}`;
  return page({
    ctx,
    title: `Told · ${repo.name}`,
    title: `Issue opened · ${repo.name}`,
    crumbs: crumbsFor(repo),
    body: html`${pageHead("Told")}
    body: html`${pageHead("Issue opened")}
      <p>${toldWords(told.value)}</p>
      <p><a href="${issue}" data-receipt>See your tell, #${String(told.value.issue.number)}</a></p>`,
      <p><a href="${issue}" data-receipt>See issue #${String(told.value.issue.number)}</a></p>`,
  });
}
@@ -235,9 +235,9 @@
function takeBackWords(error: RevertPullError): string {
      case "unauthorized":
        return "sign in first";
      case "forbidden":
        return "only a person can take a change back";
        return "only a person can take a pull request back";
      case "not_found":
        return "that change was not found";
        return "that pull request was not found";
    }
  }
  switch (error.kind) {
@@ -311,7 +311,7 @@
export async function saySubmit(ctx: Ctx): Promise<Response> {
  const said = addComment(ctx.app, ctx.auth.user, repo, pull, text);
  return flashOrJson(ctx, base, {
    ...(said.ok
      ? { message: `Told ${pull.authorName}. It picks the change back up.` }
      ? { message: `Told ${pull.authorName}. It picks the pull request back up.` }
      : { tone: "danger" as const, message: "That could not be said." }),
  });
}
@@ -364,17 +364,17 @@
export async function studioApp(
  const weekCard = card(
    !hasHistory
      ? html`<p class="muted small">
          Nothing to show yet — it fills in once a change
          Nothing to show yet — it fills in once a pull request
          ships${ownerFacts ? " or the crew takes a run" : ""}.
        </p>`
      : !ownerFacts
        ? html`<dl>
            <dt>Shipped</dt>
            <dd>${shipped} change${shipped === 1 ? "" : "s"}</dd>
            <dd>${shipped} pull request${shipped === 1 ? "" : "s"}</dd>
          </dl>`
        : html`<dl>
            <dt>Shipped</dt>
            <dd>${shipped} change${shipped === 1 ? "" : "s"}</dd>
            <dd>${shipped} pull request${shipped === 1 ? "" : "s"}</dd>
            <dt>Runs</dt>
            <dd>${weekTotals.runs}</dd>
            <dt>Preview</dt>
@@ -385,7 +385,7 @@
export async function studioApp(
            <dd>
              $${spent.toFixed(2)}${shipped > 0
                ? html` <span class="muted"
                    >· $${(spent / shipped).toFixed(2)} per shipped change</span
                    >· $${(spent / shipped).toFixed(2)} per shipped pull request</span
                  >`
                : null}
            </dd>
@@ -444,8 +444,8 @@
export async function studioApp(
  // domains — is the admin's, on the app's settings page.
  const more = html`<p class="muted small">
    <a href="${base}/map">The map</a> ·
    <a href="${tellsHref(base)}">Everything told</a> ·
    <a href="${changesHref(base)}">Every change</a>${when(
    <a href="${tellsHref(base)}">Issues</a> ·
    <a href="${changesHref(base)}">Pull requests</a>${when(
      canAdmin(db, repo, ctx.auth.user),
      () => html` · <a href="${base}/settings/app">Environment settings</a>`,
    )}
@@ -161,12 +161,12 @@
export interface AskWords {
/** The words for each kind of ask: every ask names its decision, its options and its default. */
export const ASK_WORDS: Readonly<Record<DecisionKind, AskWords>> = {
  look: {
    decision: "Ship this change?",
    decision: "Ship this pull request?",
    options: ["Ship", "Say what is off"],
    ifNothing: "it waits; nothing ships",
  },
  review: {
    decision: "Review this change: ship it, or say what is off?",
    decision: "Review this pull request: ship it, or say what is off?",
    options: ["Ship", "Say what is off"],
    ifNothing: "it waits; an agent's change never ships unreviewed",
  },
@@ -1102,7 +1102,7 @@
export function askLinesFor(
      ...about,
      line,
      number: only.pull!.number,
      link: `${base}/changes/${only.pull!.number}`,
      link: `${base}/pulls/${only.pull!.number}`,
    };
  });
}
@@ -61,12 +61,12 @@
export function tellsAnswered(
  return out;
}
/** The line a change carries for its tell: a link in the studio's own noun,
 * and — when that tell is closed — what a person can act on. Never a verdict:
/** The line a pull request carries for the issue it answers: a link to it,
 * and — when that issue is closed — what a person can act on. Never a verdict:
 * the change's word is judged elsewhere and is not touched by this. */
export function tellLine(base: string, t: AnsweredTell): Html {
  const link = html`<a href="${tellHref(base, t.number)}">tell #${t.number}</a>`;
  const link = html`<a href="${tellHref(base, t.number)}">issue #${t.number}</a>`;
  return t.closed
    ? html`for ${link} — its tell is already done`
    ? html`for ${link} — its issue is already done`
    : html`for ${link}`;
}
@@ -239,7 +239,7 @@
export function changeTabs(
  return html`<div class="filters mt">
    ${seg([
      {
        label: "Change",
        label: "Conversation",
        href: changeHref(base, pull.number),
        current: current === "change",
      },
@@ -262,8 +262,7 @@
function conflictWords(baseBranch: string, files: readonly string[]): string {
}
/**
 * GET /:owner/:name/pulls/:number and /changes/:number: one page, two
 * addresses, for every repository and every viewer. An older `?rc=` link (an inline comment form
 * GET /:owner/:name/pulls/:number, for every repository and every viewer. An older `?rc=` link (an inline comment form
 * on the diff) is handed on to the Files step, where the diff now lives.
 */
export async function pullPage(ctx: Ctx): Promise<Response> {
@@ -277,10 +276,6 @@
export async function pullPage(ctx: Ctx): Promise<Response> {
  return await changeConversation(ctx, repo, pull);
}
/** GET /:owner/:name/changes/:number — the studio's own noun for the page
 * `/pulls/:number` reaches; see `pullPage`. */
export const changePage = pullPage;
/**
 * What a change's page says about where it stands, drawn once: the word and
 * its note, the deploy worth linking, and the Preview card. The page's first
@@ -292,10 +287,8 @@
async function pullPanels(ctx: Ctx, repo: Repo, pull: Pull, spent: Spent = newSp
  const record: AppRecord | undefined = getAppByRepo(ctx.app.db, repo.id);
  const db = ctx.app.db;
  const base = repoBase(repo);
  // Dev's own address for this change, and the only one the page *posts*
  // to: ship, say and the escape to the diff all live under
  // `/pulls/:number`, whether a reader arrived there or at
  // `/changes/:number` (`changeHref`, nouns.ts).
  // The pull request's address, and the only one the page *posts* to:
  // ship, say and the escape to the diff all live under `/pulls/:number`.
  const thread = `${base}/pulls/${pull.number}`;
  const wordCtx: WordCtx = {
    db,
@@ -624,7 +617,7 @@
async function changeConversation(
            : {}),
          state: pull.state,
          locked: pull.mergedAt !== null,
          closeLabel: "Close change",
          closeLabel: "Close pull request",
          crewNote: threadNote(ctx.app.db, repo, pull),
        })}
      </div>
@@ -33,13 +33,13 @@
const RUN_LINK = /^\/[^/]+\/[^/]+\/runs\/[A-Za-z0-9_-]+$/;
const KIND_LABEL: Record<FeedItem["kind"], string> = {
  run: "Run",
  ask: "Needs you",
  pull: "Change",
  pull: "Pull request",
  decision: "Decision",
  map: "Map",
  cost: "Cost",
  milestone: "Watching",
  choose: "Choose",
  tell: "Told",
  tell: "Issue",
  reply: "Reply",
  look: "Look",
  release: "Release",
@@ -196,7 +196,7 @@
export function feedNote(): Html {
}
const CHIP_LABEL: Record<KindChip, string> = {
  reviews: "Changes",
  reviews: "Pull requests",
  decisions: "Decisions",
  crew: "Crew words",
  releases: "Releases",
@@ -61,7 +61,7 @@
export function holdCard(
    );
  if (!may || !open) return null;
  return html`<details class="mt mb" id="hold">
    <summary class="muted small">Hold this change</summary>
    <summary class="muted small">Hold this pull request</summary>
    <form class="bar mt" method="post" action="${thread}/hold">
      <input
        class="input"
@@ -1,12 +1,12 @@
/**
 * The forge's three lists — everything told, every change, every run — and
 * The forge's three lists — issues, pull requests, runs — and
 * the one filter bar they share: five words, each a link carrying `?word=`,
 * so what a person is looking at lives in the address and can be shared. A
 * row is the same word, note and time the thing's own page shows, because
 * every one of them is read through `tellWord`/`pullWord`/`runWord`. Each
 * list is bounded to one page. Told and changes are the only lists of
 * issues and pulls there are: every repository, every viewer, at `/issues`
 * and `/tells`, `/pulls` and `/changes` alike.
 * list is bounded to one page. These are the only lists of issues and
 * pulls there are: every repository, every viewer, at `/issues` and
 * `/pulls`.
 */
import { sealedScope } from "../../core/sealed.ts";
@@ -116,6 +116,7 @@
function emptyNote(
  starter: string,
): string {
  if (filter === undefined) return starter;
  if (filter === "told") return `${subject} is waiting to be picked up.`;
  return `${subject} is ${filter} yet.`;
}
@@ -134,7 +135,9 @@
function wordFilterBar(
    ${seg([
      { label: "Open", href: href(undefined), current: open },
      ...words.map((w) => ({
        label: w[0]!.toUpperCase() + w.slice(1),
        // `told` is the state of an issue nobody has picked up: the filter
        // says so in those words, never as a noun for the issue (#3241).
        label: w === "told" ? "Not started" : w[0]!.toUpperCase() + w.slice(1),
        href: href(w),
        current: current === w,
      })),
@@ -323,7 +326,7 @@
function listRead(ctx: Ctx, repo: Repo, f: ListFacets) {
}
/**
 * GET /:owner/:name/issues, and /tells: everything told, for every
 * GET /:owner/:name/issues: every issue, for every
 * repository and every viewer — one row per issue in its studio word, who
 * has it, its labels, when it last moved, and the tell itself as the row's
 * own link. `?word=` narrows it, and so do `?label=`, `?assignee=`,
@@ -366,7 +369,7 @@
export async function tellsList(ctx: Ctx): Promise<Response> {
          title: "Nothing here",
          note: emptyNote(
            f.word,
            record === undefined ? "No issue" : "Nothing told",
            "No issue",
            record === undefined
              ? "Nothing open."
              : "Nothing open. Tell the crew what you want and it shows up here.",
@@ -386,18 +389,17 @@
export async function tellsList(ctx: Ctx): Promise<Response> {
              )}${issue.assigneeName
                ? html`${issue.assigneeName} · `
                : null}${info.note} · ${time(issue.updatedAt)}`,
              trail: wordBadge(info.word, undefined, record === undefined),
              trail: wordBadge(info.word),
            }),
          ),
        );
  const lastNumber = fetched[fetched.length - 1]?.number;
  // Self-links follow whichever noun reached this page — `/tells` or
  // `/issues` — so paging never jumps a reader to the other address.
  // Self-links follow the address that reached this page.
  const listBase = ctx.url.pathname;
  // The one verb besides opening a row: say what you want. It posts from
  // `/issues/new`, the compose page, in the words the repository has.
  const compose = when(ctx.auth.user, () =>
    btn(PAGE_TITLES.compose[record === undefined ? "dev" : "studio"], {
    btn(PAGE_TITLES.compose, {
      href: `${base}/issues/new`,
      size: "sm",
      variant: "outline",
@@ -464,7 +466,7 @@
export async function tellsList(ctx: Ctx): Promise<Response> {
}
/**
 * GET /:owner/:name/pulls, and /changes: every change, for every
 * GET /:owner/:name/pulls: every pull request, for every
 * repository and every viewer — one row per pull in its studio word, who
 * made it, its labels, when it last moved, and the change itself as the
 * row's own link. Where a change lives, its diff and its reviews are one
@@ -499,10 +501,10 @@
export async function changesList(ctx: Ctx): Promise<Response> {
          title: "Nothing here",
          note: emptyNote(
            f.word,
            "No change",
            "No pull request",
            record === undefined
              ? "Nothing open."
              : "Nothing open. A change is the crew's proposed edit to your app; the crew opens them as it works.",
              : "Nothing open. A pull request is the crew's proposed edit to your app; the crew opens them as it works.",
          ),
        })
      : listCard(
@@ -517,12 +519,12 @@
export async function changesList(ctx: Ctx): Promise<Response> {
                ? originTag(pull.originAuthor, originGlyph(repo))
                : pull.authorName} · ${info.note} ·
              ${when(answered.get(pull.number), (t) => html`${tellLine(base, t)} · `)}${time(pull.updatedAt)}`,
              trail: wordBadge(info.word, undefined, record === undefined),
              trail: wordBadge(info.word),
            }),
          ),
        );
  const lastNumber = fetched[fetched.length - 1]?.number;
  // See `tellsList`: `/changes` or `/pulls`, whichever reached this page.
  // See `tellsList`.
  const listBase = ctx.url.pathname;
  const body = html`${repoHeader(ctx, repo, "pulls")}
@@ -669,7 +671,7 @@
export async function runsListPage(ctx: Ctx, repo: Repo): Promise<Response> {
                    ${time(run.finishedAt ?? run.createdAt)}`
                  : html`${run.kind === "agent" ? html`${who} · ` : null}${info.note}
              · ${time(run.finishedAt ?? run.createdAt)}`,
              trail: wordBadge(info.word, undefined, record === undefined),
              trail: wordBadge(info.word),
            });
          }),
        );
@@ -1,39 +1,35 @@
/**
 * The studio's nouns: where one tell and one change live, and the one rule
 * for whether a viewer gets the studio at all on a repository. Every studio
 * surface — the app page, the asks, the lists, a tell, a change, the search
 * box and the palette — builds its links through here, so the page a reader
 * came from and the address bar they land in can never disagree about where
 * a tell lives.
 * Where one issue and one pull request live on an app's repository, and the
 * one rule for whether a viewer gets the studio at all on a repository.
 * Every studio surface — the app page, the asks, the lists, an issue, a
 * pull request, the search box and the palette — builds its links through
 * here, so the page a reader came from and the address bar they land in can
 * never disagree.
 *
 * Dev's own addresses are never closed: `/issues/:number` and
 * `/pulls/:number` answer exactly as they always have, in both modes, so
 * every link already written to one keeps working forever. This is a second
 * door, not a replacement — and the doors that *change* something are not
 * here at all. A form still posts where it has always posted
 * (`/pulls/:number/ship`, `/issues/:number/comments`), which is what the
 * same-origin checks and `form-action 'self'` are written against.
 * Issues and pull requests are called that in every mode (#3241): the
 * studio once had its own nouns ("told", "changes") and its own addresses
 * for them, `/tells` and `/changes`. Those addresses now answer 301 to
 * `/issues` and `/pulls` (`src/http/server.ts`) so every link already
 * written to one keeps working; nothing here builds one any more.
 */
import { getAppByRepo, type AppRecord } from "../../core/apps.ts";
import type { Repo } from "../../core/repos.ts";
import type { Ctx } from "../../http/context.ts";
/** Everything told — the studio's own door onto `/issues`. */
export const tellsHref = (base: string): string => `${base}/tells`;
/** The issues list (`tellsList`, `src/web/studio/lists.ts`). */
export const tellsHref = (base: string): string => `${base}/issues`;
/** Every change — the studio's own door onto `/pulls`. */
export const changesHref = (base: string): string => `${base}/changes`;
/** The pull requests list (`changesList`, `src/web/studio/lists.ts`). */
export const changesHref = (base: string): string => `${base}/pulls`;
/** One tell: the same page `/issues/:number` reaches, under the studio's
 * own noun (`tellPage`, `src/web/pages/issues.ts`). */
/** One issue (`tellPage`, `src/web/studio/tell.ts`). */
export const tellHref = (base: string, number: number): string =>
  `${base}/tells/${number}`;
  `${base}/issues/${number}`;
/** One change: the same page `/pulls/:number` reaches, under the studio's
 * own noun (`changePage`, `src/web/studio/change.ts`). */
/** One pull request (`pullPage`, `src/web/studio/change.ts`). */
      
        sentinelcrew
        24d ago
        outdated
      
      changePage no longer exists after this pull. The page is pullPage in src/web/studio/change.ts.
    
export const changeHref = (base: string, number: number): string =>
  `${base}/changes/${number}`;
  `${base}/pulls/${number}`;
/**
 * The one rule for whether a page speaks the studio's words on this repo:
@@ -47,28 +43,34 @@
export function studioRecord(ctx: Ctx, repo: Repo): AppRecord | undefined {
/**
 * What each page a studio viewer can reach calls itself in the browser tab
 * — the bookmark, the history entry, the first thing a screen reader says
 * on arrival — in both faces, decided here beside the addresses so a page
 * never carries a second literal of its own. `studio` is the word when
 * `studioRecord` gives the page a studio; `dev` is today's word for dev and
 * for any repository that is not an app. A single tell, change or run
 * titles itself by its own title, and the app page by the app's name, so
 * none of those is here.
 * on arrival — decided here beside the addresses so a page never carries a
 * second literal of its own. Issues, pull requests, compose and settings
 * are one word in every mode (#3241); only the runs list still has two
 * faces: `studio` when `studioRecord` gives the page a studio, `dev` for
 * dev and any repository that is not an app. A single issue, pull request
 * or run titles itself by its own title, and the app page by the app's
 * name, so none of those is here.
 */
export const PAGE_TITLES = {
      
        sentinelcrew
        24d ago
        outdated
      
      studio and dev are now the same string for tells, changes and compose. Collapse them so pageTitle's studio argument decides something real (only runs still differs).
    
  tells: { studio: "Everything told", dev: "Issues" },
  changes: { studio: "Every change", dev: "Pull requests" },
  tells: "Issues",
  changes: "Pull requests",
  runs: { studio: "Every run", dev: "Runs" },
  compose: { studio: "Tell the crew", dev: "New issue" },
  settings: { studio: "Settings", dev: "Settings" },
  compose: "New issue",
  settings: "Settings",
} as const;
export type TitledPage = keyof typeof PAGE_TITLES;
/** A page's `<title>` noun and the repository it is about, in the face
 * the viewer has: `Everything told · notes`, or `Issues · notes`. */
export const pageTitle = (
 * the viewer has: `Issues · notes`, or `Every run · notes`. `studio`
 * decides only for a page with two faces (the runs list). */
export function pageTitle(
  which: TitledPage,
  repo: Repo,
  studio: boolean,
): string =>
  `${PAGE_TITLES[which][studio ? "studio" : "dev"]} · ${repo.name}`;
): string {
  const title = PAGE_TITLES[which];
  const word =
    typeof title === "string" ? title : title[studio ? "studio" : "dev"];
  return `${word} · ${repo.name}`;
}
@@ -152,7 +152,7 @@
export async function nowCard(
    .slice(0, 6);
  // Who signs a "Now" row is the one rule for it, `voiceFor`
  // (`studio/voice.ts`): a person is named to anyone who can see the row —
  // the same name `/changes` and the change's own page give — and only the
  // the same name `/pulls` and the pull request's own page give — and only the
  // crew's own work reads as the app's own story for a viewer who cannot
  // see the roster. The avatar takes the same string, so its initials can
  // never disagree with the name beside them.
@@ -259,13 +259,13 @@
export async function nowCard(
        nav: true,
        lead: avatar(who),
        title: i.title,
        meta: html`${who} · told ${time(i.createdAt)}, not picked up yet`,
        meta: html`${who} · opened ${time(i.createdAt)}, not picked up yet`,
        trail: wordBadge("waiting"),
      });
    }),
    // Held by a person: `tellWord` — the one place a tell's word is
    // decided (`studio/tell.ts`) — says so honestly, the same word and
    // note the tell's own page and "Everything told" already show for it.
    // note the issue's own page and the issues list already show for it.
    // `personHeld` has already established the holder is a person, so
    // `voiceFor` names them to every viewer who can see the row.
    ...(await Promise.all(
@@ -300,7 +300,7 @@
export async function nowCard(
        title: html`<a href="${tellHref(base, i.number)}">${i.title}</a>`,
        // The invitation is a writer's (the shelf's rule, `ownerFacts`); the
        // fact — nobody has taken it — stays for everyone.
        meta: html`told ${time(i.createdAt)} ·
        meta: html`opened ${time(i.createdAt)} ·
          <span class="muted">nobody on the crew to take it</span>${ownerFacts
            ? html` — <a href="${base}/settings">add someone</a>`
            : null}`,
@@ -277,7 +277,7 @@
export async function shelfRows(
        word === undefined
          ? stuck.has(repo.id)
            ? html`<span class="muted"
                >told — ${NOBODY_ON_CREW} to take it</span
                >open — ${NOBODY_ON_CREW} to take it</span
              >`
            : canTell
              ? html`<span class="muted">quiet — tell the crew something</span>`
@@ -240,8 +240,7 @@
async function tellClosingPull(
}
/**
 * GET /:owner/:name/issues/:number and /tells/:number: one page, two
 * addresses, for every repository and every viewer. Same `threadContext` at both, so a reader who
 * GET /:owner/:name/issues/:number, for every repository and every viewer. Same `threadContext` at both, so a reader who
 * may not see it gets the forge's not-found at either.
 */
export async function tellPage(ctx: Ctx): Promise<Response> {
@@ -279,9 +278,7 @@
async function studioTell(
  };
  const base = repoBase(repo);
  // The only address the page *posts* to: the reply, the close and every
  // Details form live under `/issues/:number`, whether a reader arrived
  // there or at `/tells/:number` (`tellHref`, nouns.ts). The write surface
  // does not move with the noun.
  // Details form live under `/issues/:number`.
  const thread = `${base}/issues/${issue.number}`;
  const direction = repo.directionIssueId === issue.id;
  const closingPull = links(() => openPullsClosing(db, repo.id).get(issue.number));
@@ -344,7 +341,7 @@
async function studioTell(
            ordinary tell</span
          >`
        : wordInfo
          ? html`${wordBadge(wordInfo.word, undefined, plain)}
          ? html`${wordBadge(wordInfo.word)}
              <span class="muted small">${wordInfo.note}</span>`
          : stateBadge(issue.state)}
      <span
@@ -419,7 +416,7 @@
async function studioTell(
          action: `${thread}/comments`,
          ...(mayClose ? { stateAction: `${thread}/state` } : {}),
          state: issue.state,
          closeLabel: plain ? "Close issue" : "Close tell",
          closeLabel: "Close issue",
          crewNote: threadNote(ctx.app.db, repo, issue),
          reasons: true,
        })}
@@ -4,7 +4,7 @@
 * of work to two different people.
 *
 * The decision, once: **an agent's name is not a secret.** A change's own
 * page and `/changes` already name the agent that opened it to anyone who
 * page and `/pulls` already name the agent that opened it to anyone who
 * can read the repository, and nothing here could take that back. What
 * "the crew" stands in for is narrower — who is on the crew is part of the
 * roster, the ceiling and the ledger, the owner's own book-keeping
@@ -17,7 +17,7 @@
 *
 *  1. Is the actor an agent? A person is named to every viewer that can see
 *     the row at all — their authorship is theirs, and the app page must
 *     say what `/changes` and the change's own page say.
 *     say what `/pulls` and the pull request's own page say.
 *  2. Can this viewer see the owner's facts? A writer reads the real name.
 *
 * Nothing here decides *whether* a row is visible: a viewer who cannot see
@@ -397,7 +397,7 @@
const WORD_ICON: Record<Word, Parameters<typeof icon>[0]> = {
 * live script repaints as a run finishes (`studioRunJs`). `cancelled` draws
 * the same quiet, secondary look as `waiting` and `planned` — a restart is
 * never the danger red a real failure earns. */
export function wordBadge(word: Word, id?: string, plain = false): Html {
export function wordBadge(word: Word, id?: string): Html {
  const variant =
    word === "look" || word === "shipped" || word === "done"
      ? "success"
@@ -411,7 +411,7 @@
export function wordBadge(word: Word, id?: string, plain = false): Html {
    data-variant="${variant}"
    data-word="${word}"
    ${id === undefined ? null : html`id="${id}"`}
    >${word === "working" ? icon("loader") : null}${plain && word === "told"
    >${word === "working" ? icon("loader") : null}${word === "told"
      ? "open"
      : word}</span
  >`;
@@ -190,7 +190,7 @@
describe("asks that expire, hold and collapse", () => {
    const lines = askLinesFor(app.db, aliceUser);
    expect(lines.map((l) => l.id)).toEqual([`look:${apples.id}`]);
    expect(lines[0]!.link).toBe(
      `/${repo.ownerName}/${repo.name}/changes/${apples.number}`,
      `/${repo.ownerName}/${repo.name}/pulls/${apples.number}`,
    );
  });
@@ -226,7 +226,7 @@
describe("asks that earn their place", () => {
      }
    ).items;
    const ask = items.find((i) => i.kind === "ask");
    expect(ask?.ask?.decision).toBe("Ship this change?");
    expect(ask?.ask?.decision).toBe("Ship this pull request?");
    expect(
      items.some((i) => (i.ask as { why?: string } | undefined)?.why === "security"),
    ).toBe(true);
@@ -334,7 +334,7 @@
describe("asks that earn their place", () => {
    const fromMcp = await mcpAsks();
    expect(fromMcp.measure.raised).toBe(6);
    expect(fromMcp.rows).toHaveLength(3);
    expect(fromMcp.rows[0]!.words.decision).toBe("Ship this change?");
    expect(fromMcp.rows[0]!.words.decision).toBe("Ship this pull request?");
    // Nothing changed: a second pass raises nothing new.
    recordAskLedger(app.db);
    expect((await mcpAsks()).measure.raised).toBe(6);
@@ -123,6 +123,6 @@
describe("a production deploy carries what it records", () => {
      })
    ).text();
    expect(page).toContain('id="run-carries"');
    expect(page).toContain(`/changes/${two.number}`);
    expect(page).toContain(`/pulls/${two.number}`);
  }, 180_000);
});
@@ -95,7 +95,7 @@
describe("the feed on the home page", () => {
    expect(text).toContain('href="/alice/open/runs/r1"');
    expect(text).toContain('action="/alice/open/runs/r1/steer"');
    const item = readFeed(app.db, alice).items[0]!;
    const tell = feedCard({ ...item, kind: "pull", link: "/alice/open/changes/1" }).text;
    const tell = feedCard({ ...item, kind: "pull", link: "/alice/open/pulls/1" }).text;
    expect(tell).toContain('action="/alice/open/tell"');
    expect(tell).toContain('data-feed="dismissed"');
    expect(tell).toContain('data-feed="muted"');
@@ -212,7 +212,7 @@
describe("the first login to a spawned forge", () => {
    expect(home).toContain("Your crew has its direction:");
    expect(home).not.toContain("already at work");
    expect(home).toContain("atlas");
    expect(home).toMatch(/href="\/marias\/bakery\/tells\/\d+"[^>]*>[^<]*Run Maria/);
    expect(home).toMatch(/href="\/marias\/bakery\/issues\/\d+"[^>]*>[^<]*Run Maria/);
    // Each app with its way in.
    expect(home).toContain('href="/marias/bakery"');
  });
@@ -319,7 +319,7 @@
describe("the manifest: what you can do here, as who you are", () => {
      headBranch: "mine",
    });
    if (!own.ok) throw new Error(String(own.error));
    const ownBody = (await manifest(`/acme/game/changes/${own.value.number}`)).body;
    const ownBody = (await manifest(`/acme/game/pulls/${own.value.number}`)).body;
    expect(ownBody.here.pull).toEqual({ number: own.value.number, runs: true });
  });
});
@@ -678,9 +678,9 @@
describe("a hold is set, shown and lifted", () => {
  test("the change page offers the hold, then says who holds it and why, with the way to let it go", async () => {
    const cookie = await signIn("alice");
    const change = `/alice/garden/changes/${pull.number}`;
    const change = `/alice/garden/pulls/${pull.number}`;
    const before = await page(change, cookie);
    expect(before).toContain("Hold this change");
    expect(before).toContain("Hold this pull request");
    expect(before).toContain(
      `action="/alice/garden/pulls/${pull.number}/hold"`,
    );
@@ -707,7 +707,7 @@
describe("a hold is set, shown and lifted", () => {
    expect(after).toContain(
      `action="/alice/garden/pulls/${pull.number}/release"`,
    );
    expect(after).not.toContain("Hold this change");
    expect(after).not.toContain("Hold this pull request");
    // The change's Files step, the one that reads the code, says it too
    // (#628: one change page; `?mode=dev` answers the same page now).
    const dev = await page(`/alice/garden/pulls/${pull.number}/files`, cookie);
@@ -134,7 +134,7 @@
describe("home is the feed", () => {
    // carries what was said.
    expect(text).toContain("Water the tomatoes at dawn");
    expect(text).toMatch(
      /href="\/alice\/garden\/tells\/1"[^>]*data-feed-open>Water the tomatoes at dawn</,
      /href="\/alice\/garden\/issues\/1"[^>]*data-feed-open>opened an issue: Water the tomatoes at dawn</,
    );
    // A reply names the tell it answers.
    expect(text).toContain("on “Water the tomatoes at dawn”: Mulch them first");
@@ -75,7 +75,7 @@
test("composer, timeline, a tell, a crew member's run and pull, a share, the app
  });
  expect(posted.status).toBe(303);
  expect(await home(alice)).toMatch(
    /href="\/alice\/garden\/tells\/1"[^>]*data-feed-open>Plant the beans</,
    /href="\/alice\/garden\/issues\/1"[^>]*data-feed-open>opened an issue: Plant the beans</,
  );
  // The crew member's run and pull are posts under its name.
@@ -94,7 +94,7 @@
test("composer, timeline, a tell, a crew member's run and pull, a share, the app
  const page = await home(alice);
  expect(page).toContain("Sorted the seed list");
  expect(page).toMatch(/fcard-who">scribe<\/strong\s*>\s*<span[^>]*data-mark="crew"/);
  expect(page).toContain("a change was opened");
  expect(page).toContain("opened a pull request");
  // A share reaches another person as a post that says who shared it.
  const shared = await share(app, alice, `event:${run.id}`, ["bob"]);
@@ -117,7 +117,7 @@
describe("issue pages end to end", () => {
    const list = await (await fetch(`${base}/mel/proj/issues`)).text();
    expect(list).toContain("First bug");
    expect(list).toContain('href="/mel/proj/tells/1"');
    expect(list).toContain('href="/mel/proj/issues/1"');
    const detail = await (await fetch(`${base}/mel/proj/issues/1`)).text();
    expect(detail).toContain("<strong>broken</strong>");
@@ -266,7 +266,7 @@
describe("a name always says who it is", () => {
          app: "alice/garden",
          actor,
          at: new Date().toISOString(),
          link: `/alice/garden/changes/${pull.number}`,
          link: `/alice/garden/pulls/${pull.number}`,
          what: "Beds",
          reason: "",
          score: 1,
@@ -156,7 +156,7 @@
test("once the check has passed, the line has no beat, no counts, and reads as p
test("the change page the owner lands on draws the same live line, with the counts", async () => {
  app.db.run("UPDATE run SET state = 'running', finished_at = NULL WHERE id = ?", [runId]);
  const res = await fetch(`${servers.url}/alice/open/changes/${numbers["open"]}`, {
  const res = await fetch(`${servers.url}/alice/open/pulls/${numbers["open"]}`, {
    headers: { cookie: `forge_session=${createSession(app.db, alice.id).token}` },
  });
  expect(res.status).toBe(200);
@@ -118,9 +118,7 @@
const SINGLES = (n: number, p: number) => [
  `/api/v1/repos/alice/square/runs/${runId}`,
  `/api/v1/repos/alice/square/runs/${runId}/log`,
  `/alice/square/issues/${n}`,
  `/alice/square/tells/${n}`,
  `/alice/square/pulls/${p}`,
  `/alice/square/changes/${p}`,
  `/alice/square/runs/${runId}`,
];
@@ -371,7 +371,7 @@
describe("the studio, continued", () => {
      expect(issues).not.toContain(`href="/alice/plainlists/issues?word=told"`);
      expect(issues).not.toContain(`href="/alice/plainlists/issues?word=look"`);
      expect(issues).toContain(
        `href="/alice/plainlists/tells/${told.value.number}"`,
        `href="/alice/plainlists/issues/${told.value.number}"`,
      );
      expect(issues).not.toContain("See dev's list");
@@ -388,26 +388,21 @@
describe("the studio, continued", () => {
    expect(runs).not.toContain("See dev's list");
  });
  test("/tells and /changes are the studio's own doors onto the same lists /issues and /pulls reach — same words, same filter, same paging", async () => {
  test("the issues and pulls lists of an app filter by word, and their self-links stay on their own address", async () => {
    const told = openIssue(app, alice, repo, {
      title: "Door test: a tell",
      body: "reached through /tells too",
      body: "reached through /issues",
    });
    if (!told.ok) throw new Error(String(told.error));
    const viaIssues = await (await get("/alice/notes/issues")).text();
    const viaTells = await (await get("/alice/notes/tells")).text();
    expect(viaTells).toContain("Door test: a tell");
    expect(viaTells).toContain('data-word="told"');
    // Self-links (the word filter, paging) follow whichever door was used,
    // so a dev URL asked for in studio mode still answers exactly as it
    // does today.
    expect(viaTells).toContain(`href="/alice/notes/tells?word=told"`);
    expect(viaIssues).toContain("Door test: a tell");
    expect(viaIssues).toContain('data-word="told"');
    expect(viaIssues).toContain(`href="/alice/notes/issues?word=told"`);
    const filtered = await (await get("/alice/notes/tells?word=told")).text();
    const filtered = await (await get("/alice/notes/issues?word=told")).text();
    expect(filtered).toContain("Door test: a tell");
    const other = await (await get("/alice/notes/tells?word=shipped")).text();
    const other = await (await get("/alice/notes/issues?word=shipped")).text();
    expect(other).not.toContain("Door test: a tell");
    const branch = await commitToBranch(app, alice, repo, {
@@ -437,18 +432,16 @@
describe("the studio, continued", () => {
    finishRun(app.db, doorCheck.id, { state: "ok", summary: "check passed" });
    const viaPulls = await (await get("/alice/notes/pulls")).text();
    const viaChanges = await (await get("/alice/notes/changes")).text();
    expect(viaChanges).toContain("Door test: a change");
    expect(viaChanges).toContain('data-word="look"');
    expect(viaChanges).toContain(`href="/alice/notes/changes?word=look"`);
    expect(viaPulls).toContain("Door test: a change");
    expect(viaPulls).toContain('data-word="look"');
    expect(viaPulls).toContain(`href="/alice/notes/pulls?word=look"`);
    const changeFiltered = await (
      await get("/alice/notes/changes?word=look")
      await get("/alice/notes/pulls?word=look")
    ).text();
    expect(changeFiltered).toContain("Door test: a change");
    const changeOther = await (
      await get("/alice/notes/changes?word=shipped")
      await get("/alice/notes/pulls?word=shipped")
    ).text();
    expect(changeOther).not.toContain("Door test: a change");
    // A green pull left open now asks the front door too (#208) — close it
@@ -456,7 +449,7 @@
describe("the studio, continued", () => {
    expect(setIssueState(app, alice, repo, doorPull, "closed").ok).toBe(true);
  });
  test("/tells and /changes answer a dev-mode viewer, ?mode=dev, and a repository that is not an app with the same list, never a bounce", async () => {
  test("/tells and /changes answer every viewer, app or not, with the same 301 to /issues and /pulls (#3241)", async () => {
    const plain = await createRepo(app, alice, {
      name: "doorlists",
      visibility: "private",
@@ -472,9 +465,10 @@
describe("the studio, continued", () => {
      ["/alice/doorlists/changes", cookie],
    ] as const) {
      const res = await get(path, { cookie: viewer });
      expect(res.status).toBe(200);
      const text = await res.text();
      expect(text).toContain(`href="${path.split("?")[0]}?word=`);
      expect(res.status).toBe(301);
      expect(res.headers.get("location")).toBe(
        path.replace(/\/tells$/, "/issues").replace(/\/changes$/, "/pulls"),
      );
    }
  });
@@ -650,44 +644,37 @@
describe("the studio, continued", () => {
    expect(pulls).not.toContain('href="/alice/composelists/pulls/new"');
  });
  test("a reader without access gets the forge's not-found on /tells and /changes, exactly as /issues and /pulls", async () => {
  test("a reader without access who follows /tells or /changes lands on the forge's not-found, exactly as /issues and /pulls", async () => {
    const anonTells = await fetch(`${base}/alice/notes/tells`, {
      headers: { cookie: "forge_mode=studio" },
      redirect: "manual",
    });
    expect(anonTells.status).toBe(404);
    const anonChanges = await fetch(`${base}/alice/notes/changes`, {
      headers: { cookie: "forge_mode=studio" },
      redirect: "manual",
    });
    expect(anonChanges.status).toBe(404);
  });
  test("/tells/:number and /changes/:number reach the same pages /issues/:number and /pulls/:number reach — one page, the same anchors, and forms that still post to dev's own address", async () => {
  test("/issues/:number and /pulls/:number are an app's issue and pull request pages, and every studio surface links there", async () => {
    const told = openIssue(app, alice, repo, {
      title: "Door test: one tell",
      body: "reached through /tells/:number too",
      body: "reached through /issues/:number",
    });
    if (!told.ok) throw new Error(String(told.error));
    const n = told.value.number;
    const viaTell = await get(`/alice/notes/tells/${n}`);
    const viaTell = await get(`/alice/notes/issues/${n}`);
    expect(viaTell.status).toBe(200);
    const tellHtml = await viaTell.text();
    const viaIssue = await (await get(`/alice/notes/issues/${n}`)).text();
    // The same page, never a second copy of the markup.
    expect(tellHtml).toContain("Door test: one tell");
    expect(tellHtml).toContain('data-word="told"');
    // Still waiting, nobody assigned: the one case the line is true (#214).
    expect(tellHtml).toContain("nobody has it yet");
    expect(viaIssue).toContain('data-word="told"');
    // The write surface does not move with the noun: the reply, the close
    // and every Details form still point at /issues/:number.
    // The reply, the close and every Details form post to /issues/:number.
    expect(tellHtml).toContain(`action="/alice/notes/issues/${n}/comments"`);
    expect(tellHtml).toContain(`action="/alice/notes/issues/${n}/assignee"`);
    // An anchor into the conversation still lands — the composer is on the
    // page either door was used.
    // An anchor into the conversation lands on the composer.
    expect(tellHtml).toContain('id="comment-body"');
    const branch = await commitToBranch(app, alice, repo, {
@@ -706,7 +693,7 @@
describe("the studio, continued", () => {
    if (!opened.ok) throw new Error(String(opened.error));
    const p = opened.value.number;
    const viaChange = await get(`/alice/notes/changes/${p}`);
    const viaChange = await get(`/alice/notes/pulls/${p}`);
    expect(viaChange.status).toBe(200);
    const changeHtml = await viaChange.text();
    expect(changeHtml).toContain("Door test: one change");
@@ -716,30 +703,22 @@
describe("the studio, continued", () => {
    expect(changeHtml).toContain(`href="/alice/notes/pulls/${p}/files"`);
    expect(changeHtml).toContain('id="comment-body"');
    // Dev's own addresses answer the studio's pages where they stand — a
    // link already written to one is never bounced anywhere.
    const stillIssue = await get(`/alice/notes/issues/${n}`);
    expect(stillIssue.status).toBe(200);
    const stillPull = await get(`/alice/notes/pulls/${p}`);
    expect(stillPull.status).toBe(200);
    // The three lists, the app page and the search box all hand out the
    // studio's noun, so a person is never given two addresses for one thing.
    const tells = await (await get("/alice/notes/tells")).text();
    expect(tells).toContain(`href="/alice/notes/tells/${n}"`);
    const changes = await (await get("/alice/notes/changes")).text();
    expect(changes).toContain(`href="/alice/notes/changes/${p}"`);
    // The lists, the app page and the search box all hand out the one
    // address, so a person is never given two addresses for one thing.
    const tells = await (await get("/alice/notes/issues")).text();
    expect(tells).toContain(`href="/alice/notes/issues/${n}"`);
    const changes = await (await get("/alice/notes/pulls")).text();
    expect(changes).toContain(`href="/alice/notes/pulls/${p}"`);
    const appPage = await (await get("/alice/notes")).text();
    expect(appPage).toContain(`href="/alice/notes/changes/${p}"`);
    expect(appPage).toContain(`href="/alice/notes/pulls/${p}"`);
    expect(appPage).not.toMatch(/href="[^"]*\/(tells|changes)\//);
    const search = await (await get("/search?q=Door+test")).text();
    expect(search).toContain(`/alice/notes/tells/${n}`);
    expect(search).toContain(`/alice/notes/changes/${p}`);
    // The palette's remote rows are folded in the browser; the index tells
    // the script which mode it is in, so it folds the same nouns.
    expect(appPage).toContain('"studio":true');
    expect(search).toContain(`/alice/notes/issues/${n}`);
    expect(search).toContain(`/alice/notes/pulls/${p}`);
    expect(search).not.toMatch(/\/alice\/notes\/(tells|changes)\//);
  });
  test("/tells/:number answers a dev-mode viewer, ?mode=dev, and a repository that is not an app with the same page, never a bounce", async () => {
  test("/tells/:number answers every viewer, app or not, with the same 301 to /issues/:number (#3241)", async () => {
    const told = openIssue(app, alice, repo, { title: "Door test: dev's way" });
    if (!told.ok) throw new Error(String(told.error));
    const n = told.value.number;
@@ -750,8 +729,8 @@
describe("the studio, continued", () => {
      }),
      await get(`/alice/notes/tells/${n}`),
    ]) {
      expect(res.status).toBe(200);
      expect(await res.text()).toContain("Door test: dev");
      expect(res.status).toBe(301);
      expect(res.headers.get("location")).toBe(`/alice/notes/issues/${n}`);
    }
    const plain = await createRepo(app, alice, {
@@ -767,18 +746,19 @@
describe("the studio, continued", () => {
    const plainTell = await get(
      `/alice/doorpages/tells/${plainTold.value.number}`,
    );
    expect(plainTell.status).toBe(200);
    expect(await plainTell.text()).toContain("Not an app");
    expect(plainTell.status).toBe(301);
    expect(plainTell.headers.get("location")).toBe(
      `/alice/doorpages/issues/${plainTold.value.number}`,
    );
  });
  test("a reader without access gets the forge's not-found on /tells/:number and /changes/:number, exactly as /issues/:number and /pulls/:number", async () => {
  test("a reader without access who follows /tells/:number or /changes/:number lands on the forge's not-found, exactly as /issues/:number and /pulls/:number", async () => {
    const told = openIssue(app, alice, repo, { title: "Door test: private" });
    if (!told.ok) throw new Error(String(told.error));
    const n = told.value.number;
    const anonTell = await fetch(`${base}/alice/notes/tells/${n}`, {
      headers: { cookie: "forge_mode=studio" },
      redirect: "manual",
    });
    expect(anonTell.status).toBe(404);
    const anonIssue = await fetch(`${base}/alice/notes/issues/${n}`, {
@@ -789,11 +769,10 @@
describe("the studio, continued", () => {
    // A number that is not a tell is not a tell at either address, and a
    // change's number is not one under the tell's own noun.
    const missing = await get("/alice/notes/tells/99999");
    const missing = await get("/alice/notes/issues/99999");
    expect(missing.status).toBe(404);
    const anonChange = await fetch(`${base}/alice/notes/changes/1`, {
      headers: { cookie: "forge_mode=studio" },
      redirect: "manual",
    });
    expect(anonChange.status).toBe(404);
  });
@@ -1313,28 +1292,28 @@
describe("the studio, continued", () => {
    const stray = await open("scout/99999-nothing", "Answers nothing");
    const own = await open("revert-22", "A person's branch");
    const list = await (await get("/alice/notes/changes")).text();
    const list = await (await get("/alice/notes/pulls")).text();
    const rowOf = (title: string) => {
      const at = list.indexOf(title);
      return list.slice(at, list.indexOf("</a>", at + 400) + 4);
    };
    expect(rowOf("Answers the tell")).toContain(`href="/alice/notes/tells/${n}"`);
    expect(rowOf("Answers the tell")).toContain(`href="/alice/notes/issues/${n}"`);
    expect(rowOf("Answers the tell")).not.toContain("already done");
    expect(rowOf("Answers nothing")).not.toContain("for tell");
    expect(rowOf("A person's branch")).not.toContain("for tell");
    expect(rowOf("Answers nothing")).not.toContain("for issue");
    expect(rowOf("A person's branch")).not.toContain("for issue");
    setIssueState(app, alice, repo, told.value, "closed");
    const closedList = await (await get("/alice/notes/changes")).text();
    expect(closedList).toContain("its tell is already done");
    const closedList = await (await get("/alice/notes/pulls")).text();
    expect(closedList).toContain("its issue is already done");
    const page = await (
      await get(`/alice/notes/changes/${answering.number}`)
      await get(`/alice/notes/pulls/${answering.number}`)
    ).text();
    expect(page).toContain(`href="/alice/notes/tells/${n}"`);
    expect(page).toContain("its tell is already done");
    expect(page).toContain(`href="/alice/notes/issues/${n}"`);
    expect(page).toContain("its issue is already done");
    for (const p of [stray, own]) {
      const res = await get(`/alice/notes/changes/${p.number}`);
      const res = await get(`/alice/notes/pulls/${p.number}`);
      expect(res.status).toBe(200);
      expect(await res.text()).not.toContain("for tell");
      expect(await res.text()).not.toContain("for issue");
    }
  });
});
@@ -492,7 +492,7 @@
describe("every open pull's preview on the studio page", () => {
    expect(production).not.toContain(note);
    const changePage = await (
      await get(`/alice/widget/changes/${pull.number}`)
      await get(`/alice/widget/pulls/${pull.number}`)
    ).text();
    expect(changePage).toContain("<h2>Preview</h2>");
    expect(changePage).toContain(note);
@@ -510,7 +510,7 @@
describe("working: a run's own page in the studio", () => {
    ).text();
    expect(page).toContain("Fix the flicker on load");
    // The tell it came from, in the studio's own noun (#158).
    expect(page).toContain(`href="/alice/engine/tells/${tell.value.number}"`);
    expect(page).toContain(`href="/alice/engine/issues/${tell.value.number}"`);
    expect(page).toContain("$0.42 spent");
    expect(page).toContain('data-word="working"');
    // An agent's own run still speaks in the agent's name (#195).
@@ -176,9 +176,9 @@
describe("finding things in the studio: /search", () => {
  test("a change and a tell are found too, each saying which app they belong to", async () => {
    const html = await (await asAlice("/search?q=chess")).text();
    expect(html).toContain("Add a chess clock timer");
    expect(html).toContain(`/alice/widgets/tells/${tellNumber}`);
    expect(html).toContain(`/alice/widgets/issues/${tellNumber}`);
    expect(html).toContain("Wire up the chess clock");
    expect(html).toContain(`/alice/widgets/changes/${changeNumber}`);
    expect(html).toContain(`/alice/widgets/pulls/${changeNumber}`);
    expect(html).toContain("alice/widgets");
  });
@@ -210,8 +210,8 @@
describe("finding things in the studio: /search", () => {
      ).text(),
    ]) {
      expect(html).toContain("Apps and repositories");
      expect(html).toContain("Tells and changes");
      expect(html).toContain(`/alice/widgets/tells/${tellNumber}`);
      expect(html).toContain("Issues and pull requests");
      expect(html).toContain(`/alice/widgets/issues/${tellNumber}`);
      expect(mainOf(html)).not.toContain('name="mode"');
    }
  });
@@ -604,8 +604,8 @@
describe("every studio page's headings form one outline", () => {
  test("the app page, the three lists, a tell, a change and a run each have one outline with no skipped level", async () => {
    const pages: Record<string, string> = {
      "the app page": "/alice/outline",
      "everything told": "/alice/outline/tells",
      "every change": "/alice/outline/changes",
      "everything told": "/alice/outline/issues",
      "every change": "/alice/outline/pulls",
      "every run": "/alice/outline/runs",
      "a tell": `/alice/outline/issues/${issueNumber}`,
      "a change": `/alice/outline/pulls/${pullNumber}`,
@@ -812,10 +812,10 @@
describe("the studio's Stop and Redeploy come back to the page they were pressed
    const stopped = await press(
      "stop",
      "studio",
      `${base}/alice/notes/changes/1`,
      `${base}/alice/notes/pulls/1`,
    );
    expect(stopped.status).toBe(303);
    expect(stopped.headers.get("location")).toBe("/alice/notes/changes/1");
    expect(stopped.headers.get("location")).toBe("/alice/notes/pulls/1");
  });
  test("no referer, or one from somewhere else, falls back to the app's studio page — never the raw /app", async () => {
@@ -1104,11 +1104,11 @@
describe("the studio names a person on the app's page, and the crew only for the
  test("an anonymous visitor reads one author for one change on all three pages, avatar included", async () => {
    const appPage = await anon("/ivy/pub");
    const changes = await anon("/ivy/pub/changes");
    const change = await anon(`/ivy/pub/changes/${personPull.number}`);
    const changes = await anon("/ivy/pub/pulls");
    const change = await anon(`/ivy/pub/pulls/${personPull.number}`);
    const onApp = rowWith(appPage, `/changes/${personPull.number}`);
    const onList = rowWith(changes, `/changes/${personPull.number}`);
    const onApp = rowWith(appPage, `/pulls/${personPull.number}`);
    const onList = rowWith(changes, `/pulls/${personPull.number}`);
    expect(onApp).toContain("ivy");
    expect(onApp).not.toContain("the crew");
    // The same name the list gives, and the same initials beside it.
@@ -1117,7 +1117,7 @@
describe("the studio names a person on the app's page, and the crew only for the
    expect(change).toContain("ivy");
    // A tell she took herself is hers on the same panel, by the same rule.
    const held = rowWith(appPage, `/tells/${heldTell.number}`);
    const held = rowWith(appPage, `/issues/${heldTell.number}`);
    expect(held).toContain("ivy");
    expect(held).not.toContain("the crew");
    expect(initialsIn(held)).toBe("i");
@@ -1125,7 +1125,7 @@
describe("the studio names a person on the app's page, and the crew only for the
  test("the crew's own change and the crew's own run still read as the crew's to that visitor", async () => {
    const appPage = await anon("/ivy/pub");
    const onApp = rowWith(appPage, `/changes/${agentPull.number}`);
    const onApp = rowWith(appPage, `/pulls/${agentPull.number}`);
    expect(onApp).toContain("the crew");
    expect(onApp).not.toContain("quill");
    expect(initialsIn(onApp)).toBe("tc");
@@ -1134,7 +1134,7 @@
describe("the studio names a person on the app's page, and the crew only for the
    expect(runRow).toContain("the crew");
    expect(runRow).not.toContain("quill");
    const tellRow = rowWith(appPage, `/tells/${waitingTell.number}`);
    const tellRow = rowWith(appPage, `/issues/${waitingTell.number}`);
    expect(tellRow).toContain("the crew");
    expect(tellRow).not.toContain("quill");
@@ -1146,9 +1146,9 @@
describe("the studio names a person on the app's page, and the crew only for the
  test("the owner still reads the crew by name, and her own change as her own", async () => {
    const appPage = await owner("/ivy/pub");
    expect(rowWith(appPage, `/changes/${agentPull.number}`)).toContain("quill");
    expect(rowWith(appPage, `/pulls/${agentPull.number}`)).toContain("quill");
    expect(rowWith(appPage, `/runs/${agentRun.id}`)).toContain("quill");
    expect(rowWith(appPage, `/changes/${personPull.number}`)).toContain("ivy");
    expect(rowWith(appPage, `/pulls/${personPull.number}`)).toContain("ivy");
  });
});
@@ -1226,7 +1226,7 @@
describe("the studio's empty lists", () => {
    await setup("blank");
    for (const [path, words] of [
      ["issues", "Tell the crew what you want"],
      ["pulls", "A change is the crew"],
      ["pulls", "A pull request is the crew"],
      ["runs", "A run is one go"],
    ] as const) {
      const page = await get(`/alice/blank/${path}`);
@@ -1241,10 +1241,10 @@
describe("the studio's empty lists", () => {
    const told = openIssue(app, alice, repo, { title: "Add a tab", body: "" });
    if (!told.ok) throw new Error(String(told.error));
    const issues = await get("/alice/busy/issues?word=shipped");
    expect(issues).toContain("Nothing told is shipped yet.");
    expect(issues).toContain("No issue is shipped yet.");
    expect(issues).not.toContain("Tell the crew what you want");
    const pulls = await get("/alice/busy/pulls?word=look");
    expect(pulls).toContain("No change is look yet.");
    expect(pulls).toContain("No pull request is look yet.");
    const runs = await get("/alice/busy/runs?word=stopped");
    expect(runs).toContain("No run is stopped yet.");
  });
@@ -226,7 +226,7 @@
describe("a stranger sees the app, not the owner's books", () => {
      // The app itself is still there: what it is, that it shipped, a way in.
      expect(page).toContain("a light that stays on");
      expect(page).toContain(">Shipped<");
      expect(page).toContain("1 change");
      expect(page).toContain("1 pull request");
      expect(page).toContain("Open the app");
      // The direction's own number is the same owner's-books fact as spend
      // and the ledger: a stranger and an anonymous visitor see neither.
@@ -2014,18 +2014,18 @@
describe("this week's shipping is counted by the database, not read off a page o
  test("the app page says 150 changes shipped, not the 100 a page of closed pulls holds", async () => {
    const page = await (await get("/alice/busy")).text();
    expect(page).toMatch(/Shipped<\/dt>\s*<dd>150 changes<\/dd>/);
    expect(page).not.toContain("100 changes");
    expect(page).toMatch(/Shipped<\/dt>\s*<dd>150 pull requests<\/dd>/);
    expect(page).not.toContain("100 pull requests");
    // And the cost of a shipped change divides by all 150.
    expect(page).toContain(
      `$${(SPENT / SHIPPED).toFixed(2)} per shipped change`,
      `$${(SPENT / SHIPPED).toFixed(2)} per shipped pull request`,
    );
  });
  test("an app with real history but nothing shipped this week reads 0 changes and no cost per change", async () => {
    const page = await (await get("/alice/quiet")).text();
    expect(page).toMatch(/Shipped<\/dt>\s*<dd>0 changes<\/dd>/);
    expect(page).not.toContain("per shipped change");
    expect(page).toMatch(/Shipped<\/dt>\s*<dd>0 pull requests<\/dd>/);
    expect(page).not.toContain("per shipped pull request");
  });
});
@@ -2130,6 +2130,6 @@
describe("a one-minute-old app's front door does not lead with a week of zeros (
  test("a stranger sees the same quiet line, not the owner's zeros", async () => {
    const page = await (await fetch(`${base}/alice/newborn`)).text();
    expect(page).toContain("Nothing to show yet");
    expect(page).not.toMatch(/Shipped<\/dt>\s*<dd>0 changes<\/dd>/);
    expect(page).not.toMatch(/Shipped<\/dt>\s*<dd>0 pull requests<\/dd>/);
  });
});
@@ -47,6 +47,30 @@
import { serve, type Servers } from "../src/http/server.ts";
import { previewVerdict } from "../src/web/studio/previews.ts";
import { testsClause } from "../src/web/studio/words.ts";
/**
 * The nouns the studio once had for issues and pull requests (#3241: "i dont
 * like the told and changes"). Issues and pull requests are called that in
 * every mode, so none of these is said as a noun for one — in a nav tab, a
 * heading, a title, a list's empty state or a feed badge. "Tell the crew"
 * stays: it is a verb, the box a person types into. Checked against the
 * whole page's visible words, the repo header's tabs included.
 */
const RETIRED_NOUNS: readonly RegExp[] = [
  />\s*Told\s*</,
  />\s*Changes\s*</,
  /\bTells\b/,
  /\bEverything told\b/i,
  /\bNothing told\b/i,
  /\bEvery change\b/i,
  /\bClose (?:tell|change)\b/i,
  /\b(?:a|the|your|this|its|no) tells?\b/i,
  /\bTells? (?:&|and) changes\b/i,
  /<span class="badge"[^>]*>\s*(?:Change|Told)\s*<\/span>/,
];
/** The addresses the studio once gave them; none is linked to any more. */
const RETIRED_HREF = /href="\/[^"/]+\/[^"/]+\/(?:tells|changes)(?:[/?"])/;
/**
 * Dev's own words, each with the reason it must never reach a studio page.
 * Checked with every `<script>` stripped first: the shared client script
@@ -88,18 +112,6 @@
const DEV_WORDS: readonly { pattern: RegExp; because: string }[] = [
    pattern: /\bmerge\b/i,
    because: "the studio's own word for a merge is shipped",
  },
  {
    pattern: /pull request/i,
    because: "the studio's own word for a pull is change",
  },
  {
    // Bare "issue" also rides the topbar's own live-event wiring
    // (`data-live="run.*,pull.*,issue.*,check.*"`) on every page, which is
    // not a word a person reads — so only the composer's own button text is
    // checked here, the shape #171 actually leaked.
    pattern: /Close issue\b/,
    because: "the studio's own word for a tell is tell",
  },
  {
    pattern: /\bworkbench\b/i,
    because:
@@ -484,7 +496,7 @@
describe("dev's vocabulary never reaches a studio page", () => {
    const blankRepo = await createRepo(app, a.value, {
      name: "blank",
      visibility: "private",
      description: "nothing told yet",
      description: "nothing asked yet",
    });
    if (!blankRepo.ok) throw new Error(String(blankRepo.error));
    const blankSeeded = await commitToBranch(app, a.value, blankRepo.value, {
@@ -521,7 +533,7 @@
describe("dev's vocabulary never reaches a studio page", () => {
        word: "app",
        path: repoPath,
        title: "vocab",
        shows: [`href="#i-pull"/></svg>Changes`],
        shows: [`href="#i-issue"/></svg>Issues`, `href="#i-pull"/></svg>Pulls`],
        hides: [`href="#i-eye"/></svg>Look`, `>Look<`, 'class="where"'],
        // #630: the app page is the home in every mode; its code, with dev's
        // where strip, is the Files step one tab over.
@@ -529,23 +541,11 @@
describe("dev's vocabulary never reaches a studio page", () => {
      {
        word: "tell",
        path: `${repoPath}/issues/${tellNumber}`,
        // #171: the composer's close button used to say "Close issue" here,
        // dev's own noun on the studio's own page.
        shows: ["Close tell"],
        // #3241: an issue is closed with "Close issue" in every mode.
        shows: ["Close issue"],
        // One issue page (#626): dev's controls are its closed Details.
        title: `${tellTitle} · vocab`,
      },
      // The studio's own nouns for the same two pages (#158): one handler
      // each, so what is walked here is the very page above under the
      // address the studio's own links hand out. No `dev` half — `?mode=dev`
      // at these addresses is a redirect to dev's own (`/issues/:number`,
      // `/pulls/:number`), which the row above already proves.
      {
        word: "tell (the studio's noun)",
        path: `${repoPath}/tells/${tellNumber}`,
        shows: [tellTitle, "Close tell"],
        title: `${tellTitle} · vocab`,
      },
      {
        word: "working",
        path: `${repoPath}/runs/${runId}`,
@@ -554,20 +554,13 @@
describe("dev's vocabulary never reaches a studio page", () => {
      {
        word: "look",
        path: `${repoPath}/pulls/${openPullNumber}`,
        // #171: the composer's close button used to say "Close pull
        // request" here, dev's own noun on the studio's own page.
        // One change page (#628): the diff, the branch and the merge box are
        // #3241: a pull request is closed with "Close pull request".
        // One pull page (#628): the diff, the branch and the merge box are
        // its Files step, which speaks git on purpose, so it is not a row.
        shows: ["Close change", `${repoPath}/pulls/${openPullNumber}/files`],
        shows: ["Close pull request", `${repoPath}/pulls/${openPullNumber}/files`],
        hides: ['class="where"'],
        title: `${openPullTitle} · vocab`,
      },
      {
        word: "look (the studio's noun)",
        path: `${repoPath}/changes/${openPullNumber}`,
        shows: [openPullTitle, "Close change"],
        title: `${openPullTitle} · vocab`,
      },
      {
        word: "shipped",
        path: `${repoPath}/pulls/${mergedPullNumber}`,
@@ -581,10 +574,6 @@
describe("dev's vocabulary never reaches a studio page", () => {
        shows: [
          tellTitle,
          untouchedTitle,
          `href="${repoPath}/tells/${tellNumber}"`,
          `href="${repoPath}/tells/${untouchedNumber}"`,
        ],
        hides: [
          `href="${repoPath}/issues/${tellNumber}"`,
          `href="${repoPath}/issues/${untouchedNumber}"`,
        ],
@@ -593,7 +582,7 @@
describe("dev's vocabulary never reaches a studio page", () => {
        // The empty case: what a new app's map says before anything is told.
        word: "map (empty)",
        path: "/alice/blank/map",
        shows: ["No tells to map yet."],
        shows: ["No issues to map yet."],
      },
      // A word from the app's own description, not its name — the app's own
      // row coming back for it proves the search reaches the description,
@@ -606,8 +595,8 @@
describe("dev's vocabulary never reaches a studio page", () => {
        word: "tells",
        path: `${repoPath}/issues`,
        shows: [untouchedTitle, tellTitle],
        // One list (#627): `?mode=dev` has no other page to show here.
        title: "Everything told · vocab",
        // One list (#627), one noun (#3241).
        title: "Issues · vocab",
      },
      {
        word: "tells (told)",
@@ -622,39 +611,18 @@
describe("dev's vocabulary never reaches a studio page", () => {
        hides: [tellTitle],
      },
      {
        word: "tells (the studio's noun)",
        path: `${repoPath}/tells`,
        shows: [untouchedTitle, tellTitle],
        title: "Everything told · vocab",
      },
      {
        // #262: the one compose page, under the studio's own noun and dev's
        // own address alike — the tab, the heading and the button all say
        // the studio's word, and the form still posts where it always has.
        word: "tell the crew (the studio's noun)",
        path: `${repoPath}/tells/new`,
        shows: [`action="${repoPath}/issues/new"`, "<h1 class=\"mt\">Tell the crew</h1>"],
        title: "Tell the crew · vocab",
      },
      {
        word: "tell the crew",
        // #262: the one compose page; #3241: called a new issue in every
        // mode, and the form still posts where it always has.
        word: "new issue",
        path: `${repoPath}/issues/new`,
        shows: [`action="${repoPath}/issues/new"`, "<h1 class=\"mt\">Tell the crew</h1>"],
        title: "Tell the crew · vocab",
        dev: ["New issue", "Create issue"],
        devTitle: "New issue · vocab",
        shows: [`action="${repoPath}/issues/new"`, "<h1 class=\"mt\">New issue</h1>", "Create issue"],
        title: "New issue · vocab",
      },
      {
        word: "changes (the studio's noun)",
        path: `${repoPath}/changes`,
        shows: [openPullTitle, secondChangeTitle],
        title: "Every change · vocab",
      },
      {
        word: "changes",
        word: "pulls",
        path: `${repoPath}/pulls`,
        shows: [openPullTitle, secondChangeTitle],
        title: "Every change · vocab",
        title: "Pull requests · vocab",
      },
      {
        word: "changes (look)",
@@ -748,6 +716,15 @@
describe("dev's vocabulary never reaches a studio page", () => {
          `${p.word} (${p.path}) said dev's word ${pattern} — ${because}`,
        ).not.toMatch(pattern);
      }
      for (const noun of RETIRED_NOUNS) {
        expect(
          visible,
          `${p.word} (${p.path}) called an issue or a pull request ${noun} (#3241)`,
        ).not.toMatch(noun);
      }
      expect(html, `${p.word} (${p.path}) linked a retired address`).not.toMatch(
        RETIRED_HREF,
      );
      for (const branch of branches) {
        expect(
          visible,
@@ -787,7 +764,7 @@
describe("dev's vocabulary never reaches a studio page", () => {
    expect(h1).not.toContain(runId);
  });
  test("the command palette speaks the studio's own nouns for an app (#246) — it rides a script tag the vocabulary walk above never opens", async () => {
  test("the command palette calls them issues and pull requests on an app too (#246, #3241) — it rides a script tag the vocabulary walk above never opens", async () => {
    const res = await fetch(`${base}${repoPath}`, {
      headers: { cookie: `${cookie}; forge_mode=studio` },
      redirect: "manual",
@@ -806,18 +783,17 @@
describe("dev's vocabulary never reaches a studio page", () => {
      "alice/vocab — Code",
      "alice/vocab — Commits",
      "alice/vocab — New issue",
      "alice/vocab — Issues",
      "alice/vocab — Pull requests",
      "alice/vocab — Told",
      "alice/vocab — Changes",
    ]) {
      expect(rows.has(t), `palette still offers "${t}" on a studio app page`).toBe(
        false,
      );
    }
    // The studio's own nouns, at the studio's own addresses.
    expect(rows.get("alice/vocab — Studio")).toBe(repoPath);
    expect(rows.get("alice/vocab — Told")).toBe(`${repoPath}/tells`);
    expect(rows.get("alice/vocab — Changes")).toBe(`${repoPath}/changes`);
    expect(rows.get("alice/vocab — Issues")).toBe(`${repoPath}/issues`);
    expect(rows.get("alice/vocab — Pull requests")).toBe(`${repoPath}/pulls`);
    // The studio's first verb — telling the crew — reachable from the
    // palette, landing on the app page where the tell box lives.
    expect(rows.get("alice/vocab — Tell the crew")).toBe(`${repoPath}#tell`);
@@ -856,14 +832,26 @@
describe("dev's vocabulary never reaches a studio page", () => {
      expect(res.status, path).toBe(200);
      expect(titleOf(await res.text()), path).toBe(title);
    }
    // No studio, no studio door: the compose address under the studio's
    // noun hands a non-app to dev's own.
    const door = await fetch(`${base}/alice/plain/tells/new`, {
      headers: { cookie: `${cookie}; forge_mode=studio` },
      redirect: "manual",
    });
    expect(door.status).toBe(303);
    expect(door.headers.get("location")).toBe("/alice/plain/issues/new");
  });
  test("the retired addresses /tells and /changes answer 301 to the issues and pulls pages, query kept, app or not (#3241)", async () => {
    const moved = new Map([
      [`${repoPath}/tells`, `${repoPath}/issues`],
      [`${repoPath}/tells?word=told`, `${repoPath}/issues?word=told`],
      [`${repoPath}/tells/new?title=hi`, `${repoPath}/issues/new?title=hi`],
      [`${repoPath}/tells/${tellNumber}`, `${repoPath}/issues/${tellNumber}`],
      [`${repoPath}/changes`, `${repoPath}/pulls`],
      [`${repoPath}/changes/${openPullNumber}`, `${repoPath}/pulls/${openPullNumber}`],
      ["/alice/plain/tells/new", "/alice/plain/issues/new"],
    ]);
    for (const [from, to] of moved) {
      const res = await fetch(`${base}${from}`, {
        headers: { cookie },
        redirect: "manual",
      });
      expect(res.status, from).toBe(301);
      expect(res.headers.get("location"), from).toBe(to);
    }
  });
  test("reopening a merged change refuses in the reader's own noun — dev's word never rides the flash on a studio page (#171)", async () => {
@@ -158,7 +158,7 @@
describe("the studio", () => {
    // The depth row on every repository's header: Files (or Code), Changes
    // (or Pulls) and Runs; Terminal only where SSH is on, which it is not here.
    expect(withDev).toContain('href="/alice/notes/files"');
    expect(withDev).toContain('href="/alice/notes/changes"');
    expect(withDev).toContain('href="/alice/notes/pulls"');
    expect(withDev).toContain('href="/alice/notes/runs"');
    expect(withDev).not.toContain('href="/settings/keys#terminal"');
    // The toggle's POST is gone with it.
@@ -391,7 +391,7 @@
describe("the studio", () => {
    );
    expect(lost.status).toBe(303);
    expect(lost.headers.get("location")).toBe(
      `/alice/notes/changes/${evil.number}`,
      `/alice/notes/pulls/${evil.number}`,
    );
  });
@@ -1076,7 +1076,7 @@
describe("the studio", () => {
    expect(studio).toContain("Ground work");
    // What it waits on, in the studio's own noun (#158).
    expect(studio).toContain(
      `href="/alice/notes/tells/${blocker.value.number}"`,
      `href="/alice/notes/issues/${blocker.value.number}"`,
    );
    expect(studio).toContain('data-word="working"');
    expect(studio).toContain("$0.12");
@@ -120,7 +120,7 @@
describe("tell the crew in the terminal", () => {
    } as unknown as Told;
    const answer = tellAnswer({ ok: true, value });
    expect(answer.text).toBe(toldWords(value));
    expect(answer.text).toContain("Told as #7, but mason could not take it.");
    expect(answer.text).toContain("Opened as issue #7, but mason could not take it.");
    expect(answer.text).not.toContain("is on it");
    expect(answer.tone).toBe("danger");
  });
@@ -166,13 +166,13 @@
describe("the pages", () => {
  });
  test("a tell opens on its state and first line", async () => {
    const line = unfurl(await get(`/alice/open/tells/${numbers.tell}`));
    const line = unfurl(await get(`/alice/open/issues/${numbers.tell}`));
    expect(line).toContain("Say hello from open.");
    expect(line).not.toContain("Second line");
  });
  test("a change opens on its word and its own words", async () => {
    const line = unfurl(await get(`/alice/open/changes/${numbers.change}`));
    const line = unfurl(await get(`/alice/open/pulls/${numbers.change}`));
    expect(line).toContain("Make open better.");
  });
@@ -192,8 +192,8 @@
describe("the pages", () => {
  test("no sentence uses dev's vocabulary", async () => {
    for (const path of [
      `/alice/open/tells/${numbers.tell}`,
      `/alice/open/changes/${numbers.change}`,
      `/alice/open/issues/${numbers.tell}`,
      `/alice/open/pulls/${numbers.change}`,
      `/alice/open/runs/${ids.run}`,
    ])
      expect(unfurl(await get(path))).not.toMatch(
@@ -203,8 +203,8 @@
describe("the pages", () => {
  test("a private tell, change, run and app say 'Private.' and no more", async () => {
    for (const path of [
      `/alice/hush/tells/${numbers.hushTell}`,
      `/alice/hush/changes/${numbers.hushChange}`,
      `/alice/hush/issues/${numbers.hushTell}`,
      `/alice/hush/pulls/${numbers.hushChange}`,
      `/alice/hush/runs/${ids.hushRun}`,
      "/alice/hush/app",
    ]) {
@@ -215,7 +215,7 @@
describe("the pages", () => {
  });
  test("anonymously a private page is not there at all", async () => {
    const res = await fetch(`${servers.url}/alice/hush/tells/${numbers.hushTell}`);
    const res = await fetch(`${servers.url}/alice/hush/issues/${numbers.hushTell}`);
    expect(res.status).toBe(404);
  });
});
@@ -446,7 +446,7 @@
describe("the code browser on the web", () => {
    });
    expect(repo).toBeDefined();
    const html = await text("/alice/beacon/issues", alice);
    expect(html).toContain('href="/alice/beacon/tells/1"');
    expect(html).toContain('href="/alice/beacon/issues/1"');
    expect(html).toContain("data-word=");
    expect(await text("/alice/beacon/issues/1", alice)).toContain(
      "still flickering",
@@ -458,7 +458,7 @@
describe("the code browser on the web", () => {
  test("the search page renders repositories, conversations and code", async () => {
    const html = await text("/search?q=lamp", alice);
    expect(html).toContain("Apps and repositories");
    expect(html).toContain("Tells and changes");
    expect(html).toContain("Issues and pull requests");
    expect(html).toContain(">Code");
    // A code hit says where it is and shows the line with the query marked.
    expect(html).toContain("src/lamp.ts");
@@ -772,7 +772,7 @@
describe("verdicts, threads, and the gate they open", () => {
  test("the pull list shows each pull in its word; where it stands on review is one step deeper, on the change", async () => {
    // One list (#627): a row is the pull's word, never a review badge.
    const list = await bodyOf("ada", "/acme/lib/pulls");
    expect(list).toContain(`href="/acme/lib/changes/${pullNumber}"`);
    expect(list).toContain(`href="/acme/lib/pulls/${pullNumber}"`);
    expect(list).toContain("data-word=");
    expect(words(list)).not.toContain("Needs review");
		@@ -17,15 +17,15 @@ command palette from anywhere, a field included. The box takes its query to
17	17	`/search` (`searchPage`, `src/web/pages/search.ts`), the one search in
18	18	both faces, server-rendered with no script: every repository the viewer
19	19	can see, matched by name or description, an app saying whether it is live,
20		then every tell and change whose title mentions the word, each saying
21		which app it's on and linked by the studio's noun — the same `search()`
	20	then every issue and pull request whose title mentions the word, each
	21	saying which app it's on and linked at `/issues/:n` or `/pulls/:n` — the same `search()`
22	22	the API and the palette ask, so a signed-out reader sees only what a
23	23	signed-out reader would anywhere. The studio's face leaves code to dev's:
24	24	it says _Search the code_, a link to the same page with `?mode=dev`, which
25	25	keeps that face on every link and the form until the reader leaves. The palette starts from a short local
26	26	index — your own apps, then places and actions like Home, Apps, Map, New
27	27	app — and past two characters asks that very same search, folding its apps,
28		changes and tells in under their own headings (`rankPalette`,
	28	pull requests and issues in under their own headings (`rankPalette`,
29	29	`src/web/palette.ts`), so what it turns up can never disagree with the page
30	30	behind it.
31	31
		@@ -75,10 +75,9 @@ with a door to make it one — `/settings/app`, the same "Run as an app" form
75	75	Settings already carries — open only to whoever could submit it (`canAdmin`);
76	76	a reader sees the sentence with no button that would just come back
77	77	refused. `?mode=dev` on the same URL is unaffected: the card is the studio's
78		own, never dev's. `/tells` and `/changes` on such a repository still send a
79		studio viewer on to `/issues` and `/pulls`, as they do for any repository
80		the studio does not apply to — the card names the one thing to do here,
81		not a second front door onto lists that would be empty anyway.
	78	own, never dev's. `/issues` and `/pulls` on such a repository are the same
	79	lists they are everywhere — the card names the one thing to do here, not a
	80	second front door onto lists that would be empty anyway.
82	81
83	82	An app's home in the studio (`/:owner/:name`, when the repository is an
84	83	app) shows, top to bottom: what it serves and where; the box; what asks
		@@ -152,7 +151,7 @@ it already answers only to people who can read it at all.
152	151	Whose name a row carries is one rule, in one place — `voiceFor`
153	152	(`src/web/studio/voice.ts`), which the app's page, a run's own page and the
154	153	board all sign their rows with. An agent's name is _not_ a secret: a
155		change's own page and `/changes` name the agent that opened it to anyone
	154	pull request's own page and `/pulls` name the agent that opened it to anyone
156	155	who can read the repository. "The crew" is a voice, not a redaction, and it
157	156	is chosen by what the actor is first: a person is named to every viewer
158	157	who can see the row at all, so one visitor reads one name for one change on
		@@ -202,34 +201,24 @@ presses instead of deciding.
202	201	## The three lists
203	202
204	203	`/:owner/:name/issues`, `/pulls` and `/runs` on an app, in the studio, are
205		_everything told_, _every change_ and _every run_ — dev's tabs with dev's
206		issue numbers, labels, milestones and branch names replaced by the same
207		five words the rest of the studio speaks. Each is a page of rows, newest
208		first: who has it (the assignee, the author, or who ran it), when it last
209		moved, its state as `wordBadge` draws it (`src/web/studio/words.ts`), and
210		one link — the row itself — to the tell, the change or the transcript.
211		`/:owner/:name/tells` and `/:owner/:name/changes` are the studio's own
212		nouns for the first two lists, and `/:owner/:name/tells/:number` and
213		`/:owner/:name/changes/:number` for one tell and one change — the same
214		handler each, the same authorization, the same `?word=` filter and paging,
215		not a second copy of any page; a viewer the studio does not apply to (dev
216		mode, `?mode=dev`, or a repository that is not an app) is sent on to
217		`/issues`, `/pulls`, `/issues/:number` or `/pulls/:number`, dev's own
218		address, rather than the studio's nouns ever growing a second,
219		dev-flavoured address of their own. It goes one way only: a dev URL asked
220		for in studio mode answers the studio's page where it stands, never a
221		redirect, so every link ever written to `/issues/7` keeps working and
222		`?mode=dev` on it is still the one click to dev's own. In studio mode the
223		studio's own links use the studio's nouns wherever a tell or a change is
224		linked — the three lists' rows, the app page's _now_,
225		a tell's dependencies and the change that closes it, a run's own tell, the
226		search box and the command palette — so a person is never handed two
227		addresses for one thing. The app page's own footer (`the map · everything
228		told · every change`, and _Every run_ above Now) and the repository
229		header's tabs (`Told`, `Changes`, in place of dev's `Issues`, `Pulls`) link
230		to `/tells` and `/changes`; dev's `Commits`/`Branches` stay dev's alone.
231		`/runs` has no second noun — the studio and dev share the one address
232		there. What a page _posts_ to never moves with the noun: ship, close,
	204	the app's issues, pull requests and runs — dev's tabs with dev's labels,
	205	milestones and branch names replaced by the same five words the rest of
	206	the studio speaks. Each is a page of rows, newest first: who has it (the
	207	assignee, the author, or who ran it), when it last moved, its state as
	208	`wordBadge` draws it (`src/web/studio/words.ts`), and one link — the row
	209	itself — to the issue, the pull request or the transcript. Issues and pull
	210	requests are called that in every mode (#3241): the studio once had its own
	211	nouns and addresses for them, `/tells` and `/changes`, and those —
	212	`/:owner/:name/tells`, `/tells/new`, `/tells/:number`, `/changes` and
	213	`/changes/:number` — now answer 301 to `/issues`, `/issues/new`,
	214	`/issues/:number`, `/pulls` and `/pulls/:number`, query kept, in every mode,
	215	so a link ever written to them keeps working. A dev URL asked for in studio
	216	mode answers the studio's page where it stands, never a redirect, and
	217	`?mode=dev` on it is still the one click to dev's own. The app page's own
	218	footer (`the map · issues · pull requests`, and _Every run_ above Now)
	219	and the repository header's tabs (`Issues`, `Pulls`) link to `/issues` and
	220	`/pulls`; dev's `Commits`/`Branches` stay dev's alone.
	221	What a page _posts_ to is the same address: ship, close,
233	222	comment, edit and decide keep posting under `/issues/:number` and
234	223	`/pulls/:number`, which is what `form-action 'self'` and the same-origin
235	224	checks are written against.
		@@ -265,13 +254,13 @@ production has not caught up to yet, or a run with nothing to show —
265	254	still read as _working_: still moving, not one of the five a list links to
266	255	on its own. Paging is the underlying list's own cursor, unchanged; a word
267	256	filter narrows the page it lands on rather than inventing a second scheme.
268		Told and changes are the only lists of issues and pulls: every repository,
269		app or not, and every viewer, whatever the mode, at `/issues` and `/tells`,
270		`/pulls` and `/changes` alike (`?mode=dev` changes nothing there). Besides
	257	These are the only lists of issues and pulls: every repository, app or
	258	not, and every viewer, whatever the mode, at `/issues` and `/pulls`
	259	(`?mode=dev` changes nothing there). Besides
271	260	the word they narrow by `?label=` (the repository's labels are chips under
272	261	the words), `?assignee=`, `?author=` and `?q=` (a piece of the title), each
273	262	shown as a chip that clears itself; an older `?state=closed\|all` address
274		still answers with what it asked for. Told carries one verb besides opening
	263	still answers with what it asked for. Issues carries one verb besides opening
275	264	a row — compose, for a signed-in person; a stranger on a public repository
276	265	gets "Report a problem" instead, and its writers see how many reports from
277	266	outside wait for them. A row wears its labels; a change's
		@@ -280,8 +269,7 @@ list keeps `?mode=dev` to dev's runs until that list is contracted too.
280	269
281	270	## A tell, on its own page
282	271
283		`/:owner/:name/issues/:number` — `/:owner/:name/tells/:number` in the
284		studio's own noun, the same page — on an app, in the studio, is a tell — one
	272	`/:owner/:name/issues/:number` on an app, in the studio, is a tell — one
285	273	sentence someone said to the crew — not dev's labels, milestones and
286	274	dependency form. It answers three questions: who has it (or that nobody
287	275	does yet), what it is waiting on and what waits on it (`dependenciesOf`,
		@@ -319,8 +307,7 @@ mode, renders exactly what it always has.
319	307
320	308	## The look, on its own page
321	309
322		`/:owner/:name/pulls/:n` — `/:owner/:name/changes/:n` in the studio's own
323		noun, the same page — on an app, in the studio, is the change itself —
	310	`/:owner/:name/pulls/:n` on an app, in the studio, is the change itself —
324	311	never its diff. The title and the opening post in the author's own words,
325	312	who made it and when, the check in the studio's five words (`pullWord`,
326	313	`src/web/studio/words.ts`) with its deploy one click away, the preview's
		@@ -158,10 +158,10 @@ export const TOO_LONG_WORDS = "That is too long to tell in one go.";
158	158	/** What happened, in the sentence both doors say. */
159	159	export function toldWords(told: Told): string {
160	160	if (told.routed === undefined)
161		return `Told as #${told.issue.number}. Nobody is on the crew to take it yet — add someone under Settings → Crew.`;
	161	return `Opened as issue #${told.issue.number}. Nobody is on the crew to take it yet — add someone under Settings → Crew.`;
162	162	const r = told.routed;
163	163	const who = r.builder.user.username;
164	164	return told.assigned
165	165	? `${who} is on it — ${r.size} ${r.kind}${r.by === "rule" ? "" : `, ${r.by} decided in ${r.ms} ms`}.`
166		: `Told as #${told.issue.number}, but ${who} could not take it.`;
	166	: `Opened as issue #${told.issue.number}, but ${who} could not take it.`;
167	167	}
		@@ -340,7 +340,7 @@ function fromEvent(
340	340	...(pull?.authorIsAgent ? [`by ${pull.authorName}`] : []),
341	341	].join(", ");
342	342	const toldWords = toldParts === "" ? "" : ` (${toldParts})`;
343		const change = number === undefined ? base(repo) : `${base(repo)}/changes/${number}`;
	343	const change = number === undefined ? base(repo) : `${base(repo)}/pulls/${number}`;
344	344	switch (e.kind) {
345	345	case "run.finished": {
346	346	const state = p["state"] === "failed" ? "failed" : "ok";
		@@ -364,11 +364,11 @@ function fromEvent(
364	364	};
365	365	}
366	366	case "pull.opened":
367		return { ...common, kind: "pull", link: change, what: `a change was opened${title ? `: ${clip(title)}` : ""}${toldWords}` };
	367	return { ...common, kind: "pull", link: change, what: `opened a pull request${title ? `: ${clip(title)}` : ""}${toldWords}` };
368	368	case "pull.merged":
369		return { ...common, kind: "pull", link: change, what: `a change shipped${title ? `: ${clip(title)}` : ""}${toldWords}` };
	369	return { ...common, kind: "pull", link: change, what: `merged a pull request${title ? `: ${clip(title)}` : ""}${toldWords}` };
370	370	case "pull.reviewed":
371		return { ...common, kind: "pull", link: change, what: `a change was reviewed${title ? `: ${clip(title)}` : ""}` };
	371	return { ...common, kind: "pull", link: change, what: `reviewed a pull request${title ? `: ${clip(title)}` : ""}` };
372	372	case "look.taken":
373	373	return { ...common, kind: "look", link: base(repo), what: "a new picture of it is ready" };
374	374	case "app.serving":
		@@ -380,8 +380,8 @@ function fromEvent(
380	380	return {
381	381	...common,
382	382	kind: "tell",
383		link: `${base(repo)}/tells/${number}`,
384		what: told === "" ? `told #${number}` : clip(told),
	383	link: `${base(repo)}/issues/${number}`,
	384	what: `opened an issue: ${told === "" ? `#${number}` : clip(told)}`,
385	385	};
386	386	}
387	387	case "issue.commented":
		@@ -399,7 +399,7 @@ function fromEvent(
399	399	kind: "reply",
400	400	link:
401	401	e.kind === "issue.commented"
402		? `${base(repo)}/tells/${number}`
	402	? `${base(repo)}/issues/${number}`
403	403	: change,
404	404	what: said === "" ? `replied on “${on}”` : `on “${on}”: ${clip(said)}`,
405	405	};
		@@ -193,7 +193,7 @@ async function steer(
193	193	item: Candidate,
194	194	): Promise<Outcome> {
195	195	const text = `Shared by ${sender.username} with ${agent.username}: ${words(item)} (${item.link})`;
196		const number = /\/changes\/(\d+)$/.exec(item.link)?.[1];
	196	const number = /\/pulls\/(\d+)$/.exec(item.link)?.[1];
197	197	const issue =
198	198	number === undefined ? undefined : getIssue(app.db, repo.id, Number(number));
199	199	if (issue !== undefined) {
		@@ -222,7 +222,6 @@ import {
222	222	issueThreadFragment,
223	223	newIssuePage,
224	224	newIssueSubmit,
225		newTellPage,
226	225	} from "../web/pages/issues.ts";
227	226	import { tellPage } from "../web/studio/tell.ts";
228	227	import { tellHerePage } from "../web/studio/tell_here.ts";
		@@ -331,7 +330,6 @@ import {
331	330	} from "../web/pages/crew.ts";
332	331	import { newPullPage, newPullSubmit } from "../web/pages/pulls.ts";
333	332	import {
334		changePage,
335	333	pullPage,
336	334	pullStateFragment,
337	335	} from "../web/studio/change.ts";
		@@ -621,6 +619,21 @@ const gitChallenge = () =>
621	619
622	620	// ---- the public server ----
623	621
	622	/**
	623	* A handler that answers 301 to the same repository's `/<noun>`, with the
	624	* rest of the old path (a literal, or `:number` for the matched number) and
	625	* the query kept — for addresses retired from a name, never from a page.
	626	*/
	627	function movedTo(noun: "issues" \| "pulls", rest?: "new" \| ":number"): Handler {
	628	return (ctx) => {
	629	const { owner = "", name = "", number = "" } = ctx.params;
	630	const tail =
	631	rest === undefined ? "" : `/${encodeURIComponent(rest === "new" ? "new" : number)}`;
	632	const location = `/${encodeURIComponent(owner)}/${encodeURIComponent(name)}/${noun}${tail}${ctx.url.search}`;
	633	return new Response(null, { status: 301, headers: { location } });
	634	};
	635	}
	636
624	637	export function buildRouter(): Router<Handler> {
625	638	const router = new Router<Handler>();
626	639
		@@ -1057,15 +1070,12 @@ export function buildRouter(): Router<Handler> {
1057	1070
1058	1071	// Issues (web). The literal /new is registered before /:number so it can
1059	1072	// never be captured as a number.
1060		// One list of issues: `/issues` and `/tells` are two addresses for the
1061		// same page, for every repository and every viewer.
1062	1073	router.add("GET", "/:owner/:name/issues", tellsList);
1063		// One issue page, at `/issues/:number` and `/tells/:number` alike, for
1064		// every repository and every viewer. The literal /tells is registered
1065		// before /tells/:number for the same reason /issues/new is.
1066		router.add("GET", "/:owner/:name/tells", tellsList);
1067		router.add("GET", "/:owner/:name/tells/new", newTellPage);
1068		router.add("GET", "/:owner/:name/tells/:number", tellPage);
	1074	// Issues are called issues in every mode (#3241): the studio's old
	1075	// addresses for them answer 301, so a link written to one still lands.
	1076	router.add("GET", "/:owner/:name/tells", movedTo("issues"));
	1077	router.add("GET", "/:owner/:name/tells/new", movedTo("issues", "new"));
	1078	router.add("GET", "/:owner/:name/tells/:number", movedTo("issues", ":number"));
1069	1079	router.add("GET", "/:owner/:name/report", reportPage);
1070	1080	router.add("POST", "/:owner/:name/report", reportSubmit);
1071	1081	router.add("GET", "/:owner/:name/reports", reportsPage);
		@@ -1132,12 +1142,10 @@ export function buildRouter(): Router<Handler> {
1132	1142	);
1133	1143
1134	1144	// Pull requests. Same /new-before-/:number ordering discipline.
1135		// One list of pulls, at `/pulls` and `/changes` alike; one change under
1136		// the studio's own noun. See the tells above for the rule; the forms that
1137		// ship, close and comment keep posting under /pulls/:number.
	1145	// And pull requests are called pull requests: `/changes` answers 301.
1138	1146	router.add("GET", "/:owner/:name/pulls", changesList);
1139		router.add("GET", "/:owner/:name/changes", changesList);
1140		router.add("GET", "/:owner/:name/changes/:number", changePage);
	1147	router.add("GET", "/:owner/:name/changes", movedTo("pulls"));
	1148	router.add("GET", "/:owner/:name/changes/:number", movedTo("pulls", ":number"));
1141	1149	router.add("GET", "/:owner/:name/pulls/new", newPullPage);
1142	1150	router.add("POST", "/:owner/:name/pulls/new", newPullSubmit);
1143	1151	router.add("GET", "/:owner/:name/pulls/:number", pullPage);
		@@ -68,7 +68,7 @@ export function answersScreen(f: Session, ctx: Ctx, repo: Repo): Screen {
68	68	);
69	69	if (lines.length === 0) {
70	70	emptyState(s, body!, c, {
71		title: "No tells yet",
	71	title: "No issues yet",
72	72	body: "What you tell the crew about this app shows up here, with its answer.",
73	73	});
74	74	return;
		@@ -1301,7 +1301,7 @@ export function workspaceScreen(
1301	1301	binding(["V"], "waves"),
1302	1302	...(repo === undefined ? [] : [binding(["d"], "production deploys")]),
1303	1303	...(repo !== undefined && canSeeAnswers(f.db, repo, f.user)
1304		? [binding(["a"], "your tells and the crew's answers")]
	1304	? [binding(["a"], "your issues and the crew's answers")]
1305	1305	: []),
1306	1306	...(repo !== undefined && admin()
1307	1307	? [binding(["R"], `decisions by ${(getRepoById(f.db, repo.id) ?? repo).decisionsBy} (cycle)`)]
		@@ -203,21 +203,17 @@ export function scopeHeader(
203	203	},
204	204	]),
205	205	{
206		// Studio names its own lists — told, not issues; a repository that is
207		// not an app keeps git's words.
208		label: studio ? "Told" : "Issues",
209		href: studio ? tellsHref(base) : `${base}/issues`,
210		icon: studio ? "clock" : "issue",
	206	// Issues and pull requests are called that in every mode (#3241).
	207	label: "Issues",
	208	href: tellsHref(base),
	209	icon: "issue",
211	210	...(facts.openIssues === null ? {} : { count: facts.openIssues }),
212	211	current: active === "issues",
213	212	shortcut: "g i",
214	213	},
215	214	{
216		// "Look" is the five-word state a green pull is in, and the name of
217		// the picture card on one — not the noun for this list, which is the
218		// same one `/changes` and "Every change" already use.
219		label: studio ? "Changes" : "Pulls",
220		href: studio ? changesHref(base) : `${base}/pulls`,
	215	label: "Pulls",
	216	href: changesHref(base),
221	217	icon: "pull",
222	218	...(facts.openPulls === null ? {} : { count: facts.openPulls }),
223	219	current: active === "pulls",
		@@ -383,8 +379,8 @@ export function repoPalette(ctx: Ctx, repo: Repo): PaletteItem[] {
383	379	return [
384	380	{ t: `${name} — Studio`, h: base, c: "This repo" },
385	381	{ t: `${name} — Files`, h: `${base}/files`, c: "This repo" },
386		{ t: `${name} — Told`, h: tellsHref(base), c: "This repo" },
387		{ t: `${name} — Changes`, h: changesHref(base), c: "This repo" },
	382	{ t: `${name} — Issues`, h: tellsHref(base), c: "This repo" },
	383	{ t: `${name} — Pull requests`, h: changesHref(base), c: "This repo" },
388	384	// Telling the crew is for who may direct it (`mayDirectCrew`: a
389	385	// writer, or anyone signed in where the owner let outsiders in), so
390	386	// nobody else is offered a door that leads nowhere.
		@@ -1590,15 +1590,12 @@ export const shellJs = /* js */ `
1590	1590	d: r.originKind ? 'on ' + r.originKind : 'on an origin' }
1591	1591	: { t: r.owner + '/' + r.name, h: '/' + r.owner + '/' + r.name, g: 'Repositories' });
1592	1592	});
1593		// Which noun a tell or a change lives under is the mode's, and the index
1594		// carries it — the studio's /tells/:n and /changes/:n, dev's /issues/:n
1595		// and /pulls/:n, the same addresses the server just rendered into the
1596		// page behind this box (\`tellHref\`/\`changeHref\`, src/web/studio/nouns.ts).
1597		var studio = loadIndex().studio === true;
	1593	// An issue lives at /issues/:n and a pull request at /pulls/:n in every
	1594	// mode (\`tellHref\`/\`changeHref\`, src/web/studio/nouns.ts).
1598	1595	(out.issues \|\| []).slice(0, 5).forEach(function (i) {
1599	1596	if (i.source !== 'local') return;
1600	1597	var tell = i.kind === 'issue';
1601		var noun = tell ? (studio ? 'tells' : 'issues') : (studio ? 'changes' : 'pulls');
	1598	var noun = tell ? 'issues' : 'pulls';
1602	1599	rows.push({
1603	1600	t: i.title,
1604	1601	h: '/' + i.repo.owner + '/' + i.repo.name + '/' + noun + '/' + i.number,
		@@ -38,17 +38,15 @@ import {
38	38	import {
39	39	PAGE_TITLES,
40	40	pageTitle,
41		studioRecord,
42	41	tellsHref,
43	42	} from "../studio/nouns.ts";
44	43
45	44	// ---- compose ----
46	45
47	46	/**
48		* The compose page, in the face the viewer has: the studio's own noun for
49		* it (`PAGE_TITLES.compose`) on the tab, the heading and the button, and
50		* Cancel back to the list that face calls home. The form posts to
51		* `/issues/new` in both faces — the one door that changes something.
	47	* The compose page: `PAGE_TITLES.compose` on the tab, the heading and the
	48	* button, and Cancel back to the issues list. The form posts to
	49	* `/issues/new` — the one door that changes something.
52	50	*/
53	51	function composePage(
54	52	ctx: Ctx,
		@@ -56,13 +54,12 @@ function composePage(
56	54	values: { title: string; body: string; sealed?: boolean },
57	55	error?: string,
58	56	): Response {
59		const studio = studioRecord(ctx, repo) !== undefined;
60		const heading = PAGE_TITLES.compose[studio ? "studio" : "dev"];
	57	const heading = PAGE_TITLES.compose;
61	58	const base = repoBase(repo);
62	59	return page(
63	60	{
64	61	ctx,
65		title: pageTitle("compose", repo, studio),
	62	title: pageTitle("compose", repo, false),
66	63	crumbs: crumbsFor(repo),
67	64	palette: repoPalette(ctx, repo),
68	65	body: html`${repoHeader(ctx, repo, "issues", {
		@@ -73,8 +70,8 @@ function composePage(
73	70	${newIssueForm(
74	71	repo,
75	72	values,
76		studio ? "Tell" : "Create issue",
77		studio ? tellsHref(base) : `${base}/issues`,
	73	"Create issue",
	74	tellsHref(base),
78	75	error,
79	76	)}`,
80	77	},
		@@ -173,17 +170,6 @@ function accountOrReport(ctx: Ctx, repo: Repo): Response {
173	170	});
174	171	}
175	172
176		// GET /:owner/:name/tells/new — the studio's own door onto the compose page
177		// `/issues/new` reaches, redirecting there when the studio does not apply,
178		// the same rule `tellPage` follows for one tell.
179		export function newTellPage(ctx: Ctx): Response {
180		const repo = loadRepo(ctx);
181		if (!repo) return notFoundPage(ctx);
182		if (studioRecord(ctx, repo) === undefined)
183		return redirect(`${repoBase(repo)}/issues/new${ctx.url.search}`);
184		return newIssuePage(ctx);
185		}
186
187	173	// POST /:owner/:name/issues/new
188	174	export async function newIssueSubmit(ctx: Ctx): Promise<Response> {
189	175	const repo = loadRepo(ctx);