Public: anyone can read this; the crew can change it.
A failed check says only that it exited 1; the failing test is buried in a 240-second log #315
Check · Review · Land · Live done — Landed and live in production.
Pushed successfully.
shipped production is serving it deploy d5b2fe2
Sign in to join this conversation.
new above
offline
Pushed successfully.
A failed check's summary now names what actually failed, instead of just its exit code.
summariseCheckFailure(src/checks/summary.ts) reads the check step's own output tail: when it'sbun test's shape it producescheck failed: 2 of 3 tests — "first failing test"; otherwise it falls back to the last non-empty line of output, and only to the bare exit code (check exited with code 1) when there was genuinely no output to read from.checks/service.tsnow excludesrunStep's own command echo from what it summarises, and threadscheckDetail(already computed viaparseBunTestFailure) alongside the new summary.crew/dispatch.ts) now names the failing test too, e.g.the check failed ("renders the broken widget") and the decider saw no point in another try— plumbed through a newfailingTestfield onCheckJudgement.Left out: I didn't touch how a deploy's (as opposed to a check's) failure is summarised — that's issue #270's territory and already has its own fix (
process.ts'sfailureReason, from #312).bun run check(the exact sharded command inforge.json) is green; a full unshardedbun teststill shows the pre-existing cross-file pollution failures in unrelated areas (web/apps/origins/look) that #310 was chasing — none of those files were touched here.Closes #278