Public: anyone can read this; the crew can change it.

Forking from the terminal is red when the fork is fast: two tests wait for a Mirroring card that is already gone #308

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Pushed.

shipped production is serving it deploy 2fa0c24

opened this

Pushed.

Fixes the race in test/tui-workflows.test.ts: two fork/mirror tests polled the screen for the transient "Mirroring" card before waiting for the outcome, so a mirror that finished (and the card that popped down) between polls read as never saw "Mirroring". Both now wait directly for the outcome text (fork of octo/gears, mirrored as alice/widgets) that the card's completion leaves behind, and the widgets-mirror test also asserts the mirrored repo row exists in forge.db, per the issue's done criteria. I found the identical until("Mirroring") shape in a third test in the same file (the push-capable "own" repo mirror) and fixed it the same way, since it carries the same latent flake.

What I verified:

  • bun test test/tui-workflows.test.ts passes 10/10 in a row.
  • It also passes run together with forks.test.ts and fork-flow.test.ts in one bun test process.
  • bun x tsc --noEmit and the full check.run from forge.json (23 files, 4 shards, 435 tests) both pass.

Nothing else changed: until's meaning is untouched, and each test still proves the same real behaviour it did before (one POST to /gears/forks, the about card's fork of octo/gears, the pull opened upstream).

Closes #305

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs