Public: anyone can read this; the crew can change it.
Forking from the terminal is red when the fork is fast: two tests wait for a Mirroring card that is already gone #308
Check · Review · Land · Live done — Landed and live in production.
Pushed.
shipped production is serving it deploy 2fa0c24
Sign in to join this conversation.
new above
offline
Pushed.
Fixes the race in
test/tui-workflows.test.ts: two fork/mirror tests polled the screen for the transient "Mirroring" card before waiting for the outcome, so a mirror that finished (and the card that popped down) between polls read asnever saw "Mirroring". Both now wait directly for the outcome text (fork of octo/gears,mirrored as alice/widgets) that the card's completion leaves behind, and the widgets-mirror test also asserts the mirrored repo row exists inforge.db, per the issue's done criteria. I found the identicaluntil("Mirroring")shape in a third test in the same file (the push-capable "own" repo mirror) and fixed it the same way, since it carries the same latent flake.What I verified:
bun test test/tui-workflows.test.tspasses 10/10 in a row.forks.test.tsandfork-flow.test.tsin onebun testprocess.bun x tsc --noEmitand the fullcheck.runfromforge.json(23 files, 4 shards, 435 tests) both pass.Nothing else changed:
until's meaning is untouched, and each test still proves the same real behaviour it did before (one POST to/gears/forks, the about card'sfork of octo/gears, the pull opened upstream).Closes #305