Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:360aaruftp is past its budget: trevato/forge: "the terminal lays out for the terminal it is in > under the floor, one line says what would help" faile… #3054

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/3030-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/3030-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as af0210c.

Review

Sign in to review this change.
1 file changed +6 −1
test/tui-size.test.ts +6 −1
@@ -322,9 +322,14 @@ describe("the terminal lays out for the terminal it is in", () => {
322322 expect(lines.filter((line) => line.trim() !== "").length).toBe(1);
323323 expect(h.app.screen.toText()).toContain("Resize your terminal");
324324 }
325 // At the floor a real frame is drawn, and the state survived the trip.
325 // At the floor a real frame is drawn. What fits in so few rows is the
326 // forge's own business (a health strip on a busy machine takes lines
327 // from the list), so the trip is judged where there is room: the
328 // state survived it.
326329 await h.resize(MIN_COLS, MIN_ROWS);
327330 expect(h.lines()[0]).toContain("forge");
331 expect(h.app.screen.toText()).not.toContain("Resize your terminal");
332 await h.resize(120, 40);
328333 expect(h.app.screen.toText()).toContain("alice/lighthouse");

Good: the trip is judged where there is room. Consider a message on this expect that includes the screen text, so a future failure explains itself.

329334 } finally {
330335 h.stop();

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs