afa7136
@@ -38,6 +38,21 @@
const QUEUED_SLACK_MS = 6 * 3_600_000;
 */
export const NO_TEST_NAME = "(unnamed)";
/**
 * Suites that are gates on the tree itself (#2868): each reads the source and
 * fails the pull that added the thing it forbids, the same way on any
 * machine. Many pulls tripping one in an hour is many pulls each adding
 * what it forbids (a class DESIGN.md does not name), not a lane's red, so they never make one.
 * A name here is a suite's `describe` prefix, and a test keeps it existing.
 */
export const TREE_GATES: readonly string[] = [
  "design check: nothing added outside the system (#2678) > ",
  "no polling in src/web > ",
];
/** Whether a failing test's name is one of {@link TREE_GATES}'. */
export const isTreeGate = (test: string): boolean => TREE_GATES.some((g) => test.startsWith(g));
export interface SharedTest {
  readonly repoId: string;
  /** `owner/name`, for the card. */
@@ -84,7 +99,8 @@
function pullsPerTest(db: Database, now: number, repoId: string | null): Row[] {
      new Date(now - SHARED_WINDOW_MS).toISOString(),
      repoId,
      NO_TEST_NAME,
    );
    )
    .filter((r) => !isTreeGate(r.test));
}
/**
@@ -6,6 +6,8 @@
 */
import { beforeEach, describe, expect, test } from "bun:test";
import type { Database } from "bun:sqlite";
import { Glob } from "bun";
import { readFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { migrations } from "../src/core/schema.ts";
import { openDb } from "../src/kernel/db.ts";
@@ -13,6 +15,7 @@
import { claimRun, createRun, finishRun, type Run } from "../src/core/runs.ts";
import {
  SHARED_PULLS,
  SHARED_WINDOW_MS,
  TREE_GATES,
  flakeHref,
  flakeKey,
  sharedCause,
@@ -62,6 +65,21 @@
describe("a red many pulls share", () => {
    expect(sharedTests(db)).toEqual([]);
  });
  test("a gate on the tree is each pull's own red, however many trip it (#2868)", () => {
    const gate = "design check: nothing added outside the system (#2678) > the tree is no worse than its baseline";
    for (const i of ["i1", "i2", "i3"]) red(i, [gate]);
    expect(shared(red("i4", [gate]))).toBe(false);
    expect(shared(red("i5", [gate, "X"]))).toBe(false);
    expect(sharedTests(db)).toEqual([]);
  });
  test("every tree gate names a suite that exists", () => {
    const suites = new Set<string>();
    for (const f of new Glob("test/*.test.ts").scanSync("."))
      for (const m of readFileSync(f, "utf8").matchAll(/describe\("((?:[^"\\]|\\.)*)"/g)) suites.add(`${m[1]} > `);
    for (const g of TREE_GATES) expect(suites.has(g)).toBe(true);
  });
  test("one pull red three times is its own red, not the lane's", () => {
    red("i1", ["X"]);
    red("i1", ["X"]);
		@@ -38,6 +38,21 @@ const QUEUED_SLACK_MS = 6 * 3_600_000;
38	38	*/
39	39	export const NO_TEST_NAME = "(unnamed)";
40	40
	41	/**
	42	* Suites that are gates on the tree itself (#2868): each reads the source and
	43	* fails the pull that added the thing it forbids, the same way on any
	44	* machine. Many pulls tripping one in an hour is many pulls each adding
	45	* what it forbids (a class DESIGN.md does not name), not a lane's red, so they never make one.
	46	* A name here is a suite's `describe` prefix, and a test keeps it existing.
	47	*/
	48	export const TREE_GATES: readonly string[] = [
	49	"design check: nothing added outside the system (#2678) > ",
	50	"no polling in src/web > ",
	51	];
	52
	53	/** Whether a failing test's name is one of {@link TREE_GATES}'. */
	54	export const isTreeGate = (test: string): boolean => TREE_GATES.some((g) => test.startsWith(g));
	55
41	56	export interface SharedTest {
42	57	readonly repoId: string;
43	58	/** `owner/name`, for the card. */
		@@ -84,7 +99,8 @@ function pullsPerTest(db: Database, now: number, repoId: string \| null): Row[] {
84	99	new Date(now - SHARED_WINDOW_MS).toISOString(),
85	100	repoId,
86	101	NO_TEST_NAME,
87		);
	102	)
	103	.filter((r) => !isTreeGate(r.test));
88	104	}
89	105
90	106	/**
		@@ -6,6 +6,8 @@
6	6	*/
7	7	import { beforeEach, describe, expect, test } from "bun:test";
8	8	import type { Database } from "bun:sqlite";
	9	import { Glob } from "bun";
	10	import { readFileSync } from "node:fs";
9	11	import { tmpdir } from "node:os";
10	12	import { migrations } from "../src/core/schema.ts";
11	13	import { openDb } from "../src/kernel/db.ts";
		@@ -13,6 +15,7 @@ import { claimRun, createRun, finishRun, type Run } from "../src/core/runs.ts";
13	15	import {
14	16	SHARED_PULLS,
15	17	SHARED_WINDOW_MS,
	18	TREE_GATES,
16	19	flakeHref,
17	20	flakeKey,
18	21	sharedCause,
		@@ -62,6 +65,21 @@ describe("a red many pulls share", () => {
62	65	expect(sharedTests(db)).toEqual([]);
63	66	});
64	67
	68	test("a gate on the tree is each pull's own red, however many trip it (#2868)", () => {
	69	const gate = "design check: nothing added outside the system (#2678) > the tree is no worse than its baseline";
	70	for (const i of ["i1", "i2", "i3"]) red(i, [gate]);
	71	expect(shared(red("i4", [gate]))).toBe(false);
	72	expect(shared(red("i5", [gate, "X"]))).toBe(false);
	73	expect(sharedTests(db)).toEqual([]);
	74	});
	75
	76	test("every tree gate names a suite that exists", () => {
	77	const suites = new Set<string>();
	78	for (const f of new Glob("test/*.test.ts").scanSync("."))
	79	for (const m of readFileSync(f, "utf8").matchAll(/describe\("((?:[^"\\]\|\\.)*)"/g)) suites.add(`${m[1]} > `);
	80	for (const g of TREE_GATES) expect(suites.has(g)).toBe(true);
	81	});
	82
65	83	test("one pull red three times is its own red, not the lane's", () => {
66	84	red("i1", ["X"]);
67	85	red("i1", ["X"]);