f766254
@@ -31,6 +31,13 @@
export const SHARED_PULLS = 3;
 */
const QUEUED_SLACK_MS = 6 * 3_600_000;
/**
 * What `bun test` prints for a failure that belongs to no test (an unhandled
 * error, a hook): unrelated pulls share the label, not a cause, so it never
 * makes a lane's red.
 */
export const NO_TEST_NAME = "(unnamed)";
export interface SharedTest {
  readonly repoId: string;
  /** `owner/name`, for the card. */
@@ -66,16 +73,17 @@
const PULLS_PER_TEST = `
   WHERE run.id >= ?1 AND run.finished_at >= ?2
     AND run.kind = 'check' AND run.issue_id IS NOT NULL AND run.state = 'failed'
     AND (?3 IS NULL OR run.repo_id = ?3)
     AND n.type = 'text'
     AND n.type = 'text' AND n.value <> ?4
   GROUP BY run.repo_id, n.value`;
function pullsPerTest(db: Database, now: number, repoId: string | null): Row[] {
  return db
    .query<Row, [string, string, string | null]>(PULLS_PER_TEST)
    .query<Row, [string, string, string | null, string]>(PULLS_PER_TEST)
    .all(
      idFloor(now - SHARED_WINDOW_MS - QUEUED_SLACK_MS),
      new Date(now - SHARED_WINDOW_MS).toISOString(),
      repoId,
      NO_TEST_NAME,
    );
}
@@ -56,6 +56,12 @@
describe("a red many pulls share", () => {
    expect(shared(second)).toBe(true);
  });
  test("bun's (unnamed) label is no test: unrelated pulls sharing it are not the lane's", () => {
    for (const i of ["i1", "i2", "i3"]) red(i, ["(unnamed)"]);
    expect(shared(red("i4", ["(unnamed)"]))).toBe(false);
    expect(sharedTests(db)).toEqual([]);
  });
  test("one pull red three times is its own red, not the lane's", () => {
    red("i1", ["X"]);
    red("i1", ["X"]);
		@@ -31,6 +31,13 @@ export const SHARED_PULLS = 3;
31	31	*/
32	32	const QUEUED_SLACK_MS = 6 * 3_600_000;
33	33
	34	/**
	35	* What `bun test` prints for a failure that belongs to no test (an unhandled
	36	* error, a hook): unrelated pulls share the label, not a cause, so it never
	37	* makes a lane's red.
	38	*/
	39	export const NO_TEST_NAME = "(unnamed)";
	40
34	41	export interface SharedTest {
35	42	readonly repoId: string;
36	43	/** `owner/name`, for the card. */
		@@ -66,16 +73,17 @@ const PULLS_PER_TEST = `
66	73	WHERE run.id >= ?1 AND run.finished_at >= ?2
67	74	AND run.kind = 'check' AND run.issue_id IS NOT NULL AND run.state = 'failed'
68	75	AND (?3 IS NULL OR run.repo_id = ?3)
69		AND n.type = 'text'
	76	AND n.type = 'text' AND n.value <> ?4
70	77	GROUP BY run.repo_id, n.value`;
71	78
72	79	function pullsPerTest(db: Database, now: number, repoId: string \| null): Row[] {
73	80	return db
74		.query<Row, [string, string, string \| null]>(PULLS_PER_TEST)
	81	.query<Row, [string, string, string \| null, string]>(PULLS_PER_TEST)
75	82	.all(
76	83	idFloor(now - SHARED_WINDOW_MS - QUEUED_SLACK_MS),
77	84	new Date(now - SHARED_WINDOW_MS).toISOString(),
78	85	repoId,
	86	NO_TEST_NAME,
79	87	);
80	88	}
81	89
		@@ -56,6 +56,12 @@ describe("a red many pulls share", () => {
56	56	expect(shared(second)).toBe(true);
57	57	});
58	58
	59	test("bun's (unnamed) label is no test: unrelated pulls sharing it are not the lane's", () => {
	60	for (const i of ["i1", "i2", "i3"]) red(i, ["(unnamed)"]);
	61	expect(shared(red("i4", ["(unnamed)"]))).toBe(false);
	62	expect(sharedTests(db)).toEqual([]);
	63	});
	64
59	65	test("one pull red three times is its own red, not the lane's", () => {
60	66	red("i1", ["X"]);
61	67	red("i1", ["X"]);