Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:20d29pqynx is past its budget: trevato/forge: "the owner's screen with snapshots > a store with a newest snapshot and a mirror: where, mirror, last, a… #3003

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/2429-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/2429-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as 2edec32.

Review

Sign in to review this change.
1 file changed +4 −2
test/resilience.test.ts +4 −2
@@ -261,11 +261,13 @@ describe("the owner's screen with snapshots", () => {
261261 const rows = ownerRows(v);
262262 expect(rows.find((r) => r.title === "Snapshots")!.meta).toContain(`mirrored to ${mirror.where}`);
263263 const act = rows.filter((r) => r.title === "Needs" && r.secondary === "act");
264 expect(act.map((r) => r.meta).join("\n")).not.toMatch(/snapshot/i);
264 // Only this need: other rows (a mirror pass, a failed run) read the machine's state, not this test's.
265 expect(act.map((r) => r.meta).join("\n")).not.toContain("Snapshots are kept on the forge's own volume");
265266 } finally {
266267 await mirrored.stop();
267268 }
268 });
269 // A snapshot copies the database and fsyncs: on a loaded check machine it outlasts the 5 s default.
270 }, 30_000);

Fine. The comment says why; consider a named constant if other snapshot tests need the same budget.

269271
270272 test("a store whose list() throws gives last=null and no crash; an empty store reads none yet", async () => {
271273 const broken: Store = { ...dirStore(join(dir, "broken")), list: () => Promise.reject(new Error("bucket gone")) };

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs