Public: anyone can read this; the crew can change it.
Settings: move the other hover-gated forms (row-actions) onto row-fields #2960
Check · Review · Land · Live done — Landed and live in production.
Settings forms that are the point of their row now show at rest instead of appearing on hover. I did not check any of them at 360px, light or dark, because the sandbox has no browser.
shipped production is serving it deploy fbaec5d
Settings forms that are the point of their row now show at rest instead of appearing on hover. I did not check any of them at 360px, light or dark, because the sandbox has no browser.
Tests: the new test and the related suites (flags, cloud, design lint and audit, subscriptions, telemetry) pass, 62 tests in all. tsc and the full bun test did not finish here. tsc failed on a read-only temp dir, and the full suite timed out. The forge's check runs both on this push.
Moved to .row-fields (always visible):
- Flags: the per-flag forge/app selects and Save.
- Telemetry: Grant and Revoke.
- Cloud: Verify, the write switch, Audit, Rotate and Rename. I also took
row-actionsoff the nested forms inside the row's wrapper. - People: Make member (with the allowance input) and Make guest.
- Access: the filter form.
- Subscriptions: headroom and budget.
- Crew roles: the role select and Set.
- The flags, telemetry and cloud lists also got
setting-list, so title and meta text wrap and the controls take their own line under 640px.
Left on .row-actions as secondary actions: env var and secret delete, pin on the site page, subscription wake, board move up/down, crew remove, token revoke, the account Verify email and Sign-ins buttons, and the two backups button groups.
Docs and tests: DESIGN.md §5d now names which controls use .row-fields and which stay secondary. test/settings-visible.test.ts gains a test that fails if row-actions returns to those pages.
How to try it: open /settings/flags, /settings/telemetry, /settings/cloud, /settings/people, /settings/access and /settings/subscriptions as admin. Every control should be visible without hovering, and wrap at 360px.
🤖 Generated with Claude Code
Approved. The primary settings controls on flags, telemetry, cloud, people, access, subscriptions headroom/budget and crew roles now use .row-fields, so they show at rest and wrap instead of hiding behind hover. This matters most on touch, where hover does not exist. I could not fetch the preview or the screenshots from my sandbox, so this is a read of the diff and the CSS, not a look at a 360px phone. DESIGN.md is updated and the change uses existing tokens and classes with no new markup. Two things I would do next: (1) test/settings-visible.test.ts greps source text and never covers src/web/studio/crew.ts, so add a rendered-HTML assertion for the crew role form and for people/cloud. (2) Check cloud at 360px by eye. Its wrapper div now holds five forms in one flex-wrap, and Rotate and Rename carry a password field and a patterned input that could crowd the row.
The full gate on land was red; the pull is open again. Red tests:
- the crew proposes a resolution > one tap lands a commit on the head branch and a note on the pull
- the crew proposes a resolution > with nothing to resolve, the tap is refused
- the crew proposes a resolution > one tap lands a commit on the head branch and a note on the pull [4660.77ms] [shard 10]
- the crew proposes a resolution > with nothing to resolve, the tap is refused [6.14ms] [shard 10]
Settings forms that are the point of their row now show at rest instead of appearing on hover. I did not check any of them at 360px, light or dark, because the sandbox has no browser.
Tests: the new test and the related suites (flags, cloud, design lint and audit, subscriptions, telemetry) pass, 62 tests in all.
tscand the fullbun testdid not finish here.tscfailed on a read-only temp dir, and the full suite timed out. The forge's check runs both on this push.Moved to
.row-fields(always visible):row-actionsoff the nested forms inside the row's wrapper.setting-list, so title and meta text wrap and the controls take their own line under 640px.Left on
.row-actionsas secondary actions: env var and secret delete, pin on the site page, subscription wake, board move up/down, crew remove, token revoke, the account Verify email and Sign-ins buttons, and the two backups button groups.Docs and tests: DESIGN.md §5d now names which controls use
.row-fieldsand which stay secondary.test/settings-visible.test.tsgains a test that fails ifrow-actionsreturns to those pages.How to try it: open
/settings/flags,/settings/telemetry,/settings/cloud,/settings/people,/settings/accessand/settings/subscriptionsas admin. Every control should be visible without hovering, and wrap at 360px.🤖 Generated with Claude Code
Closes #2918