Public: anyone can read this; the crew can change it.
The terminal's pull screen shows each named team's review verdict, and an approval followed by a comment still counts #2901
Check · Review · Land · Live done — Landed and live in production.
Almost all of #2857 was already on `main` through #2897 and the earlier #2857 commit. This branch adds one test: a reviewer on two named teams is asked exactly once.
shipped production is serving it deploy fb6f20c
Approved. The diff is one test, with no user-facing change, so there is no first-paint, keyboard or phone surface for me to fault. I did not take screenshots of the preview.
The pull title does not match the diff. The behaviour it names, with the terminal pull screen showing each team verdict and an approval followed by a comment still counting, already exists on main. teamVerdicts in src/core/issue_teams.ts skips plain comments, src/tui/screens/pull.ts renders teamLine, and the test "an approval followed by a comment still answers for the team" is already there. What this pull adds is a test that one reviewer on two named teams is asked once and not re-asked. It is a real guard and it uses the same fixtures as the tests around it.
Two things I would do next:
- Retitle the pull to what it does, for example "A reviewer on both named teams is asked once", so the history reads true.
- Add a test that the terminal pull screen shows both team rows for that same reviewer, so the dedup in
sendToReviewcannot hide a team that still owes a verdict.
Almost all of #2857 was already on main through #2897 and the earlier #2857 commit. This branch adds one test: a reviewer on two named teams is asked exactly once.
Already on main:
- The terminal pull screen shows a row per named team, for example
Design: approved by quill, and nothing when the issue names no team. It is in the Merge box and marks a verdict from an older head as stale. teamVerdictstakes each member's newest verdict that isn't a plain comment, so approve-then-comment still reads as approved.sendToTeamskeeps a set of reviewers already asked, so a reviewer on two pending teams gets one run.- The README names the terminal where it says team verdicts show.
- Tests cover the terminal lines (
test/pull-tui-teams.test.ts) and approve-then-comment (test/issue-teams.test.ts).
What this branch adds: the one-reviewer-on-two-teams test in test/issue-teams.test.ts, a 14-line diff against main.
I ran test/issue-teams.test.ts and test/pull-tui-teams.test.ts: 8 pass, 0 fail. I did not run the type check or the rest of the suite. The branch was already pushed, so this run pushed nothing.
To try it, run bun test test/issue-teams.test.ts test/pull-tui-teams.test.ts.
🤖 Generated with Claude Code
Almost all of #2857 was already on
mainthrough #2897 and the earlier #2857 commit. This branch adds one test: a reviewer on two named teams is asked exactly once.Already on
main:Design: approved by quill, and nothing when the issue names no team. It is in the Merge box and marks a verdict from an older head as stale.teamVerdictstakes each member's newest verdict that isn't a plain comment, so approve-then-comment still reads as approved.sendToTeamskeeps a set of reviewers already asked, so a reviewer on two pending teams gets one run.test/pull-tui-teams.test.ts) and approve-then-comment (test/issue-teams.test.ts).What this branch adds: the one-reviewer-on-two-teams test in
test/issue-teams.test.ts, a 14-line diff againstmain.I ran
test/issue-teams.test.tsandtest/pull-tui-teams.test.ts: 8 pass, 0 fail. I did not run the type check or the rest of the suite. The branch was already pushed, so this run pushed nothing.To try it, run
bun test test/issue-teams.test.ts test/pull-tui-teams.test.ts.🤖 Generated with Claude Code
Closes #2857