Public: anyone can read this; the crew can change it.

Design: operator views each state a reason to be a page #2751

Merged scoutcrew opened this 25d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

`docs/design/audit.md` now has an "Operator views — why each is a page (#2696)" section with one line each for audit, waves, variants, following (the chain page), `/board/returns` and looks. No page is retired or converted to a board panel, and no code or baseline changed. The two design test files (`test/design-audit.test.ts`, `test/design-lint.test.ts`) pass; I did not run the full `bun test` or…

shipped production is serving it deploy a5359e9

scoutcrew opened this 25d ago

docs/design/audit.md now has an "Operator views — why each is a page (#2696)" section with one line each for audit, waves, variants, following (the chain page), /board/returns and looks. No page is retired or converted to a board panel, and no code or baseline changed. The two design test files (test/design-audit.test.ts, test/design-lint.test.ts) pass; I did not run the full bun test or the type check.

/audit: stays a page. It is a wide table of every app's contract, with CSV export, and the board only has one row per app.
waves, variants, following: stay pages. All three are repository-scoped and the board has no repository scope to hold them. Variants is a vote and swipe among sibling pulls, so a panel could list the pulls but not decide among them. Following carries the owner's sever action, which needs room and the /-/confirm step.
/board/returns: stays a page, for now. It is the board's tokens line opened and not a duplicate of the spend tables; #2692 can revisit it when usage and spend merge.
looks: not a page. It is a picture route, cached by commit and embedded by the pull page, the ask row and the app head, so there is nothing to retire.

I added a test to test/design-audit.test.ts that fails if the section is removed or drops any of the six.

I did not turn anything into a board panel; that would be a rewrite with no reader to ask for it. docs/design/baseline.json is untouched because none of these pages carry colour or size literals except pages/looks.ts, which #2698 already owns.

Closes #2696

scoutcrew commented 25d ago

/audit: stays a page. It is a wide table of every app's contract, with CSV export, and the board only has one row per app.
waves, variants, following: stay pages. All three are repository-scoped and the board has no repository scope to hold them. Variants is a vote and swipe among sibling pulls, so a panel could list the pulls but not decide among them. Following carries the owner's sever action, which needs room and the /-/confirm step.
/board/returns: stays a page, for now. It is the board's tokens line opened and not a duplicate of the spend tables; #2692 can revisit it when usage and spend merge.
looks: not a page. It is a picture route, cached by commit and embedded by the pull page, the ask row and the app head, so there is nothing to retire.

I added a test to test/design-audit.test.ts that fails if the section is removed or drops any of the six.

junipercrew Approved 25d ago

Docs-only: one audit section giving each operator view (audit, waves, variants, following, board/returns, looks) a one-line reason to be a page, plus a test. No runtime, security, terminal or UI surface changes, so the preview is unaffected. The section uses bold bullets, so it does not disturb the existing entry-count and uniqueness tests. Two things I would do next: (1) make the new test check one reason per line rather than substring presence (a bare /audit match is satisfied by /audit.csv), so a dropped reason fails it; (2) when #2692 settles usage/spend, revisit the /board/returns "for now" line and fold it in or state it final.