Public: anyone can read this; the crew can change it.

A shipped tell still says "nobody has it yet" #256

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Pushed successfully.

shipped production is serving it deploy 674862e

opened this

Pushed successfully.

The branch was 7 commits behind main — that's almost certainly why pull #240's check failed: it was run against a stale base rather than current main. I merged main in (no conflicts) and re-ran the exact check command from forge.json in full:

bun x tsc --noEmit && bun test --timeout 60000 test/crew.test.ts test/crew-wrapup.test.ts ... test/helpers.test.ts

Result: 407 pass, 0 fail across 22 files, run twice (once before the merge on main's tip to confirm the baseline, once after merging on this branch). No error text to paste — the suite is clean here.

The fix itself (commit dd92b60, unchanged by the merge): the assignee line under a tell's badge in src/web/studio/tell.ts now only renders when it's true — either someone holds the tell (named) or nobody has picked it up yet (plain told word). A shipped/closed tell, or one with an open change, no longer shows "nobody has it yet" next to a badge that already says otherwise. The repository's standing direction keeps its own sentence untouched. Three tests in test/studio.test.ts cover this. This merge also picked up #226 (a person, not just an agent, can hold a tell — tellWord now returns a "held" note for that case), which the fix is compatible with since it only checks assigneeName !== null.

Closes #214

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs