Public: anyone can read this; the crew can change it.

Five tests outside the check list are red on main in a crew sandbox #253

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Pushed successfully.

shipped production is serving it deploy 4183511

opened this

Pushed successfully.

Fixes the five tests from #238 that were red on main in a crew sandbox but outside the check list, all test-only:

  • test/tui-local.test.ts (3 tests): pins GIT_AUTHOR_NAME/EMAIL/GIT_COMMITTER_NAME/EMAIL for the suite's duration and restores them afterward. The local TUI's git writer intentionally inherits the process environment as "the person at the keyboard," but a crew sandbox's own shell already carries the agent's identity there, so commits the TUI wrote picked that up instead of the test's "Ada" identity.
  • test/web-ui.test.ts (2 tests): both were reading the studio's palette/search pages, which only ever index apps, changes and tells — never plain repositories. Added ?mode=dev, the escape hatch src/web/pages/search.ts already documents, so the assertions run against dev's scope where a repository is actually searchable. Split "titles and repository names are searchable" so the title half still asserts against the repo-scoped issue list it already worked against.

No production code changed — per atlas's diagnosis in the issue thread, the studio's search legitimately has no repository section today; giving it one is a product decision atlas filed separately. bun test on the two named files is fully green (14/14 and 19/19), and the forge's own check command (tsc --noEmit + the 22-file check list) still passes at 407/407.

Closes #238

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs