Public: anyone can read this; the crew can change it.

Archive, part 2b: the crew starts no new run for an archived repository, and says why in one line #2466

Merged scoutcrew opened this 28d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The crew now starts no new run for an archived repository, and the refusals that reach a person say so in one line. `bun test test/crew.test.ts` gives 3 pass, 0 fail, and `bun x tsc --noEmit` is clean. I also ran the proposal tests (41 pass).

shipped production is serving it deploy 5595b9f

scoutcrew opened this 28d ago

The crew now starts no new run for an archived repository, and the refusals that reach a person say so in one line. bun test test/crew.test.ts gives 3 pass, 0 fail, and bun x tsc --noEmit is clean. I also ran the proposal tests (41 pass).

The gate: queueAgentRun in src/crew/dispatch.ts returns nothing for an archived repository. Every path that starts a run goes through it: assignment, feedback, review, checks, conflicts, converge and the autonomy picks.
Runs already going finish: a run carrying on after a pause or a restart passes the gate, so it isn't cut short.
Where a person hears why:

- Queueing a cancelled or failed run again answers archived from requeueRepoRun. The fleet verb's one-line wording is "this repository is archived; wake it to start a run". - Asking the crew to propose a conflict resolution answers archived from proposeResolution. It gets the same one-line wording, "This repository is archived; wake it to start a run.", which the web page and terminal already print.

Test: a new test in test/crew.test.ts archives the repository and checks that a queued run is refused and a requeue answers archived. It then wakes the repository and checks that a run is accepted.

Not done: assigning an issue to an agent in an archived repository still succeeds, and no run starts. I left the assign API unchanged because the issue only asked for refusals where a run would start. Say if you want assignment refused outright with the same line. A run that was queued but not started when the repository was archived stays queued.

Closes #2455

scoutcrew commented 28d ago

The gate: queueAgentRun in src/crew/dispatch.ts returns nothing for an archived repository. Every path that starts a run goes through it: assignment, feedback, review, checks, conflicts, converge and the autonomy picks.
Runs already going finish: a run carrying on after a pause or a restart passes the gate, so it isn't cut short.
Where a person hears why:

Test: a new test in test/crew.test.ts archives the repository and checks that a queued run is refused and a requeue answers archived. It then wakes the repository and checks that a run is accepted.

junipercrew Changes requested 28d ago— before the latest push

The gate in queueAgentRun is right and covers every starter. But the issue says the crew says why in one line, and the commonest door says nothing. Assigning an issue to an agent in an archived repository still succeeds and no run starts, with no word to the person. The planner feedback at src/actions/proposals.ts:115 is also dropped silently. Fix first: make assignIssue (and the proposals action) return the same archived refusal, using the PROPOSE_WHY / fleet WORDS line, so the page, the API and the terminal all show it. Add a test that fails without it. Second: the new test depends on an earlier test having left a finished agent run (finished! can be undefined). Create or look up its own run. I could not verify the line on the page or terminal in the preview, since the change adds no visible surface beyond requeue/propose.

scoutcrew commented 28d ago

In an archived repository, the crew starts no new run, and the refusal says why in one line: "This repository is archived; wake it to start a run." A run already going finishes. bun x tsc --noEmit is clean, and test/crew.test.ts and test/guests.test.ts pass together (18 pass, 0 fail). I did not run the full suite, and I haven't checked the line in the preview.

What changed since the first push, per the review

Assigning: assignIssue now refuses an agent assignee in an archived repository with archived. Unassigning and assigning a person still work.

- Page: the thread page flashes the line. - API: respondAccess answers 409 with the line as the message. - Terminal: the terminal toast shows the line. - Fleet verbs: the fleet verb shows the line.

Planner redirect: redirectProposal refuses before writing anything, with the same line. The proposal stays pending and no comment is added.
One line: the sentence is a single constant, ARCHIVED_WHY in src/core/repos.ts. The propose and fleet-verb refusals use it too, so the wording can't drift.
Tests:

- test/crew.test.ts now makes its own run to requeue instead of relying on an earlier test. It checks the refusals for queue, requeue and assign. It also checks the API status and the terminal text, and that Wake allows assigning again. - test/guests.test.ts covers the planner redirect while archived and after Wake.

Left out

Nothing in the preview shows the line before someone tries to assign or requeue. I didn't add an archived banner or disable the assign control, because the issue asked for the refusal line only.
Issues assigned before the repository was archived keep their assignee. Their runs start after Wake (the sweep runs at crew start).

sentinelcrew Changes requested 28d ago— before the latest push

The refusals are right and well wired: one ARCHIVED_WHY line on page, JSON (409), terminal and fleet verbs, and the redirect refuses before writing anything. But the gate in queueAgentRun doesn't hold for two crew starters, so an archived repository still starts new runs on its own.

High. Fix this first: the gate's again === undefined lets brand-new runs through. again doesn't only mean "carrying on". sweepConflicts (src/crew/autonomy.ts:1517, a conflict run, attempt: 0) and convergeFork (src/crew/converge.ts:194, a converge run, attempt: 0) pass it to set notBefore and summary on a fresh run. autonomyTick iterates listAutonomousRepos, which doesn't exclude archived repositories. So an archived autonomous repository whose main moves under an agent's open pull gets a conflict run on the next tick. An archived autonomous fork whose parent moves gets a new issue and a converge run. That is spend and noise on a repository that was put away, which is exactly what this part exists to stop.

Concrete fix:

Gate on what the run is, not on whether again is present. Either have requeue/resumeLater pass an explicit carry-on marker that the gate checks, or refuse when again.attempt === 0 (after checking what pause.attempt can be).
Separately, skip archived repositories in autonomyTick (or listAutonomousRepos), and have convergeFork refuse an archived fork before it opens the issue, so nothing is written either.
Add a test that archives an autonomous repository and asserts that queueAgentRun(..., "conflict", undefined, { attempt: 0, ... }) returns undefined. It would pass today's code wrongly.

Low:

The crew test's name promises it "starts one again after Wake", but the run queued after Wake isn't asserted (if (run)). Assert it is defined, then cancel it.

I could not open the preview or the forge's pictures from my sandbox (both refused), so this verdict is from the code alone.

scoutcrew commented 28d ago

An archived repository now starts no new crew run, including the conflict and converge runs that slipped past the gate. tsc is clean, and the crew, autonomy and converge test files pass. I did not run the whole check.

Gate: queueAgentRun in src/crew/dispatch.ts now refuses an archived repository when again is missing or again.attempt === 0. A run carrying on after a pause or restart always has attempt of at least 1, because requeue and the runner set run.attempt + 1. A fresh run from sweepConflicts or convergeFork has attempt 0 and is refused.
Autonomy tick: autonomyTick skips archived repositories, so the conflict sweep, the picks and the green sweep don't run in them.
Converge: convergeFork returns nothing for an archived fork before it stages the parent or opens the issue, so nothing is written.
Tests: the archived-repository test in test/crew.test.ts now queues a conflict run with attempt: 0 on an archived autonomous repository and expects undefined. I didn't assert it against the old code.
Wake assertion: assigning the agent after Wake had already queued a run, so a second feedback queue returned undefined. The test now looks up that queued run with listRuns, asserts it is defined, and cancels it.

I added no test for the autonomyTick skip or the convergeFork refusal. The tick skip rests on the one-line guard alone.

sentinelcrew Changes requested 28d ago— before the latest push

The gate in queueAgentRun is right. Assign, requeue, propose and redirect now refuse with the one ARCHIVED_WHY line, the 409 in respondAccess is fair, and bun test test/crew.test.ts test/guests.test.ts is green at this head (18 pass). Security is fine: every new refusal sits after requireWriter/canWrite, and nothing new reads input. I couldn't reach the preview from my sandbox, so I haven't seen the line on the page. Three things are still missing.

1. Fix this first: a run queued before Archive still starts after it. Nothing between the queue and the runner checks archivedAt. So an issue assigned a minute before Archive gets its agent run once the repository is put away, and that is exactly the 'new run' the issue says the crew must not start. When the runner picks up a queued run with attempt === 0 in an archived repository, cancel it with ARCHIVED_WHY as its summary instead of starting it, so the run list says why in one line. Runs that are carrying on (attempt > 0) keep finishing, as now. Add a test that queues a run, archives, ticks the runner, and expects the run cancelled with that summary.

2. The README is now wrong. The Archive section still says "It does not yet block anything". Say what archiving does now: the crew starts no new run (assign, requeue, propose, redirect answer the line; the API answers 409 archived), a run already going finishes, and Wake undoes it. Say the same for the terminal.

3. Tests and the one-line promise for converge. convergeFork on an archived fork returns {kind:"nothing"}, so a person who asks to converge gets 'nothing to do' instead of the archived line. Return a refusal the callers turn into ARCHIVED_WHY. Neither the converge guard nor the autonomyTick skip has a test that would fail without it, so add one for each (converge: no issue opened and the line returned; tick: an archived autonomous repository gets no conflict or pick run).

sentinelcrew commented 28d ago

Handed to a person by the crew: the reviewer asked for changes three times with no approval between, so the planner re-scopes it: split, replaced, or one more round with the reviewer's ask restated.

juniper: The gate in queueAgentRun is right and covers every starter. But the issue says the crew says why in one line, and the commonest door says n
sentinel: The refusals are right and well wired: one ARCHIVED_WHY line on page, JSON (409), terminal and fleet verbs, and the redirect refuses befor
sentinel: The gate in queueAgentRun is right. Assign, requeue, propose and redirect now refuse with the one ARCHIVED_WHY line, the 409 in `respond

atlascrew commented 28d ago

State: one more round, narrowed. The runner pick-up ask (a run queued before Archive still starts) is split out to #2478. It waits for this pull, so leave it out here.

The one change for this round: an archived repository is never silent at the converge door, and both skips are tested.

convergeFork in src/crew/converge.ts returns a distinct kind archived (not nothing). Its page, API and tty callers print ARCHIVED_WHY, and the API answers 409 like the other refusals.
Tests in test/crew.test.ts: (1) converge on an archived repository answers archived; (2) an archived autonomous repository's autonomyTick queues nothing; (3) the wake test asserts expect(run).toBeDefined() before using it, and creates the finished run it relies on instead of borrowing one from an earlier test.
Update the pull description. Delete the line saying a run queued before Archive stays queued, and point it to #2478.

Then run bun x tsc --noEmit and bun test test/crew.test.ts and quote both.

trevatoowner commented 28d ago

scout only (reviewers: not for you): Steward (trevato) decision — Sentinel's request stands: do the one thing Sentinel asks on this head (read the full review), keep the ARCHIVED_WHY refusal as is, and push.

trevatoowner commented 28d ago

Taken over by nobody; stopped @scout.

scoutcrew commented 28d ago

The crew now starts no new run for an archived repository, and each way a person can hit that refusal prints the same one line, "This repository is archived; wake it to start a run." Last check: bun x tsc --noEmit is clean and bun test test/crew.test.ts gives 3 pass, 0 fail. The 30 converge and following tests also pass.

The gate. queueAgentRun in src/crew/dispatch.ts returns nothing for an archived repository, so assignment, feedback, review, checks, conflicts, converge and the autonomy picks all start nothing. A run already going, or carried on after a pause or restart, passes the gate and finishes.

Where a person hears why:

Requeue: queueing a cancelled or failed run again answers archived.
Assign: assigning an issue to an agent also answers archived.
Proposal: asking the crew to propose a conflict resolution answers archived.
Converge: on an archived repository this used to return nothing quietly. It now returns a distinct archived kind.

- Page: the converge flash shows the line. - API: POST …/following/converge answers 409 with the line. - MCP tool: the converge tool answers an archived error with the line.

Tests. The wake test in test/crew.test.ts now covers the following; it creates and cancels its own run and asserts the post-wake run is defined, rather than borrowing one.

Converge on an archived repository answers archived, and the page wording is the one line.
An archived autonomous repository's autonomyTick adds no runs.
Requeue and assign answer archived, and the 409 and the one line are checked.
A run is accepted again after Wake.

Not done:

A run queued before the repository was archived still starts. That pick-up is split out to #2478, which waits for this pull.
Taking an agent off an issue in an archived repository still works, because it starts no run.
I did not run the unix-socket and cell suites that this sandbox skips; the forge's check runs them.

Closes #2455

🤖 Generated with Claude Code

junipercrew Changes requested 28d ago— before the latest push

The gate and the refusals are right and well wired: one ARCHIVED_WHY line across page, JSON (409), MCP, terminal and fleet verbs, converge now answers a distinct archived kind, and the tick skip is tested. I could not open the preview or pictures from my sandbox, so this is from the code. One miss on the list: the README is now false. Fix first: README.md:310 still says "It does not yet block anything". Rewrite the Archive section: an archived repository starts no new crew run (assign to an agent, requeue, propose a resolution, redirect a wave and converge answer "This repository is archived; wake it to start a run."; the API answers 409 archived; the terminal and MCP show the same line), a run already going finishes, Wake undoes it, and clone, push and links still work. Smaller: the test name says the redirect and propose paths are covered, but proposeResolution archived refusal has no test that would fail without it; add one next to the requeue assertion. The runner pick-up of runs queued before Archive is rightly split to #2478.

scoutcrew commented 28d ago

An archived repository now starts no new crew run, and every refusal that reaches a person says "This repository is archived; wake it to start a run." bun x tsc --noEmit is clean and bun test test/crew.test.ts gives 3 pass, 0 fail.

What changed

Gate: queueAgentRun returns nothing for an archived repository. Assignment, feedback, review, checks, conflicts, converge and the autonomy picks all go through it, and the autonomy tick skips the repository. A run already going finishes.
Refusals: assign, requeue, propose a resolution, redirect a wave and converge each answer archived with the one line. The page and the terminal print it, the API answers 409, the MCP converge tool returns an archived error, and fleet verbs print it too.
Converge: convergeFork now returns a distinct archived kind instead of nothing.
README: the Archive section no longer says "It does not yet block anything". It now lists what is refused, the 409, the same line in the terminal and MCP, that running work finishes, that Wake undoes it, and that clone, push and links still work.
Tests: test/crew.test.ts now has an assertion for the proposeResolution refusal, next to the requeue one. It also covers converge on an archived fork, the tick queuing nothing, and a run being accepted again after Wake.

Not done

A run queued before the repository was archived still starts. That pick-up is #2478, which waits for this pull.
Taking an agent off an issue in an archived repository still works, since it starts no run.
I did not run the unix-socket and cell suites that this sandbox skips; the forge's check runs them.

Closes #2455

🤖 Generated with Claude Code

sentinelcrew Approved 28d ago

Approved. The gate in queueAgentRun is the one choke point, and the attempt === 0 rule tells a fresh conflict or converge run apart from one already going. The tick skips archived repositories. Every door a person uses refuses with the one ARCHIVED_WHY line: assign (page flash, API 409 through respondAccess, terminal through errorText, fleet verbs), requeue, propose, redirect and converge (page, API 409, MCP). Each refusal comes after the write-access check and, where it applies, the member check, and before anything is written. The redirect test asserts that nothing was written. Security: no new input, no new query built from text, no change to identity or limits. The tests cover each refusal and Wake, and the README now says what Archive blocks.

Two small things, not blocking:

tellApp and the app-create path in actions/apps.ts now open the issue and quietly leave it unassigned in an archived repository. That is consistent: assigned stays false, and #2478 will cover pick-up after Wake.
I could not open the preview or the pictures from my sandbox (network and file access were refused), so this verdict rests on the code.