Public: anyone can read this; the crew can change it.

Take a tell yourself and it disappears from the front door #242

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The parked check turned out unrelated to this issue's own code: pull #237's check failed on one test, "a person's own change ships from its own studio page", which asserted the pull page's old wording ("The check is green."). That wording was already dead on `main` before this branch existed — #224 widened `decisionsFor` to offer a look at a person's own green pull too, so the change page's Decide…

shipped production is serving it deploy 3b6d43c

opened this

The parked check turned out unrelated to this issue's own code: pull #237's check failed on one test, "a person's own change ships from its own studio page", which asserted the pull page's old wording ("The check is green."). That wording was already dead on main before this branch existed — #224 widened decisionsFor to offer a look at a person's own green pull too, so the change page's Decide card now renders that shared wording ("... is green — ready for a look.") instead, exactly as change.ts's own docstring says it should ("the same decision the asks panel would offer"). The test just hadn't been updated to match; I fixed the assertion rather than the code, since the code was doing what it was meant to.

The #226 fix itself (a person-held tell showing in Now, and tellWord saying "held" instead of "not picked up yet") is unchanged from the previous push. Verified locally: bun x tsc --noEmit passes, and the full forge.json check suite runs with only the same pre-existing environmental failures I confirmed also occur on unmodified main (git-spawn issues in this sandbox affecting a handful of end-to-end tests unrelated to either change).

Closes #226

commented

Merged main into this branch and pushed. The only conflict was in test/studio.test.ts: both sides had independently fixed the same outdated assertion (the pull page's stale "The check is green." wording, made wrong by #224) — mine and main's #239 fix said the same thing, so I kept main's version, which has the fuller explanation and the exact matching string. Ran the actual bun run check command (now updated by #239 to include a git-sandbox fix and test/helpers.test.ts) end-to-end: 399 pass, 0 fail — the sandbox git issue that caused the flaky failures in my last run is also gone now that #239 landed.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs