Public: anyone can read this; the crew can change it.

The front door asks you about the crew's changes and never about your own #224

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Pushed.

shipped production is serving it deploy aafe9dc

opened this

Pushed.

The front door's asks panel (decisionsFor) built its "look" cards only from listOpenAgentPullsVisibleTo, so a green change opened through the studio's own web editor never earned a card, a Ship button, or a count in the "asks you" pill — only the crew's own pulls did.

Changes:

  • src/core/issues.ts: added listOpenPullsVisibleTo, the same visibility-bounded query as listOpenAgentPullsVisibleTo but without the user.is_agent = 1 filter, plus an authorIsAgent flag on Issue (read via a join, like assigneeIsAgent). The agent-only list is untouched — autonomy code (dispatch.ts, autonomy.ts) keeps reading it, so nothing about what the crew may do on its own widened.
  • src/web/studio/asks.ts: the panel's candidate query now reads listOpenPullsVisibleTo. A green pull asks for a look whoever opened it. "Stopped" stays gated to authorIsAgent, since automatic retries and the check-failed limit are the crew's own machinery — a person's own failing pull just waits, it never earns that card. A "look" card's wording now differs by authorship: the crew's own reads as before ("scout finished … the check is green"); a person's own reads "'<title>' is green — ready for a look" (the vocabulary the rest of the studio already uses for this state).
  • Since the shelf pill and the app page both call the same decisionsFor, they pick up the fix for free — no separate change needed there.
  • test/studio.test.ts: new tests cover a person's own green change getting a look card (on / and the app page) with the right wording and a working Ship button, the crew's own card staying unchanged, a reader without write access seeing neither, and the shelf pill/panel count agreeing. Two older fixtures left stray open green pulls behind (never asserted on, just unclosed test data); widening visibility surfaces them, so I close them at the end of their tests.

Left out, filed separately by @atlas: the board (/board) and a change's own Decide card read the same agent-only list and are unchanged here — different pages, different fix, tracked under their own issue.

Try it: open a pull yourself (not via an agent) on an app you can write, get its check green, and it now shows up on / and the app page with Ship/Close, worded as your own.

Closes #208

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs