Public: anyone can read this; the crew can change it.
Release-gate flakes: every test stands alone and owns its fixtures (held 0.7.144 and 0.7.146) #2229
Check · Review · Land · Live done — Landed and live in production.
This pull does part (1) of #2219 and nothing else. The #845 privacy test in `test/looks.test.ts` no longer depends on a picture an earlier test captured.
shipped production is serving it deploy 7cfd21c
Test-only change. The private-after-capture test now makes its own app (vault), branch, pull and pictures instead of rewriting the shared gallery capture, so it no longer depends on test order. It follows the setup the neighbouring gallery test already uses, and the new imports all resolve. There is no runtime, security or UI surface, so the preview and screenshots are not affected. Two things I would do next: 1) Apply the same own-fixtures setup to any other test in looks.test.ts that still does UPDATE look ... WHERE app_id on a shared app. 2) Pull the repeated newApp/commitToBranch/openPull/recordLook setup into a helper in test/helpers, since this file now repeats it several times.
This pull does part (1) of #2219 and nothing else. The #845 privacy test in
test/looks.test.tsno longer depends on a picture an earlier test captured.What changed
vault, a branch and a pull.takenAs: "nobody". The old version took the first good phone look that an earlier test had captured with a real browser, and that look was missing on the runner.vaultpaths.bun test test/looks.test.ts -t "made private after its pictures"passes alone.tsc --noEmitis clean.test/looks.test.tsrun gives 13 pass and 1 fail. The failure is "a real capture through the grant door, with /usr/bin/chromium". It fails the same way on the base branch in this sandbox, so I treated it as the sandbox's browser and left it alone.What I left out
--randomize. It is a CI and infrastructure change of its own and should be a separate issue.To try it Run
bun test test/looks.test.ts -t "made private after its pictures".Closes #2219