74180bf
@@ -303,7 +303,12 @@
export function runStreaks(db: Database): Finding[] {
        lookFor: "A green check run for the repository's newest head.",
      });
    } else {
      const pushes = failed.filter((r) => /\bpush|sandbox|operation not permitted/i.test(r.summary));
      // A decline is the run's own decision ("I pushed nothing"), not a push that failed.
      const pushes = failed.filter(
        (r) =>
          !/^declined\b/i.test(r.summary.trim()) &&
          /\bpush|sandbox|operation not permitted/i.test(r.summary),
      );
      if (pushes.length < STREAK) continue;
      out.push({
        key: `push:${repoId}`,
@@ -88,6 +88,21 @@
describe("a clean forge", () => {
  });
});
describe("a decline is not a failed push", () => {
  test("runs that say 'pushed nothing' file no push fault", async () => {
    const made = await createRepo(app, alice, { name: "quiet", visibility: "private" });
    if (!made.ok) throw new Error(String(made.error));
    for (let n = 0; n < 5; n++) {
      const run = createRun(app.db, { repoId: made.value.id, kind: "agent" });
      app.db
        .query("UPDATE run SET state = 'failed', summary = ?2, created_at = ?3 WHERE id = ?1")
        .run(run.id, "declined: I made no changes and pushed nothing.", ago((30 + n) * HOUR));
    }
    const keys = findFaults(app.db, NOW).map((f) => f.key);
    expect(keys).not.toContain(`push:${made.value.id}`);
  });
});
describe("the faults of the day", () => {
  let queuedId = "";
  beforeAll(() => {
		@@ -303,7 +303,12 @@ export function runStreaks(db: Database): Finding[] {
303	303	lookFor: "A green check run for the repository's newest head.",
304	304	});
305	305	} else {
306		const pushes = failed.filter((r) => /\bpush\|sandbox\|operation not permitted/i.test(r.summary));
	306	// A decline is the run's own decision ("I pushed nothing"), not a push that failed.
	307	const pushes = failed.filter(
	308	(r) =>
	309	!/^declined\b/i.test(r.summary.trim()) &&
	310	/\bpush\|sandbox\|operation not permitted/i.test(r.summary),
	311	);
307	312	if (pushes.length < STREAK) continue;
308	313	out.push({
309	314	key: `push:${repoId}`,
		@@ -88,6 +88,21 @@ describe("a clean forge", () => {
88	88	});
89	89	});
90	90
	91	describe("a decline is not a failed push", () => {
	92	test("runs that say 'pushed nothing' file no push fault", async () => {
	93	const made = await createRepo(app, alice, { name: "quiet", visibility: "private" });
	94	if (!made.ok) throw new Error(String(made.error));
	95	for (let n = 0; n < 5; n++) {
	96	const run = createRun(app.db, { repoId: made.value.id, kind: "agent" });
	97	app.db
	98	.query("UPDATE run SET state = 'failed', summary = ?2, created_at = ?3 WHERE id = ?1")
	99	.run(run.id, "declined: I made no changes and pushed nothing.", ago((30 + n) * HOUR));
	100	}
	101	const keys = findFaults(app.db, NOW).map((f) => f.key);
	102	expect(keys).not.toContain(`push:${made.value.id}`);
	103	});
	104	});
	105
91	106	describe("the faults of the day", () => {
92	107	let queuedId = "";
93	108	beforeAll(() => {