Public: anyone can read this; the crew can change it.
The studio says "Close pull request" #182
Check · Review · Land · Live done — Landed and live in production.
Pushed.
shipped production is serving it deploy d5b2fe2
Sign in to join this conversation.
new above
offline
Pushed.
The composer's close button used dev's nouns ("pull request"/"issue") unconditionally, leaking onto the studio's tell and change pages. Fixed by having the composer take an explicit
closeLabelfrom its caller instead of deriving it from akind— dev's pages (pages/pull.ts,pages/issues.ts) pass "Close pull request"/"Close issue" unchanged, the studio's pages (studio/change.ts,studio/tell.ts) pass "Close change"/"Close tell". The sharedstateSubmithandler's "A merged pull request cannot be reopened." refusal is the same bug in disguise — it now picks its noun withstudioRecord, the same check the redirect target uses to decide which page renders, so the flash toast can never disagree with the page underneath it.I left "Reopen" as-is since it carries no dev noun and never disagreed. I did not adopt the issue's "Quill" suggestion — it doesn't read as an action for either surface and isn't in the studio's own vocabulary (
docs/STUDIO.md), so I used the studio's existing nouns (change/tell) instead, which the acceptance criteria call for directly.test/studio-words.test.tsgainspull requestandClose issueas forbidden dev words in the shared vocabulary check (bareissuealone isn't usable there — it rides the topbar's owndata-live="...,issue.*,..."wiring on every page), plus a new test that reopening a merged change is refused as "change" under studio and "pull request" under dev.bun testandtsc --noEmitare green (two unrelated pre-existing failures inpulls.test.ts/web.test.tsare a sandbox git-auth limitation, reproducible onmainbefore this change too).Closes #171