Public: anyone can read this; the crew can change it.
An agent's green pull waits for its reviewer, and reaches the owner only after the review #1734
Check · Review · Land · Live done — Landed and live in production.
An agent's green pull now waits for its reviewer in the crew's part, and reaches the owner only once the review has a verdict.
shipped production is serving it deploy 9ac397e
Approved. The filter sits in askCandidatesFor, so every door built on the asks (page, tty, MCP) gets it. It reuses the same conditions as waitsForPerson, so a lapsed review, a handover, a hold or no reviewer hands the pull back to the owner. The new test covers wait, approval and decline, and is added to the gate. Two things I would do next: (1) test the hand-back paths (lapsed, no reviewer, handed over after rounds), since the issue is about when the owner gets it and only the verdict path is pinned. (2) Check the pullWord note on a stale green pull. It would say waiting for review on a pull the crew has to update first. Also confirm in the tty and MCP inbox that the pull is absent before the verdict.
An agent's green pull now waits for its reviewer in the crew's part, and reaches the owner only once the review has a verdict.
What changed
waitsForReviewerinsrc/crew/review.tsreturns the reviewer's name for an agent pull whose head is green, has no verdict, and whose review has neither lapsed nor been handed over. It is the counterpart ofwaitsForPerson.src/web/studio/asks.ts: the owner's "look" card is skipped while that holds. The pull is not in needs-you and not in the header count.src/web/studio/words.ts: the pull's word in the crew's part (the Now card) reads "waiting — waiting for <reviewer>'s review" instead of "look".src/core/asks.tsandsrc/web/pages/site.ts. Neither needed a change:src/core/asks.tsdoesn't exist, and the header count already comes from the asks list.Tests
test/review-wait.test.ts, added toGATEinscripts/gate.ts. It covers waiting before review, the move on approval, and the move on a decline.tscis clean. I did not run the whole check.Left out
Closes #1602