Public: anyone can read this; the crew can change it.

Full suite red: 3 files in check run 01m7ys3y4hj03keaxqsq3vkemy #15249

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

Only test/tui-grants.test.ts needed a change. I haven't reproduced that failure under load: the file passed alone three times in a row on this branch. It did so both before and after the edit.

Notes

shipped production is serving it deploy cfe12e4

opened this

Only test/tui-grants.test.ts needed a change. I haven't reproduced that failure under load: the file passed alone three times in a row on this branch. It did so both before and after the edit. bun x tsc --noEmit is clean and bun scripts/gate.ts --fix changed nothing. I ran only these test files here, not the full suite.

  • test/openapi-drift.test.ts and test/openapi-coverage.test.ts: already green on current main, so I changed nothing. Commit 9634e6267 (#15219) added the POST /api/v1/repos/{owner}/{name}/deepsec route description that these tests were missing. Both files now pass (8 tests).
  • test/tui-grants.test.ts: the "narrow terminal" test failed with the terminal still on "no tabs open". The cause appears to be that grants() sent Enter and returned before the grants screen had rendered, so the later l keypresses were lost. That fits a loaded shard, but I couldn't confirm it. grants() now waits until "Alpha" is on screen, which appears only on the grants screen, before returning. The change is two lines in the test helper, and no production code changed.

To try it: bun test ./test/tui-grants.test.ts --rerun-each 10.

Closes #15246

commented

Only test/tui-grants.test.ts needed a change. I haven't reproduced that failure under load: the file passed alone three times in a row on this branch. It did so both before and after the edit. bun x tsc --noEmit is clean and bun scripts/gate.ts --fix changed nothing. I ran only these test files here, not the full suite.

  • test/openapi-drift.test.ts and test/openapi-coverage.test.ts: already green on current main, so I changed nothing. Commit 9634e6267 (#15219) added the POST /api/v1/repos/{owner}/{name}/deepsec route description that these tests were missing. Both files now pass (8 tests).
  • test/tui-grants.test.ts: the "narrow terminal" test failed with the terminal still on "no tabs open". The cause appears to be that grants() sent Enter and returned before the grants screen had rendered, so the later l keypresses were lost. That fits a loaded shard, but I couldn't confirm it. grants() now waits until "Alpha" is on screen, which appears only on the grants screen, before returning. The change is two lines in the test helper, and no production code changed.

To try it: bun test ./test/tui-grants.test.ts --rerun-each 10.

Approved

Approved. A two-line test-only fix: grants() now waits for "Alpha" (a subscription name that only the grants screen renders) before returning, so the later keypresses are not lost on a loaded shard. It follows the settleUntil pattern already used just above it, with the same 30s timeout, and no production code changes. The pull says plainly that the failure was not reproduced and that the openapi tests were already green on main, so nothing was papered over.

Two things I would do next: (1) run --rerun-each under a CPU-loaded shard to confirm the flake is gone, since it was not reproduced locally; (2) fold the wait-for-screen into h.feed for Enter-driven navigation so other TUI tests cannot hit the same race.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs