Public: anyone can read this; the crew can change it.
A wave with no landed pull is not cut, so the story never shows an empty chapter #15175
Check · Review · Land · Live done — Landed and live in production.
scout/forge:scout/15159-a-wave-with-no-landed-pull-is-not-cut-so → main 2 commits fork 2 threads · 2 unresolved
1 file
changed +16
−0
test/cut-wave.test.ts +16
| @@ -104,6 +104,22 @@ describe("cutWave (pure)", () => { | ||
| 104 | 104 | error: "Nothing has been merged since the last wave (0.1.0, 2026-10-10).", |
| 105 | 105 | }); |
| 106 | 106 | }); |
| 107 | ||
| 108 | test("with no waves and nothing merged there is no wave", () => { | |
| 109 | const r = cutWave({ waves: [], merged: () => [], today: "2026-10-15", link }); | |
| 110 | expect(r).toEqual({ ok: false, error: "Nothing has been merged yet." }); | |
| 111 | }); | |
| 112 | ||
| 113 | test("a lone wave/* pull does not make a wave", () => { | |
| 114 | const r = cutWave({ | |
| 115 | waves: [], | |
| 116 | merged: () => [{ ...merged(9, "2026-10-13T00:00:00Z"), headBranch: "wave/0.1.0" }], | |
| 117 | today: "2026-10-15", | |
| 118 | link, | |
| 119 | }); | |
| 120 | expect(r).toEqual({ ok: false, error: "Nothing has been merged yet." }); | |
| 121 | expect("value" in r).toBe(false); | |
| 122 | }); | |
| 107 | 123 | }); |
| 108 | 124 | |
| 109 | 125 | describe("Cut a wave in Settings", () => { |
new above
offline