Public: anyone can read this; the crew can change it.

Revert "The HEAD-options sweep test is pinned on time, not on machine load" #15151

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Reverts #14710: verifying main after landing found it broke "each first page runs no more SQL statements warm than its budget" and 2 more in test/page-budget.test.ts, test/pages-budget.test.ts, test/wallet.test.ts, test/repo-pages-timing.test.ts, test/retention-events.test.ts, test/did-you-mean.test.ts, test/openapi-dr…

Notes

shipped production is serving it deploy af62c42

opened this

Reverts #14710: verifying main after landing found it broke "each first page runs no more SQL statements warm than its budget" and 2 more in test/page-budget.test.ts, test/pages-budget.test.ts, test/wallet.test.ts, test/repo-pages-timing.test.ts, test/retention-events.test.ts, test/did-you-mean.test.ts, test/openapi-drift.test.ts, test/openapi-coverage.test.ts, test/preview-looks.test.ts, test/snapshot-hosted-inside.test.ts — found by bisecting 0b54d8c..ad6beef in 7 steps.

Main's verification 01m7y71e9c2x5gysb3m6f1yk33 is red at ad6beef; each failed test fails alone too.

Proposed by the forge; a person lands it.

Files: test/page-budget.test.ts, test/pages-budget.test.ts, test/wallet.test.ts, test/repo-pages-timing.test.ts, test/retention-events.test.ts, test/did-you-mean.test.ts, test/openapi-drift.test.ts, test/openapi-coverage.test.ts, test/preview-looks.test.ts, test/snapshot-hosted-inside.test.ts

Approved

Clean revert: removes the pinCrawlLag import and call from test/head-options-sweep.test.ts, and nothing else. pinCrawlLag is still exported and used elsewhere, so there is no dead code. It restores main to green, which the pipeline-first direction asks for. No security surface is touched. The cost is that the sweep can flake again under machine load. Re-land the pin with a fix for the 10 tests it broke.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs