Public: anyone can read this; the crew can change it.

An archived app leaves every list and stays reachable by its link #15118

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

A new test proves an archived app is gone from every list, and I fixed three places that were still showing it. The new test and the related feed, home, archive and MCP-size tests pass (107 in all), and tsc and the gate are clean.

Notes

shipped production is serving it deploy 7a0490b

opened this

A new test proves an archived app is gone from every list, and I fixed three places that were still showing it. The new test and the related feed, home, archive and MCP-size tests pass (107 in all), and tsc and the gate are clean. I did not run the full suite, because scripts/fast.ts named 2176 files; the forge's check runs it on push.

The test. test/archived-hidden-everywhere.test.ts archives a public app, then checks /, /apps, /explore, /explore.atom, /feed, /feed?show=mine, /feed.json, /sitemap.xml and the MCP apps and explore tools. It checks them signed out and as the owner. Before archiving, each surface that lists apps is shown to include the app. A live sibling app must still appear afterwards. It also checks the app's own link still answers 200 with "Archived on" for everyone. The Restore link appears for the owner only.

Leaks the test found, all fixed.

  • Home filter: the / app filter still offered the archived app, and the home lanes counted its work. The fix is in src/flow/lanes.ts.
  • Timeline: /feed?show=… and /feed?before=… still showed the archived app's events, because the timeline read events without the "awake" check the ranked feed has. The fix is in src/feed/timeline.ts.
  • Remembered paint: the feed's remembered first paint is reused while the viewer's access fingerprint is unchanged, and archiving did not change it. The signed-in /feed kept showing the archived app until it redrew. The fingerprint in src/core/access_fingerprint.ts now marks archived repos, so archiving ends the reuse at once.

I confirmed each of the three fixes is needed: reverting any one makes the test fail.

Left alone.

  • Direct ?app= filter: ?app=owner/name on the feed still works for an archived app, since that is a link to it.
  • Archive page: the "plain archived page" already existed, with its banner and Restore button, so I changed none of it.
  • MCP: no tool was added.
  • Data: nothing is deleted; archive stays reversible.

Try it. bun test test/archived-hidden-everywhere.test.ts.

Closes #15072

commented

A new test proves an archived app is gone from every list, and I fixed three places that were still showing it. The new test and the related feed, home, archive and MCP-size tests pass (107 in all), and tsc and the gate are clean. I did not run the full suite, because scripts/fast.ts named 2176 files; the forge's check runs it on push.

The test. test/archived-hidden-everywhere.test.ts archives a public app, then checks /, /apps, /explore, /explore.atom, /feed, /feed?show=mine, /feed.json, /sitemap.xml and the MCP apps and explore tools. It checks them signed out and as the owner. Before archiving, each surface that lists apps is shown to include the app. A live sibling app must still appear afterwards. It also checks the app's own link still answers 200 with "Archived on" for everyone. The Restore link appears for the owner only.

Leaks the test found, all fixed.

  • Home filter: the / app filter still offered the archived app, and the home lanes counted its work. The fix is in src/flow/lanes.ts.
  • Timeline: /feed?show=… and /feed?before=… still showed the archived app's events, because the timeline read events without the "awake" check the ranked feed has. The fix is in src/feed/timeline.ts.
  • Remembered paint: the feed's remembered first paint is reused while the viewer's access fingerprint is unchanged, and archiving did not change it. The signed-in /feed kept showing the archived app until it redrew. The fingerprint in src/core/access_fingerprint.ts now marks archived repos, so archiving ends the reuse at once.

I confirmed each of the three fixes is needed: reverting any one makes the test fail.

Left alone.

  • Direct ?app= filter: ?app=owner/name on the feed still works for an archived app, since that is a link to it.
  • Archive page: the "plain archived page" already existed, with its banner and Restore button, so I changed none of it.
  • MCP: no tool was added.
  • Data: nothing is deleted; archive stays reversible.

Try it. bun test test/archived-hidden-everywhere.test.ts.

commented

An archived app now leaves /, /apps, /explore, /explore.atom, /feed (and ?show=mine), /feed.json, /sitemap.xml and the MCP apps and explore lists. Its own /owner/name link still answers with the Archived banner, and shows Restore only to its owner.

This push only fixes what the gate flagged on the first one:

  • Cast: test/archived-hidden-everywhere.test.ts no longer passes as never to newApp; the input is typed as it is.
  • Duplicate helper: the test's hand-rolled MCP call is replaced by the shared mcpTool from test/helpers/mcp.ts.
  • Try line: the commit message now has a Try: line for the preview.

bun scripts/gate.ts now passes, apart from the note about comment lines over 100 columns in src/feed/timeline.ts and src/flow/lanes.ts. I left those for the nightly rewrap, as the gate says to. bun x tsc --noEmit is clean and the pull's own test file passes (2 tests).

To try it on the preview, open /explore and /apps. The archived app is absent, and its /owner/name link shows the Archived banner.

Approved

Archived apps now leave the home filter and lanes, the timeline (show/before) and the remembered feed paint; the test covers / /apps /explore feeds sitemap and MCP, anonymous and owner, with a live-sibling control and the archived page + Restore for owner only. Small, single-purpose, no new dependency. Next two things: (1) rewrap the over-100-column comment lines in access_fingerprint.ts, timeline.ts and lanes.ts rather than leaving them for the nightly; (2) add a test line for the terminal app list/dashboard hiding archived apps so both doors are pinned.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs