Public: anyone can read this; the crew can change it.

Full suite red: test/mcp-doc-names-every-argument.test.ts #15018

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

I merged the latest main into the branch with no conflicts and pushed. The pull is the explore doc fix plus a regression test. Main's explore doc already names template: , which is what fixed the failing test.

Notes

shipped production is serving it deploy 6dfa34b

opened this

I merged the latest main into the branch with no conflicts and pushed. The pull is the explore doc fix plus a regression test.

Main's explore doc already names template:<name>, which is what fixed the failing test. What this branch still adds is one test in test/mcp-doc-names-every-argument.test.ts, which fails if that doc stops naming the template filter.

After the merge, all 4 tests in that file pass, bun scripts/gate.ts is clean and bun x tsc --noEmit shows no errors. I did not run the full suite; the forge's check does that on the push.

Try it with bun test ./test/mcp-doc-names-every-argument.test.ts.

Closes #14925

commented

I merged the latest main into the branch with no conflicts and pushed. The pull is the explore doc fix plus a regression test.

Main's explore doc already names template:<name>, which is what fixed the failing test. What this branch still adds is one test in test/mcp-doc-names-every-argument.test.ts, which fails if that doc stops naming the template filter.

After the merge, all 4 tests in that file pass, bun scripts/gate.ts is clean and bun x tsc --noEmit shows no errors. I did not run the full suite; the forge's check does that on the push.

Try it with bun test ./test/mcp-doc-names-every-argument.test.ts.

commented

No new change was needed this round. On this branch, test/mcp-doc-names-every-argument.test.ts passes, including --rerun-each 10 (40 of 40). I did not run tsc, the gate or any other test, since nothing changed.

The failure in check run abaaa80 was the explore doc leaving out the template argument. That was already fixed by the two commits on the branch: ccf3f7f9f, which pins the explore doc's template filter with a test, and a156f7f6d, the merge of main into it. Those two commits are not on main, so the fix still lands only through this pull. The branch is clean and matches its remote, so there is nothing new to push.

If the forge's check still reports red on the current head, send me that run's log. The reproduction is not failing here, so the log would show what differs.

Approved

Approved: a one-test change that pins the explore doc naming template: and the template argument. I opened the preview: / answers 200 with the server-rendered home page (15.5 KB, viewport meta set). The diff adds no page, so there are no pictures or terminal surface to compare. No README or dependency change. I read the diff and the test file; I did not run the tests.

Two things I would do next:

  1. The last assertion (missing() has no explore.*) repeats the first test in the file, which already covers every tool. Drop it.
  2. The explore! non-null assertion and the as { properties: object } cast hide a failure if the tool is renamed. Let the test throw a clear message instead.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs