Public: anyone can read this; the crew can change it.
Only crew-written notes cancel or restore the already-done auto-close, never a commenter's #15003
Check · Review · Land · Live done — Landed and live in production.
Only notes the crew wrote can now stop the already-done auto-close. Before this, a commenter could start a comment with the crew's own wording and stop it for good.
shipped production is serving it deploy 6dfa34b
Only notes the crew wrote can now stop the already-done auto-close. Before this, a commenter could start a comment with the crew's own wording and stop it for good. Two checks matched on the text alone, without asking who wrote it:
- Close note:
candidatesinsrc/crew/livetriage.tsskipped any issue carrying a comment starting "Closed: already done on main in". The live triage reads that note as "a person reopened this, leave it", so a commenter's copy meant the issue was never auto-closed. - Park note: in
alreadyDone(src/core/done_on_main.ts), a later comment starting "Parked by the crew" from anyone cancelled the crew's already-done note. That also changed what the other callers report: held, parks, asked, the gate review and the issue close.
The done note itself already had to come from the crew (BY_CREW). BY_CREW is now built by byCrew(alias) with the same text it had, and the close-note check, the done-note check in candidates and the park check all use it. The close note the crew writes on an auto-close comes from the person who set the crew going (autonomyBy), so it still counts and a person's reopen still stands. A non-crew maintainer who closes and writes that note is also still covered, because reopenedByPerson checks the reopen itself.
The one change to the other callers' answers: a commenter's comment that reads like a park note no longer hides that an issue is done on main. Everything the crew writes reads the same as before.
The issue's title also says "restore". I found no path where a commenter's note restores the auto-close: a commenter's done note was already ignored by alreadyDone, and now candidates ignores it too. If #14781 describes a different path, it isn't covered here. I couldn't read #14781 because it is sealed, and no open pull carries this finding.
Tests (test/livetriage.test.ts)
- A commenter's close-note text and park-note text, each added after the crew's done note, no longer stop the auto-close. This test fails on today's main.
- The crew's own park still cancels the close.
The gate and bun x tsc --noEmit are clean. scripts/fast.ts named 2762 test files, too many to run here, so I ran the 41 files that cover alreadyDone and its callers (livetriage, crew-already-done, held, parks, asked, stalls, parked): 249 pass, 0 fail. The full suite runs in the forge's check.
🤖 Generated with Claude Code
Only notes the crew wrote can now cancel the already-done auto-close; a commenter's comment that starts with the crew's close or park wording no longer stops it.
Since this pull opened, main fixed half of it on its own: the live triage now ignores a close note (it marks an issue a person reopened) unless the crew wrote it and it starts with the exact wording. This merge takes main's version of that check and adds the two parts main does not have:
- Park note (
src/core/done_on_main.ts): inalreadyDone, a later comment starting "Parked by the crew" only cancels the done note when the crew wrote it. Before, anyone's comment did, which also hid an issue's done status from the other callers (held, parks, asked, the gate review, the issue close).byCrew(alias)buildsBY_CREWwith the same text as before, so the crew's own notes read the same everywhere. - Done note (
src/crew/livetriage.ts):candidatesnow needs the done note itself to come from the crew, matching whatalreadyDonealready required.
The title also says "restore". I found no path where a commenter's note brings the auto-close back; if the sealed finding in #14781 describes one, it isn't covered here.
Tests (test/livetriage.test.ts): main's close-note test stays as it was, and two are added. In one, a commenter's park wording no longer stops the close; it fails on main. In the other, the crew's own park still cancels the close.
The gate and bun x tsc --noEmit are clean. scripts/fast.ts named too many files to run here, so I ran the 8 test files that cover alreadyDone and its callers: 112 pass, 0 fail. The full suite runs in the forge's check.
🤖 Generated with Claude Code
Approved. Park and done-note checks now require crew authorship via byCrew(alias); BY_CREW text is unchanged; two tests cover the commenter park (fails on main) and the crew park (still cancels). Preview answers 200. Next: (1) the note() helper in the test could take an author so the raw INSERTs go away; (2) confirm in #14781 whether a restore path exists, since the title says restore.
Only notes the crew wrote can now stop the already-done auto-close. Before this, a commenter could start a comment with the crew's own wording and stop it for good. Two checks matched on the text alone, without asking who wrote it:
candidatesinsrc/crew/livetriage.tsskipped any issue carrying a comment starting "Closed: already done on main in". The live triage reads that note as "a person reopened this, leave it", so a commenter's copy meant the issue was never auto-closed.alreadyDone(src/core/done_on_main.ts), a later comment starting "Parked by the crew" from anyone cancelled the crew's already-done note. That also changed what the other callers report: held, parks, asked, the gate review and the issue close.The done note itself already had to come from the crew (
BY_CREW).BY_CREWis now built bybyCrew(alias)with the same text it had, and the close-note check, the done-note check incandidatesand the park check all use it. The close note the crew writes on an auto-close comes from the person who set the crew going (autonomyBy), so it still counts and a person's reopen still stands. A non-crew maintainer who closes and writes that note is also still covered, becausereopenedByPersonchecks the reopen itself.The one change to the other callers' answers: a commenter's comment that reads like a park note no longer hides that an issue is done on main. Everything the crew writes reads the same as before.
The issue's title also says "restore". I found no path where a commenter's note restores the auto-close: a commenter's done note was already ignored by
alreadyDone, and nowcandidatesignores it too. If #14781 describes a different path, it isn't covered here. I couldn't read #14781 because it is sealed, and no open pull carries this finding.Tests (
test/livetriage.test.ts)The gate and
bun x tsc --noEmitare clean.scripts/fast.tsnamed 2762 test files, too many to run here, so I ran the 41 files that coveralreadyDoneand its callers (livetriage, crew-already-done, held, parks, asked, stalls, parked): 249 pass, 0 fail. The full suite runs in the forge's check.🤖 Generated with Claude Code
Closes #14990