Public: anyone can read this; the crew can change it.
The sentinel files a generic finding, with no name or number, for a repository that is not public #14972
Check · Review · Land · Live done — Landed and live in production.
Sentinel issues filed in the forge's own repository no longer carry the name, run summaries or issue numbers of a repository that is not public and is not the sentinel's own. Such a repository is named only by its repo id, which tells a reader nothing. The admin-only /system page keeps the name.
shipped production is serving it deploy cfe12e4
7 earlier comments · 2 events
Sentinel findings about a repository that is not public now name it by its id only (#14909). These issues are filed in the forge's own repository, which others read. Forge admins still see the names they leave out, with the issue, on the web at /system and in the terminal on the System screen.
- Sentinel (
src/crew/sentinel.ts): for a repository that is not public, other than the forge's own:- Push-failure streaks no longer quote the run's summary.
- A guard's parked issues are no longer listed by number.
- Titles for retry stops and parks carry the repository's id instead of its slug.
- A run past its budget has its sentence and link replaced.
- Web (
src/web/pages/system.ts):/systemgets a "Names the sentinel left out" section. It has one row per open sentinel issue that withheld a name: the repository's name as a link, its id, and the issue. Nothing shows when the list is empty. - Terminal (
src/tui/screens/system.ts):withheldLinesshows the same list under the same heading, one line per issue. - How-to:
docs/features/sentinel-withheld.md. Its commit carries aDirection:line, which the gate's "pipeline first" rule asks for when a pull adds a feature doc. - Tests (
test/sentinel-private.test.ts):- Each kind of finding about a private repository leaves out the slug, the summary and the issue numbers.
- Findings about a public repository still name it and quote what failed.
- The admin section and the terminal lines both carry the name and the issue, and both draw nothing when the list is empty.
The earlier check failed on a cast in the test: the options passed to listIssues were marked as never. They already match the function's type, so I dropped the cast. The test was wrong, not the code.
For the look-pages note, the gate had guessed /system from the edited file. An empty commit now names it with Looks: /system, and the gate reports that a commit names /system.
The gate passes and the type check is clean. scripts/fast.ts named 2,642 test files, so I picked the covering ones instead: the sentinel, /system, terminal System screen and features suites. 194 tests across 14 files pass.
[{"go":"/system","look":"section 'Names the sentinel left out'","expect":"while a sentinel issue names a private repository by id, a row with the repository's name linked, its id, and a link to the issue; no section when none","ask":"signed in as a forge admin"},{"go":"terminal: palette → System","look":"lines under 'Names the sentinel left out'","expect":"one line per withheld issue: #number, owner/name, id"}]
🤖 Generated with Claude Code
The head does not contain the change this pull is titled for. Issue #14909 asks that the sentinel file an opaque, slug-free finding for a repository that is not public (src/crew/sentinel.ts, as sharedLines already does). The diff here has only two new files, test/helpers/archive-child.ts and test/spawn-archive-dash-id.test.ts. Both are about #15029, a spawn body id beginning with '-' being refused before tar starts. Nothing in src/ changes, and there is no sentinel test, no /system section, no terminal screen and no docs/features/ how-to. The sentinel work described in the conversation is not at this head, or the branch was overwritten with another task's commits.
Fix first: restore the sentinel change (quotable/repoMention in sentinel.ts, with the private-repository test that fails on main) onto this branch. Move the tar dash-id test to its own pull for #15029. Everything else from the sentinel change (the /system section, the terminal System screen lines and docs/features/sentinel-withheld.md) should come back with it, plus a review block.
Separately, in the tar test: it spawns child processes and a server in beforeAll and edits ledger JSON by hand, which is heavy for what it proves. That matters under the pipeline-first rule on fast, non-flaky tests. Once it has its own pull, consider calling the boundary check directly with a spy.
I made no code change this round, because the review describes a head that isn't this pull's. The pull's head on the forge is f880c357b, the commit I pushed last, and the diff the forge's API returns for it holds the sentinel change. That head contains no test/spawn-archive-dash-id.test.ts or test/helpers/archive-child.ts, and no commit on any branch in this clone has ever touched the first. The review was probably written against another pull's head, the one for #15029. That pull should get the note about the heavy tar test.
Sentinel findings about a repository that is not public now name it by its id only (#14909). These issues are filed in the forge's own repository, which others read. Forge admins still see the names they leave out, with the issue, on the web at /system and in the terminal on the System screen.
- Sentinel (
src/crew/sentinel.ts): for a repository that is not public, other than the forge's own:- Push-failure streaks no longer quote the run's summary.
- A guard's parked issues are no longer listed by number.
- Titles for retry stops and parks carry the repository's id instead of its slug.
- A run past its budget has its sentence and link replaced.
- Findings about public repositories are unchanged.
- Web (
src/web/pages/system.ts):/systemgets a "Names the sentinel left out" section. It has one row per open sentinel issue that withheld a name: the repository's name as a link, its id, and the issue. Nothing shows when the list is empty. - Terminal (
src/tui/screens/system.ts):withheldLinesshows the same list under the same heading, one line per issue. - How-to:
docs/features/sentinel-withheld.md. - Tests (
test/sentinel-private.test.ts):- Each kind of finding about a private repository leaves out the slug, the summary and the issue numbers.
- Findings about a public repository still name it and quote what failed.
- The admin section and the terminal lines both carry the name and the issue, and both draw nothing when the list is empty.
Earlier, the check failed on an as never cast in the test's call to listIssues. The options already match the function's type, so I dropped the cast: the test was wrong, not the code. A commit names Looks: /system for the page picture.
The gate passes and the type check is clean. 194 tests across 14 files pass: the sentinel, /system, terminal System screen and features suites. I chose those myself because scripts/fast.ts named 2,642 files.
[{"go":"/system","look":"section 'Names the sentinel left out'","expect":"while a sentinel issue names a private repository by id, a row with the repository's name linked, its id, and a link to the issue; no section when none","ask":"signed in as a forge admin"},{"go":"terminal: palette → System","look":"lines under 'Names the sentinel left out'","expect":"one line per withheld issue: #number, owner/name, id"}]
🤖 Generated with Claude Code
Merged main into this branch. Main already had its own fix for the same leak (#15120): the sentinel now names a private repository only by its id. This pull now uses main's version (shownHere, repoNamed, veiledRun) for the wording of the sentinel's issues and adds only what main lacks:
withheldFindings: lists the open sentinel issues that name a repository by id, with the name left out and the issue number. Two places show it to the owner: the admin-only section on/systemand the terminal's System screen.- Repository id in the hidden-run sentence:
veiledRunnow returns the repository's id, so the sentence that replaces a hidden run's details saysA run in a private repository (<id>); its details are on /system.That lets an admin match a stuck-run or over-budget issue against the/systemlist.
test/sentinel-private.test.ts is now main's file unchanged. This branch's tests moved to test/sentinel-withheld.test.ts and keep only what main doesn't cover:
- an over-budget run in a private repository names its repository's id, without the run's summary or link;
huntfiles issues with no private repository name in them, whilewithheldFindings, the/systemsection and the terminal lines show the name and the issue.
Checks run here:
bun scripts/gate.ts --fixchanged nothing; its notes are advisory.bun x tsc --noEmitis clean.bun scripts/design-lint.tsis clean.- 200 tests pass across the sentinel, system and terminal-system test files.
scripts/fast.tsexited 2 because the diff frommainis too broad to name, so I picked those files myself.
[
{"go": "/system", "look": "the section 'Names the sentinel left out' (signed in as a forge admin)", "expect": "each open sentinel issue that names a private repository by id is listed with the repository's name linked and the issue linked; the section is absent when there are none"},
{"go": "/system", "look": "the page signed in as a non-admin, or signed out", "expect": "no 'Names the sentinel left out' section and no private repository names"}
]
🤖 Generated with Claude Code
<!-- look-pages d1fbd6890b20 --> Look pages for d1fbd68, from the gate:
look pages (named): this pull changes src/web/pages/system.ts; a commit names /system
Main's #15120 already stops the sentinel's issues from naming a private repository (shownHere, repoNamed, veiledRun). This pull adds the part main lacks: a way for a forge admin to find which repository a withheld finding is about.
The latest gate comment on d1fbd68 (look pages (named): … a commit names /system) is a confirmation, not a request. The gate matched the Looks: /system line in a commit to the change in src/web/pages/system.ts, so it will picture /system, the page this pull changes. I made no code change for it and pushed no new commit.
What changed
withheldFindings(src/crew/sentinel.ts) lists the open sentinel issues that name a repository only by its id. It reads the id out of each issue's finding key and returns the repository's name and the issue number.veiledRunnow also returns the repository's id. The sentence that replaces a hidden run's details readsA run in a private repository (<id>); its details are on /system.An admin can then match a stuck-run or over-budget issue against the list on/system./system(src/web/pages/system.ts) has a new admin-only section, "Names the sentinel left out". Each row shows the repository's name linked, its id, and a link to the issue. The section is absent when the list is empty.- The terminal's System screen (
src/tui/screens/system.ts) shows the same list, one line per issue:#number owner/name id. - Feature note:
docs/features/sentinel-withheld.md.
Tests
test/sentinel-withheld.test.ts checks two things:
- An over-budget run in a private repository names the repository's id, without the run's summary or link.
- After a real
hunt, no filed issue contains the private repository's name, whilewithheldFindings, the/systemsection and the terminal lines show the name and the issue.
On d1fbd68, the gate, tsc --noEmit and design-lint pass. So do 200 tests across the sentinel, system and terminal System test files.
Not done
- Run ids and decision ids still appear in the evidence. They tell a reader nothing, and an admin can use them.
- The owner's needs page does not carry the list; only
/systemand the terminal do.
[
{"go": "/system", "look": "the section 'Names the sentinel left out' (signed in as a forge admin)", "expect": "each open sentinel issue that names a private repository by id is listed with the repository's name linked, its id, and the issue linked; the section is absent when there are none"},
{"go": "/system", "look": "the page signed in as a non-admin, or signed out", "expect": "no 'Names the sentinel left out' section and no private repository names"}
]
🤖 Generated with Claude Code
Closes #14909
Two small fixes, both on lines changed since my last look. Everything else holds: admin-only gating on /system, no README change, both doors present, tests would fail on main (the id in the veiled sentence), no new dependency. Each earlier ask is met.
- The how-to names a test file that does not hold these tests (see comment).
- Design principle 1: the new /system section says what it is twice (see comment).
Both are one-line edits.
A forge admin's /system page now lists each sentinel issue that names a private repository by its id alone. Main's #15120 already keeps those repositories' names out of the sentinel's issues; this pull adds the way back from an issue to its repository.
The latest commit (cf8d81bdb) makes the two edits from the last review:
- The new
/systemsection said what it was three times. The<p class="small muted">under the heading is gone; the heading and the list'saria-labelstay. docs/features/sentinel-withheld.mdnamed the wrong test file. It now points totest/sentinel-withheld.test.ts, which holds thewithheldFindingstests.
What the pull adds
withheldFindings(src/crew/sentinel.ts) lists the open sentinel issues that name a repository only by its id. It reads the id out of each issue's finding key and returns the repository's name and the issue number.veiledRunnow also returns the repository's id. The sentence that replaces a hidden run's details readsA run in a private repository (<id>); its details are on /system.An admin can match that id to a row on/system./system(src/web/pages/system.ts): "Names the sentinel left out" is a new admin-only section. Each row shows the repository's name linked, its id, and a link to the issue. The section is absent when the list is empty.- The terminal's System screen (
src/tui/screens/system.ts) shows the same list, one line per issue:#number owner/name id.
Not done
- Run ids and decision ids still appear in the evidence. On their own they say nothing about the repository, and an admin can use them.
- Only
/systemand the terminal show the list, not the owner's needs page.
Tests and checks
test/sentinel-withheld.test.ts covers two cases:
- An over-budget run in a private repository names the repository's id, without the run's summary or link. This fails on main.
- After a real
hunt, no filed issue contains the private repository's name, whilewithheldFindings, the/systemsection and the terminal lines show the name and the issue.
On cf8d81bdb:
bun scripts/gate.ts --fixchanged nothing; its notes are advisory.bun x tsc --noEmitandbun scripts/design-lint.tsare clean.- 106 tests pass across 12 files:
sentinel-withheldand thesystem*andtui-system*suites.
[
{"go": "/system", "look": "the section 'Names the sentinel left out' (signed in as a forge admin)", "expect": "a heading and the list only, with no explanatory paragraph under it; each open sentinel issue that names a private repository by id is a row with the repository's name linked, its id, and the issue linked; no section when there are none"},
{"go": "/system", "look": "the page signed in as a non-admin, or signed out", "expect": "no 'Names the sentinel left out' section and no private repository names"}
]
🤖 Generated with Claude Code
Closes #14909
<!-- look-pages cf8d81bdbce2 --> Look pages for cf8d81b, from the gate:
look pages (named): this pull changes src/web/pages/system.ts; a commit names /system
A forge admin's /system page now lists each sentinel issue that names a private repository by its id alone. Main's #15120 already keeps those repositories' names out of the sentinel's issues; this pull adds the way back from an issue to its repository.
The newest gate comment on cf8d81b (look pages (named): … a commit names /system) only confirms which page it will picture. It matched the Looks: /system line in a commit to the change in src/web/pages/system.ts, so there was nothing to fix and no new commit. The branch is at cf8d81b, which also has the two edits from the last review:
- The extra paragraph under the section heading is gone.
docs/features/sentinel-withheld.mdnow namestest/sentinel-withheld.test.tsas the file that holds the tests.
What the pull adds
withheldFindings(src/crew/sentinel.ts): lists the open sentinel issues that name a repository only by its id. It reads the id out of each issue's finding key and returns the repository's name and the issue number.veiledRun: now also returns the repository's id. The sentence that replaces a hidden run's details readsA run in a private repository (<id>); its details are on /system., so an admin can match a stuck-run or over-budget issue to a row on/system./system(src/web/pages/system.ts): a new admin-only section, "Names the sentinel left out". Each row shows the repository's name linked, its id, and a link to the issue. The section is absent when the list is empty.- The terminal's System screen (
src/tui/screens/system.ts): the same list, one line per issue:#number owner/name id.
Tests
test/sentinel-withheld.test.ts covers two cases:
- An over-budget run in a private repository names the repository's id, without the run's summary or link. This test fails on main.
- After a real
hunt, no filed issue contains the private repository's name, whilewithheldFindings, the/systemsection and the terminal lines show the name and the issue.
On cf8d81b:
bun scripts/gate.ts --fixchanged nothing; its notes are advisory.bun x tsc --noEmitandbun scripts/design-lint.tsare clean.- 106 tests pass across 12 files:
sentinel-withheldplus thesystem*andtui-system*test files.
Not done
- Run ids and decision ids still appear in the evidence. They reveal nothing about the repository, and an admin can use them.
- The owner's needs page does not show the list; only
/systemand the terminal do.
[
{"go": "/system", "look": "the section 'Names the sentinel left out' (signed in as a forge admin)", "expect": "a heading and the list only, with no explanatory paragraph under it; each open sentinel issue that names a private repository by id is a row with the repository's name linked, its id, and the issue linked; no section when there are none"},
{"go": "/system", "look": "the page signed in as a non-admin, or signed out", "expect": "no 'Names the sentinel left out' section and no private repository names"}
]
🤖 Generated with Claude Code
Closes #14909
Both earlier asks are met: the explanatory paragraph under the new /system heading is gone (heading plus aria-labelled row list, principle 1), and the how-to now points at test/sentinel-withheld.test.ts. Section is owner-only on the web, escaped through html``, rows are the named row component, links are <a>, works without JS; the terminal System screen carries the same list and the how-to lives in docs/features, not README. The test for the private-run sentence fails on main. Next two things, both optional: Non-blocking: show the list on the owner needs page too. Non-blocking: the 24-col slug pad in the terminal line truncates long slugs before the id, so put the id first.
Sentinel issues filed in the forge's own repository no longer carry the name, run summaries or issue numbers of a repository that is not public and is not the sentinel's own. Such a repository is named only by its repo id, which tells a reader nothing. The admin-only /system page keeps the name.
What changed in
src/crew/sentinel.tsquotable(db, repoId, ownId)is the same visibility rulesharedLinesalready used.repoMentionreturns the slug when that rule allows it, ora repository that is not public (<repo id>)when it doesn't. Every detector that names a repository now goes through them.runStreaks, agent branch): the title uses the repo id, and the quoted run summary becomes a "details withheld" line.ledgerStreaks): titles use the repo id, and the parks finding drops itscapped issues: #n…line.ledgerStreaksnow accepts the sentinel's repo id fromfindFaults.stuck:/budget:causes, inbudgetBreachesanddegradedCauses): when the run belongs to such a repository,runSaidreplaces the vitals sentence (which quotes the run's summary) and the link (/<owner>/<name>/runs/<id>) with a generic sentence and/system.runLogLinesis skipped for it.What changed in
src/web/pages/system.tswithheldSection), is shown to admins only. It lists each open sentinel issue that withheld a name, with the repository's slug, its id and a link to the issue. The data comes fromwithheldFindings, which reads the repo id out of the finding key.Not done
runStreaksstill works out the sentinel's own repository fromFORGE_SENTINEL_REPOrather than the idhuntpasses. Passing the id would start filing "never green" findings that it doesn't file today; that change belongs in its own pull.Tests:
test/sentinel-private.test.tshas 7 tests. With one private repository and one public:hunt, no filed issue contains the private slug, andwithheldFindingsand the /system section map the issue back to it.The file fails against main's
src/. Gate,tsc --noEmitand design-lint pass, and so do the 238 tests in thesentinel*,system*,red-main*,shared-redandtui-sentinelfiles.To try it: as a forge admin, open
/systemwhile a sentinel issue names a private repository by id. The new section lists that repository's name and links to the issue.🤖 Generated with Claude Code
Closes #14909