Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:14pujihlkn is past its budget: trevato/forge: "/llms.txt stays under its byte budget for each role" failed on 8 pulls in the last hour — the lane's re… #14894

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

I raised the /llms.txt byte budget in test/llms-budget.test.ts, so the budget test no longer fails. The failure was the manifest outgrowing its ceiling, not the check machine's load. The signed-in text was 80,797 bytes here, over the 80,500 ceiling.

Notes

shipped production is serving it deploy 5f527c6

opened this

I raised the /llms.txt byte budget in test/llms-budget.test.ts, so the budget test no longer fails. The failure was the manifest outgrowing its ceiling, not the check machine's load. The signed-in text was 80,797 bytes here, over the 80,500 ceiling. The size doesn't depend on load, disk or clock, because the test measures it on a fixed origin.

  • What I changed: the signed-in ceiling goes from 80,500 to 81,000 and the admin ceiling from 92,000 to 92,500. The anonymous ceiling stays at 9,100. The comment above the budget records the reason.
  • What I left out: I didn't trim the manifest to fit the old ceiling, and I didn't look at what grew it. I did not measure the admin size, so its raise is a matching +500 rather than a measured value.
  • Verified: test/llms-budget.test.ts passes (3 of 3), bun scripts/gate.ts --fix rewrapped the comments, and bun x tsc --noEmit is clean.
  • To try it: run bun test test/llms-budget.test.ts.

Closes #14889

3 earlier comments · 1 event
commented

I raised the /llms.txt byte budget in test/llms-budget.test.ts, so the budget test no longer fails. The failure was the manifest outgrowing its ceiling, not the check machine's load. The signed-in text was 80,797 bytes here, over the 80,500 ceiling. The size doesn't depend on load, disk or clock, because the test measures it on a fixed origin.

  • What I changed: the signed-in ceiling goes from 80,500 to 81,000 and the admin ceiling from 92,000 to 92,500. The anonymous ceiling stays at 9,100. The comment above the budget records the reason.
  • What I left out: I didn't trim the manifest to fit the old ceiling, and I didn't look at what grew it. I did not measure the admin size, so its raise is a matching +500 rather than a measured value.
  • Verified: test/llms-budget.test.ts passes (3 of 3), bun scripts/gate.ts --fix rewrapped the comments, and bun x tsc --noEmit is clean.
  • To try it: run bun test test/llms-budget.test.ts.
Changes requested — before the latest push

Two fixes, both in test/llms-budget.test.ts.

  1. The new comment lines are indented one space too far (" * Raised..."), which breaks the JSDoc block alignment. Align them with the rest of the block with a single leading space before the asterisk.
  2. The admin ceiling was raised by a guessed +500, not a measured value. The header comment says each ceiling is the measured size plus about a percent, and this one is not. Measure the admin size on the loopback origin, then record it in the comment and set the ceiling to about 1% above it. Record the signed-in 80,797 the same way. Admin cannot be less than signed-in, so check that 92,500 is not slack that lets the manifest grow unnoticed.

Not a change request: the pull does not say what grew the catalogue by about 670 bytes. Name the commits in the comment, as #14429 did, so the next raise has a trail. The pipeline-first direction is untouched; this is a one-file budget bump.

commented

Both requested fixes are in test/llms-budget.test.ts and pushed to the same branch. The budget test passes (3 of 3).

  • Alignment: the comment lines now have a single leading space before the asterisk.
  • Measured sizes: on the loopback origin, anonymous is 9,033, signed-in 80,797 and admin 92,230. Both are recorded in the comment.
  • Ceilings: signed-in is now 81,600 and admin 93,100, each about 1% above its measured size. Anonymous stays at 9,100.
  • Slack: the admin ceiling is raised from 92,500 to 93,100. Admin was measured at 92,230, so 92,500 left only 270 bytes of room, and about 1% above measured is 93,100.
  • Trail: I could only name one commit, f9568b70a (#14439), the roster change that generates the route table. It is the only commit touching the manifest and route code since the last budget raise at #14430. I didn't find which commits added the extra ~670 bytes, so the comment says "last touched by" rather than "caused by".
  • Hold: the "production is rolling" hold didn't affect this change. It is a test-only edit and doesn't touch production.
commented

Main is ahead of this branch by 18 commits. I tried the test on this branch merged with the newest main, without committing the merge, and it passes (3 of 3). The triage note only files the issue under P0 Trust and asks for no change. I pushed nothing new, and the pull description is the one below.

test/llms-budget.test.ts failed because the role-aware /llms.txt outgrew its signed-in ceiling. The route catalogue had grown, so the size depends on the code, not on the machine's load, disk or clock. Measured on the loopback origin, anonymous is 9,033 bytes, signed-in 80,797 and admin 92,230.

  • Ceilings: signed-in goes from 80,500 to 81,600 and admin from 92,000 to 93,100, each about 1% above its measured size as the budget comment requires. Anonymous stays at 9,100.
  • Comment: it records these measured sizes. It names f9568b70a (#14439), the only commit in the manifest and route code since the last raise. I didn't find which commits added the roughly 670 bytes, so it says "last touched by", not "caused by".
  • Review fixes: the JSDoc alignment is fixed, and the guessed +500 for admin is replaced by a measured size.

I didn't trim the manifest to fit the old ceilings.

To try it, run bun test test/llms-budget.test.ts. It passes on this branch and with today's main merged in; bun scripts/gate.ts --fix and bun x tsc --noEmit are clean.

The desk hold "Releasing trevato/forge: production is rolling" doesn't affect this test-only change.

🤖 Generated with Claude Code

commented

test/llms-budget.test.ts failed because the role-aware /llms.txt grew past its byte ceilings as routes were added. The size depends on the code, not on the check machine's load, disk or clock.

While this pull was open, main raised the ceilings to 81,000 (signed-in) and 92,600 (admin). It recorded 80,570 and 92,108 bytes and named #14570 and #14531 (feed count, app filter). I measured this branch with today's main merged in, on the loopback origin: anonymous 9,033, signed-in 80,797, admin 92,230. That leaves main's ceilings about 0.25% and 0.4% of headroom. The budget comment asks for about a percent above the measured size.

  • Ceilings: signed-in 81,600 and admin 93,100, each about 1% above the measured size. Anonymous stays at 9,100.
  • Comment: the merge keeps main's trail (#14570, #14531) and adds this raise with the measured sizes.
  • Review fixes: the JSDoc alignment is fixed, and the guessed +500 for admin is replaced by a measured size.

I didn't trim the manifest to fit the old ceilings, and I didn't find which change added the 227 signed-in bytes since main's measurement.

To try it, run bun test test/llms-budget.test.ts: 3 of 3 pass on the merged branch. bun scripts/gate.ts --fix and bun x tsc --noEmit are clean.

The desk hold "Releasing trevato/forge: production is rolling" doesn't affect this test-only change.

🤖 Generated with Claude Code

Approved

Test-only, one file. Ceilings are the measured sizes (signed-in 80,797, admin 92,230) plus about 1%, with the reason recorded in the comment. The earlier alignment and guessed-admin findings are fixed. No code, input, auth or output path changes, so there is no security surface. Not covered: no commit is named for the ~227 bytes of growth; I did not trace it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs