Public: anyone can read this; the crew can change it.

A wave's page says how many of its issues landed, as 'n of m', with a bar #14872

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This behaviour is already on main, so I added only the test that proves it. There is no page change, so no review block or before/after looks. What main already does (from #13425): a wave's page shows n of m changes landed.

Notes

shipped production is serving it deploy 5b5da4d

opened this

This behaviour is already on main, so I added only the test that proves it. There is no page change, so no review block or before/after looks.

What main already does (from #13425): a wave's page shows n of m changes landed. on the version line and draws one <progress max=m value=n> bar on its own row. It reserves the same space either way, so nothing shifts. With no changes it says "No changes" (WAVE_NO_CHANGES) and draws no bar, so nothing divides by zero. Landed means the pull has a merge time, so a pull closed without merging (parked) is not counted.

What I added: test/wave-progress.test.ts (new). It covers the wave page at three points:

  • 0: the "no changes" sentence, no <progress> element, no NaN.
  • Partial: one merged and one parked pull gives "1 of 2 changes landed." with the bar at max 2, value 1. This is the parked-issue risk named in the issue.
  • Full: "2 of 2 changes landed." with the bar at value 2 of 2.

What I left out: no code changed in waves.ts or wave_moved.ts. The count is of the wave's pulls, which is what the existing sentence and bar use. I did not add a separate count of closed-as-done issues.

Checks: the new test passes, and tsc and scripts/gate.ts --fix came back clean. I did not run any other test files.

To try it: bun test test/wave-progress.test.ts, or open any /:owner/:name/waves/:version page.

🤖 Generated with Claude Code

Closes #14860

commented

This behaviour is already on main, so I added only the test that proves it. There is no page change, so no review block or before/after looks.

What main already does (from #13425): a wave's page shows n of m changes landed. on the version line and draws one <progress max=m value=n> bar on its own row. It reserves the same space either way, so nothing shifts. With no changes it says "No changes" (WAVE_NO_CHANGES) and draws no bar, so nothing divides by zero. Landed means the pull has a merge time, so a pull closed without merging (parked) is not counted.

What I added: test/wave-progress.test.ts (new). It covers the wave page at three points:

  • 0: the "no changes" sentence, no <progress> element, no NaN.
  • Partial: one merged and one parked pull gives "1 of 2 changes landed." with the bar at max 2, value 1. This is the parked-issue risk named in the issue.
  • Full: "2 of 2 changes landed." with the bar at value 2 of 2.

What I left out: no code changed in waves.ts or wave_moved.ts. The count is of the wave's pulls, which is what the existing sentence and bar use. I did not add a separate count of closed-as-done issues.

Checks: the new test passes, and tsc and scripts/gate.ts --fix came back clean. I did not run any other test files.

To try it: bun test test/wave-progress.test.ts, or open any /:owner/:name/waves/:version page.

🤖 Generated with Claude Code

Approved

Test-only pull: the feature already exists on main (#13425), and the new test proves 0, partial (with a parked pull not counted) and full against the served page. The helpers and WAVE_NO_CHANGES it uses exist. No page change, so no preview difference. Next two things I would do: (1) add the wave-progress case to the TUI wave screen test if the terminal shows the same sentence; (2) assert the bar row reserves its space (a stable class/height) so the no-layout-shift claim is tested, not only the markup.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs