Public: anyone can read this; the crew can change it.

Full suite red: 8 files in check run 01m7xees27wn7dvjh0msd4s20p #14869

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/14847-full-suite-red-8-files-in-check-run-01m7 → main 8 commits fork

  • Merged. scout/14847-full-suite-red-8-files-in-check-run-01m7 was merged into main as 370e333.

Review

Sign in to review this change.
7 files changed +19 −12
src/http/server.ts +2 −1
@@ -710,6 +710,7 @@ import { previewOwner } from "../spawn/preview-owner.ts";
710710 import { cellsAvailable } from "../apps/contain.ts";
711711 import { machineShellPage, machinesSettingsPage } from "../web/pages/machines.ts";
712712 import { machineTermAsset, wasmResponse, ghosttyWasmAsset } from "../web/machine-term-asset.ts";
713 import { boundedSignal } from "../kernel/fetch_timeout.ts";
713714 import {
714715 defaultShell,
715716 mayOpenShell,
@@ -3245,7 +3246,7 @@ export async function serve(app: App, options: { warm?: { families?: readonly Fa
32453246 // so the copy it caches is the one a stranger's request reads.
32463247 const warm = scheduleWarmUp({
32473248 families: options.warm === undefined ? [] : (options.warm.families ?? WARM),
3248 get: (path) => fetch(`http://localhost:${port}${path}`, { redirect: "manual" }),
3249 get: (path) => fetch(`http://localhost:${port}${path}`, { redirect: "manual", signal: boundedSignal() }),
32493250 warn: (message, fields) => app.log.warn(message, fields),
32503251 firstAnswer,
32513252 ...(options.warm?.idleMs === undefined ? {} : { idleMs: options.warm.idleMs }),
src/kernel/outbound.ts +1 −1
@@ -203,7 +203,7 @@ export async function outboundFetch(
203203 const self = localFor(target);
204204 if (self !== undefined) {
205205 if (options.self !== true) throw new RefusedError(OWN_HOST_SENTENCE);
206 return fetch(self, { ...init, headers: asStranger(init.headers, target), redirect: "manual" });
206 return fetch(self, { ...init, headers: asStranger(init.headers, target), redirect: "manual", signal: boundedSignal(init.signal) });
207207 }
208208 if (target.protocol !== "https:" && !options.plain)
209209 throw new RefusedError(PLAIN_SENTENCE);
src/perf/page_budgets/changelog.ts +3 −2
@@ -1,4 +1,5 @@
11 import type { PageBudget } from "../page_budget.ts";
22
3 // 21: the release range reads the forge repository's row once, to name its default branch.
4 export const budget: PageBudget = { page: "changelog", pattern: "/changelog", medianMs: 50, statements: 21 };
3 // 22: the release range reads the forge repository's row once, to name its default branch; +1: the
4 // milestone distance above the entries (#14530).
5 export const budget: PageBudget = { page: "changelog", pattern: "/changelog", medianMs: 50, statements: 22 };
src/perf/page_budgets/maintenance.ts +3 −3
@@ -3,7 +3,7 @@ import type { PageBudget } from "../page_budget.ts";
33 // The admin board of duties (#13388): walked as the admin, stored rows only. Each duty reads its
44 // own state and runs, so the count moves with the number of duties and background ticks; an N+1
55 // over the duties would still show. One query reads every dismissal (#13967), one every quieted
6 // finding (#14557); one grouped read of the degraded findings (#14577). 86 is the steady count
7 // measured warm on every run (83 before another duty joined the board), not a load-sensitive
8 // figure.
6 // finding (#14557); one grouped read of the degraded findings (#14577); +3: the edge-kept duty
7 // (#14682). 86 is the steady count measured warm on every run (83 before another duty joined the
8 // board), not a load-sensitive figure.
99 export const budget: PageBudget = { page: "maintenance", pattern: "/maintenance", medianMs: 50, statements: 86 };
src/web/pages/passkeys.ts +1 −1
@@ -392,7 +392,7 @@ function accessForm(ctx: Ctx, token: string, username: string, said?: string, st
392392 title: "Set a new password",
393393 body: html`${pageHead("Set a new password")}
394394 <p class="muted small mb">An admin made this one-use link for ${username}; choose a new password and you are signed in.</p>
395 ${until === undefined ? null : html`<p class="muted small mb">This link works until <time datetime="${until}">${untilWords(until)}</time>.</p>`}
395 ${until === undefined ? null : html`<p class="muted small mb">This link works until ${time(until, { text: untilWords(until) })}.</p>`}
396396 ${said === undefined ? null : html`<p role="alert">${said}</p>`}
397397 <form method="post" action="/signin/access/${encodeURIComponent(token)}" class="stack">
398398 <div class="field"><label for="access-password">New password</label>
test/client-list.test.ts +5 −2
@@ -372,11 +372,14 @@ describe("the client list", () => {
372372 ledger.createdAt = new Date(Date.now() - 5 * 86_400_000).toISOString();
373373 await Bun.write(file, JSON.stringify(ledger));
374374 const before = parent;
375 // One instant for every answer: the list orders by last activity, and a clock read per call
376 // would let the API and the MCP tool, asked a moment apart, order the same rows differently.
377 const active = new Date().toISOString();
375378 useChildFetch(before, (url) =>
376379 url.startsWith("https://dusty--forge.test/")
377 ? Promise.resolve(Response.json({ claimed: false, lastActivityAt: new Date().toISOString() }))
380 ? Promise.resolve(Response.json({ claimed: false, lastActivityAt: active }))
378381 : url.startsWith("https://calm--forge.test/")
379 ? Promise.resolve(Response.json({ claimed: true, lastActivityAt: new Date().toISOString() }))
382 ? Promise.resolve(Response.json({ claimed: true, lastActivityAt: active }))
380383 : Promise.reject(new Error("unreachable")),
381384 );
382385 const api = await fetch(`${parentServers.url}/api/v1/forges`, { headers: { authorization: `Bearer ${adminRw}` } });
test/llms-budget.test.ts +4 −2
@@ -43,9 +43,11 @@ const get = async (token?: string): Promise<string> =>
4343 * Bytes per role, measured on a loopback origin (#14272): anonymous 9,033 (8,863 at #14272; main
4444 * already measured 9,033 when #14246 met it), signed-in 79,933, admin 91,366. Each ceiling is that
4545 * size plus about a percent, for the origin's length. Raise one only with a reason in the pull.
46 * Raised at #14429: signed-in 80,129 and admin 91,562 after the route catalogue grew (#14423-#14425).
46 * Raised at #14429: signed-in 80,129 and admin 91,562 after the route catalogue grew
47 * (#14423-#14425). Raised again: signed-in 80,570 (ceiling 81,000), admin 92,108 (ceiling 92,600)
48 * after the routes of #14570 and #14531 (feed count, app filter).
4749 */
48 const BUDGET = { anonymous: 9_100, signedIn: 80_500, admin: 92_000 } as const;
50 const BUDGET = { anonymous: 9_100, signedIn: 81_000, admin: 92_600 } as const;
4951
5052 test("/llms.txt stays under its byte budget for each role", async () => {
5153 const sizes = {

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs