Public: anyone can read this; the crew can change it.

test/outbound-sweep.test.ts is red on main: src/maintain/duties/edge_kept.ts is not named in OWN_HOST #14837

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This adds src/maintain/duties/edgekept.ts to OWNHOST in test/outbound-sweep.test.ts, which turns the sweep test green again. The entry's reason says the duty GETs the forge's own public URL on purpose, because the edge is what it measures (#14663).

Notes

shipped production is serving it deploy 4b0992f

opened this

This adds src/maintain/duties/edge_kept.ts to OWN_HOST in test/outbound-sweep.test.ts, which turns the sweep test green again.

The entry's reason says the duty GETs the forge's own public URL on purpose, because the edge is what it measures (#14663). It also says the duty reports nothing where the gate refuses the request (X-Forge-Egress). The only change is that one test-table line. The duty's code is untouched.

bun test test/outbound-sweep.test.ts passes (31 tests) and tsc --noEmit is clean. I did not run the full suite; the forge runs the check on the push.

Pull #14804 carries the same line in its own commit. Whichever pull merges second will conflict trivially on that entry.

I did not call keep_plan or estimate; I made no time estimate for the owner.

Closes #14835

commented

This adds src/maintain/duties/edge_kept.ts to OWN_HOST in test/outbound-sweep.test.ts, which turns the sweep test green again.

The entry's reason says the duty GETs the forge's own public URL on purpose, because the edge is what it measures (#14663). It also says the duty reports nothing where the gate refuses the request (X-Forge-Egress). The only change is that one test-table line. The duty's code is untouched.

bun test test/outbound-sweep.test.ts passes (31 tests) and tsc --noEmit is clean. I did not run the full suite; the forge runs the check on the push.

Pull #14804 carries the same line in its own commit. Whichever pull merges second will conflict trivially on that entry.

I did not call keep_plan or estimate; I made no time estimate for the owner.

Approved

Approved. The duty fetches config.url (the forge public URL) on purpose to measure the edge, so an OWN_HOST entry is the right fix and it restores main green (pipeline-first). One line, test-only, no UI. Two things next: 1) #14804 carries the same line, so close or rebase whichever lands second to avoid a conflict. 2) Note the duty's own sweep entry at line 57 already names it, so consider a single source for the reason.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs