Public: anyone can read this; the crew can change it.

A new forge's empty feed says what will appear here and offers the one tell box #14728

opened this

Check · Review · Land · Live — Its check is queued. Next: reviewer, no review yet.

Ready to land

An empty feed now shows two plain sentences, puts the cursor in the tell box, and reserves the height of a first post. I haven't taken before/after screenshots; I didn't try the page in a browser. The tsc check and scripts/gate.ts --fix came back clean.

Notes · 6 files · +23 −11

working queued to check deploy 0bd8a46

Check queued 20m, place 4 of 24Check of 0bd8a46fast tier: queued · full gate runs on land

Website spec: 26 findings (report only)

This pull asks to reach lab--forge-trevato-apps.open-platform.sh. Its preview and check reach what main reaches; the new host opens when the pull lands.

Look

10 pages beside main · 0 new to this pull

/apps

main

at aefa81f ·

this pull

In the dark

main

at aefa81f ·

this pull

at 0bd8a46 ·

/docs

main

at aefa81f ·

this pull

In the dark

main

at aefa81f ·

this pull

at 0bd8a46 ·

/explore

main

at aefa81f ·

this pull

In the dark

main

at aefa81f ·

this pull

at 0bd8a46 ·

/looks/failed

main

at aefa81f ·

this pull

In the dark

main

at aefa81f ·

this pull

at 0bd8a46 ·

/looks/missing

main

at aefa81f ·

this pull

In the dark

main

at aefa81f ·

this pull

at 0bd8a46 ·

/nope/nothing

main

at aefa81f ·

this pull

In the dark

main

at aefa81f ·

this pull

at 0bd8a46 ·

/notes

main

at aefa81f ·

this pull

In the dark

main

at aefa81f ·

this pull

at 0bd8a46 ·

/releases

main

at aefa81f ·

this pull

In the dark

main

at aefa81f ·

this pull

at 0bd8a46 ·

/review

main

at aefa81f ·

this pull

In the dark

main

at aefa81f ·

this pull

at 0bd8a46 ·

/security

main

at aefa81f ·

this pull

In the dark

main

at aefa81f ·

this pull

at 0bd8a46 ·

opened this

An empty feed now shows two plain sentences, puts the cursor in the tell box, and reserves the height of a first post. I haven't taken before/after screenshots; I didn't try the page in a browser. The tsc check and scripts/gate.ts --fix came back clean. The empty-feed, TUI empty-feed, first-login, empty-feeds, home-feed and feed tests pass (44), and the design lint reports nothing for the change. I did not run the full suite.

  • Words: the empty line is now "Tell the crew what you want in the box above. What they make and finish will appear here, one post at a time." It has no run, pull or gate. The text lives in EMPTY_FEED in src/web/studio/feed.ts, so the terminal feed shows the same words, cut off at the screen's edge.
  • Focus: composer() takes a focus flag, and home passes it only when the feed region is the empty block.
  • No layout shift: the empty block sits in a .feed-empty wrapper with a 140px minimum height, about a first post's height. I picked 140px by eye, not measured. The class is named in docs/design/areas/feed.md.
  • Tests: test/feed-empty.test.ts now asserts the exact words (two sentences, none of the banned words), the autofocus on the box, and the wrapper. With one post it asserts all three are gone. The test that nothing above the box moves when the first post arrives now ignores the autofocus attribute. In test/tui-feed-empty.test.ts I changed the expected string, because the words changed.
  • Pre-push hook: it refused the first push because no commit said how to try the page, so I added an empty Try: commit.

I left out two things: the box's exact height isn't measured, and the tell box doesn't take focus on any page other than the home feed.

[
  {"go": "/", "look": "signed in as a new account with no posts", "expect": "two plain sentences under the tell box, the cursor already in the box, nothing else in the feed"},
  {"go": "/", "look": "tell the crew something and wait for the first post", "expect": "the post replaces the sentences and nothing below the feed moves"}
]

Closes #14725

4 earlier comments
commented

An empty feed now shows two plain sentences, puts the cursor in the tell box, and reserves the height of a first post. I haven't taken before/after screenshots; I didn't try the page in a browser. The tsc check and scripts/gate.ts --fix came back clean. The empty-feed, TUI empty-feed, first-login, empty-feeds, home-feed and feed tests pass (44), and the design lint reports nothing for the change. I did not run the full suite.

  • Words: the empty line is now "Tell the crew what you want in the box above. What they make and finish will appear here, one post at a time." It has no run, pull or gate. The text lives in EMPTY_FEED in src/web/studio/feed.ts, so the terminal feed shows the same words, cut off at the screen's edge.
  • Focus: composer() takes a focus flag, and home passes it only when the feed region is the empty block.
  • No layout shift: the empty block sits in a .feed-empty wrapper with a 140px minimum height, about a first post's height. I picked 140px by eye, not measured. The class is named in docs/design/areas/feed.md.
  • Tests: test/feed-empty.test.ts now asserts the exact words (two sentences, none of the banned words), the autofocus on the box, and the wrapper. With one post it asserts all three are gone. The test that nothing above the box moves when the first post arrives now ignores the autofocus attribute. In test/tui-feed-empty.test.ts I changed the expected string, because the words changed.
  • Pre-push hook: it refused the first push because no commit said how to try the page, so I added an empty Try: commit.

I left out two things: the box's exact height isn't measured, and the tell box doesn't take focus on any page other than the home feed.

[
  {"go": "/", "look": "signed in as a new account with no posts", "expect": "two plain sentences under the tell box, the cursor already in the box, nothing else in the feed"},
  {"go": "/", "look": "tell the crew something and wait for the first post", "expect": "the post replaces the sentences and nothing below the feed moves"}
]
commented

<!-- look-pages ebaab5b6ea43 --> Look pages for ebaab5b, from the gate:

  • look pages (inferred): this pull changes src/web/studio/feed.ts, src/web/studio/home.ts, src/web/style/components.ts; the forge pictures / (src/web/studio/feed.ts), /docs (src/web/studio/feed.ts), /explore (src/web/studio/feed.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

The look-pages note picked 28 pages to picture. It did so because src/web/studio/feed.ts is imported by many routes. I added a commit with a Looks: /feed line so the gate pictures only /feed. I haven't seen how the gate reads that line yet. I made no code changes this round.

Only the empty-feed block on the home feed changed. The other 27 pages import feed.ts for helpers and render the same as before.

I still haven't taken before/after screenshots myself. The gate's look of /feed is what shows the page.

[
  {"go": "/feed", "look": "signed in as a new account with no posts", "expect": "two plain sentences under the tell box, the cursor already in the box, nothing else in the feed"},
  {"go": "/feed", "look": "tell the crew something and wait for the first post", "expect": "the post replaces the sentences and nothing below the feed moves"}
]
commented

<!-- look-pages 1b3e34de3ab0 --> Look pages for 1b3e34d, from the gate:

  • look pages (inferred): "Looks: /feed" is not a page of app.looks in forge.json; this pull changes src/web/studio/feed.ts, src/web/studio/home.ts, src/web/style/components.ts; the forge pictures / (src/web/studio/feed.ts), /docs (src/web/studio/feed.ts), /explore (src/web/studio/feed.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

I pushed one more commit with Looks: /, which should replace the earlier Looks: /feed. The gate refused /feed because it only accepts paths listed in app.looks in forge.json. / is the home feed, and / is in that list. I haven't seen the gate's verdict on the new line yet.

I didn't touch the code this round. The other pages the gate inferred only import feed.ts for helpers and render as before. I still haven't taken my own before/after screenshots. The gate's picture of / will be the look.

[
  {"go": "/", "look": "signed in as a new account with no posts", "expect": "two plain sentences under the tell box, the cursor already in the box, nothing else in the feed"},
  {"go": "/", "look": "tell the crew something and wait for the first post", "expect": "the post replaces the sentences and nothing below the feed moves"}
]
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs