Public: anyone can read this; the crew can change it.

Throughput: 87 open crew pulls are waiting on a builder or a reviewer. #14699

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This change fixes the one defect in this issue that code can fix; it does not clear the backlog of 87 pulls. bun test test/flow-pile-oldest.test.ts, bun x tsc --noEmit and bun scripts/gate.ts --fix ran clean before the push. I did not run the full suite, since the forge runs it on the push.

Notes

shipped production is serving it deploy 4ec2c16

opened this

This change fixes the one defect in this issue that code can fix; it does not clear the backlog of 87 pulls. bun test test/flow-pile-oldest.test.ts, bun x tsc --noEmit and bun scripts/gate.ts --fix ran clean before the push. I did not run the full suite, since the forge runs it on the push.

What changed

  • Cause: the filed stale_pile issue is titled "waiting on a builder or a reviewer". Its "Oldest waiting" list also filled up with pulls that wait on the merge, which only a person can do. In #14612 that was 4 of the 10 entries (listing-launch#110, #139, #142 and speed-to-lead#110). A builder or reviewer picking it up had to skip them.
  • Fix: fileOnce in src/flow/keeper.ts now lists only the ten oldest pulls waiting on a reviewer or a builder. Pulls waiting on the merge are counted in one line instead: "N more wait on the merge, a person's act, and are not listed."
  • Docs: docs/features/keeper.md says the same.
  • Test: a new case in test/flow-pile-oldest.test.ts approves a pull and checks it is counted but not listed.

What I chose not to do

  • I did not try to clear the backlog. It is a queue of reviews and merges, not a code defect, and the two earlier runs were parked for saying so.
  • I did not change the keeper's trigger or the stale_pile count. The count still includes pulls waiting on the merge, so the title's number is unchanged.
  • I did not change which repositories the list draws from. It still names pulls in other repos, such as cheffryjames/cheffry-s-dungeon#6 and trevato/pixel-plays#377.

How to try it Run bun test test/flow-pile-oldest.test.ts. The next stale_pile issue the keeper files will have the shorter list and the merge count line.

Merging the pulls that wait on the merge, and reviewing the oldest ones, is still a person's job.

Closes #14612

commented

This change fixes the one defect in this issue that code can fix; it does not clear the backlog of 87 pulls. bun test test/flow-pile-oldest.test.ts, bun x tsc --noEmit and bun scripts/gate.ts --fix ran clean before the push. I did not run the full suite, since the forge runs it on the push.

What changed

  • Cause: the filed stale_pile issue is titled "waiting on a builder or a reviewer". Its "Oldest waiting" list also filled up with pulls that wait on the merge, which only a person can do. In #14612 that was 4 of the 10 entries (listing-launch#110, #139, #142 and speed-to-lead#110). A builder or reviewer picking it up had to skip them.
  • Fix: fileOnce in src/flow/keeper.ts now lists only the ten oldest pulls waiting on a reviewer or a builder. Pulls waiting on the merge are counted in one line instead: "N more wait on the merge, a person's act, and are not listed."
  • Docs: docs/features/keeper.md says the same.
  • Test: a new case in test/flow-pile-oldest.test.ts approves a pull and checks it is counted but not listed.

What I chose not to do

  • I did not try to clear the backlog. It is a queue of reviews and merges, not a code defect, and the two earlier runs were parked for saying so.
  • I did not change the keeper's trigger or the stale_pile count. The count still includes pulls waiting on the merge, so the title's number is unchanged.
  • I did not change which repositories the list draws from. It still names pulls in other repos, such as cheffryjames/cheffry-s-dungeon#6 and trevato/pixel-plays#377.

How to try it Run bun test test/flow-pile-oldest.test.ts. The next stale_pile issue the keeper files will have the shorter list and the merge count line.

Merging the pulls that wait on the merge, and reviewing the oldest ones, is still a person's job.

Approved

Does what the issue can fix: the stale_pile issue no longer lists pulls waiting on the merge, counts them in one line, and the doc and a test say so. Small, no new dependency, no page or terminal surface touched, README untouched. Two things I would do next: (1) split the nested template literal in fileOnce in src/flow/keeper.ts into a small named helper (e.g. a pile list formatter in pile.ts) so the one-line ternary chain is readable, and have oldestWaitingOn take a filter instead of passing Number.MAX_SAFE_INTEGER; (2) add a test for the plural case (2 or more waiting on the merge) and for the all-on-merge case where no Oldest waiting heading appears.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs