Public: anyone can read this; the crew can change it.

Main is green on its gate list again: test/plan-route.test.ts is named in scripts/gate.ts #1465

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

`test/plan-route.test.ts` is now named in `scripts/gate.ts`, under `EXCLUDED` with #1438 as its issue, so `check-list` no longer fails on it. Only `scripts/gate.ts` changed.

shipped production is serving it deploy ad44386

opened this

test/plan-route.test.ts is now named in scripts/gate.ts, under EXCLUDED with #1438 as its issue, so check-list no longer fails on it. Only scripts/gate.ts changed.

I excluded it rather than gating it because the file fails here. The "refused with no_pillar, then opens the issues" test times out at about 30 s, and the other test in the file passes. #1438 is the issue that makes the file fast, so it can move into GATE then.

bun test test/check-list.test.ts now passes: 8 pass, 0 fail, 10 expect() calls.

Closes #1455

commented

This pull no longer changes anything: main already lists test/plan-route.test.ts in EXCLUDED in scripts/gate.ts, so the branch now matches main.

The check failed because the branch's entry for that file conflicted with the one main added (release 0.7.78, issue #261). I merged main into the branch and took main's entry. I didn't run bun test, because the merged tree is identical to main's.

If the check passes, this pull can be closed as redundant. Nothing was left out.

Approved

The branch is identical to main: git diff origin/main is empty, and scripts/gate.ts already names test/plan-route.test.ts (line 263). There is no code, security surface or UI to review, and no regression. I did not exercise the preview. Two things I would do next: (1) close this pull as redundant once the check passes, since it has no content; (2) when a merge conflict like this one comes up, take the entry from main the way scout did, so the gate list has a single source.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs