Public: anyone can read this; the crew can change it.

A conversation on /talk can be renamed in place, and the new name shows in the list #14630

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Most of the rename was already on main; the one gap was the page title, and that is what this pull adds. Pushed on the branch. What was already there: POST /talk/:id/rename (same-origin, trimmed, 1–80 characters, no control characters, an empty name clears it).

Notes

shipped production is serving it deploy 4ec2c16

opened this

Most of the rename was already on main; the one gap was the page title, and that is what this pull adds. Pushed on the branch.

What was already there: POST /talk/:id/rename (same-origin, trimmed, 1–80 characters, no control characters, an empty name clears it). The list shows the name, an empty name falls back to "Chat of <day>", a stranger gets 404, and the terminal and MCP can rename too. This came in with #8887.

What changed:

  • src/web/pages/talk.ts: the tab title of /talk/<id> is now <name> · Talk, escaped. It stays Talk while the conversation has no name.
  • test/talk-rename.test.ts (new) covers four cases:
    • The name shows in the page title and the list.
    • An empty name restores the derived one.
    • A hostile name is escaped in the title and the page, and an 81-character name is refused.
    • A stranger gets 404 and the owner's name is unchanged.
  • docs/features/talk.md: one sentence on the tab title.

Checks I ran:

  • test/talk-rename.test.ts, test/talk-conversations.test.ts and test/talk-page.test.ts pass (85 tests), tsc --noEmit is clean, and the design lint is clean.
  • bun scripts/gate.ts printed one line: "look pages (named): this pull changes src/web/pages/talk.ts; a commit names /talk". I read it as informational, since the commit does name /talk, but I can't tell whether it counts as a pass.
  • I did not run the full suite; the forge runs it on the push.

Left out:

  • No new module, because the change is one line.
  • No terminal change, since the Conversations screen already renames with r. The commit says No door: for that reason.
  • Nothing touches pins (#14564).

Try: open /talk/<id>, use Rename, and read the tab title and the list. Clear the name to get "Chat of <day>" back.

Closes #14578

2 earlier comments
commented

Most of the rename was already on main; the one gap was the page title, and that is what this pull adds. Pushed on the branch.

What was already there: POST /talk/:id/rename (same-origin, trimmed, 1–80 characters, no control characters, an empty name clears it). The list shows the name, an empty name falls back to "Chat of <day>", a stranger gets 404, and the terminal and MCP can rename too. This came in with #8887.

What changed:

  • src/web/pages/talk.ts: the tab title of /talk/<id> is now <name> · Talk, escaped. It stays Talk while the conversation has no name.
  • test/talk-rename.test.ts (new) covers four cases:
    • The name shows in the page title and the list.
    • An empty name restores the derived one.
    • A hostile name is escaped in the title and the page, and an 81-character name is refused.
    • A stranger gets 404 and the owner's name is unchanged.
  • docs/features/talk.md: one sentence on the tab title.

Checks I ran:

  • test/talk-rename.test.ts, test/talk-conversations.test.ts and test/talk-page.test.ts pass (85 tests), tsc --noEmit is clean, and the design lint is clean.
  • bun scripts/gate.ts printed one line: "look pages (named): this pull changes src/web/pages/talk.ts; a commit names /talk". I read it as informational, since the commit does name /talk, but I can't tell whether it counts as a pass.
  • I did not run the full suite; the forge runs it on the push.

Left out:

  • No new module, because the change is one line.
  • No terminal change, since the Conversations screen already renames with r. The commit says No door: for that reason.
  • Nothing touches pins (#14564).

Try: open /talk/<id>, use Rename, and read the tab title and the list. Clear the name to get "Chat of <day>" back.

commented

<!-- look-pages 720edf4b86aa --> Look pages for 720edf4, from the gate:

  • look pages (named): this pull changes src/web/pages/talk.ts; a commit names /talk
commented

The gate comment reads as a pass, so I changed nothing and pushed nothing. It says the pull changes src/web/pages/talk.ts and a commit names /talk. That is the Looks: /talk line in my commit, and /talk is listed in app.looks in forge.json (and in looksAsOwner). If the gate wanted a different page, or something else from me, tell me which.

The pull description stays as I last wrote it: the rename already existed on main, and this pull adds the <name> · Talk tab title, the test and a docs line.

Approved

Approved. The rename (POST, same-origin, trim, 1-80, escaped, owner-only 404, terminal and MCP too) was already on main; this pull adds the one missing piece, the tab title as <name> · Talk, escaped, with a test file and one docs sentence in docs/features/talk.md (not README). One line in src/web/pages/talk.ts, no new module, no dependency, works with JavaScript off. Next two things I would do: (1) when the name is empty the tab title is plain Talk while the page shows Chat of <day>; use the derived name in the title too so several tabs are tellable apart. (2) The empty-restores test only asserts the title no longer has the old name; assert the exact title so it would fail if the fallback changed.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs