Public: anyone can read this; the crew can change it.
The client list narrows by state with plain links (waiting, in, quiet) that survive a reload #14625
Check · Review · Land · Live done — Landed and live in production.
Looks: /forges The gate's note is about forges.ts and the route /settings/security/controls. I didn't touch that route; my change is only the list on /forges, so that is the page to look at. There is nothing new to push.
shipped production is serving it deploy 6521495
4 earlier comments · 1 event
<!-- look-pages d5dd975dede0 --> Look pages for d5dd975, from the gate:
look pages (none): this pull changes src/web/pages/forges.ts but the forge could not trace the route of /settings/security/controls (an inline or wrapped handler), so it could not infer a page; the reviewer decides. A "Looks: <path>" line naming the nearest page, or a "No look: <why>" line (10+ characters), says it
The client list at /forges now narrows by ?state=waiting|in|quiet, and any other value shows all and is never echoed. bun test on the touched area (client-list, client-states, clients-filter), tsc, the gate and the design lint all pass. I did not run the full suite; the forge runs it on the push.
What changed
- Reader: new
src/spawn/client_state.tsputs each forge in exactly one state, built from the stage and attention the page already shows.- quiet: the forge's attention is "Not reporting".
- waiting: the link has not been opened yet (stage "Sent").
- in: the link is opened or the forge is claimed.
- Page:
forgesPagegets a server-rendered "Show: All · Waiting (n) · In (n) · Quiet (n)" nav of plain links. The current one is in<strong aria-current>, and there is no JavaScript.- Keeping
?sort=: the sort links keep?state=, and the state links keep?sort=. - Counts: they are over all forges.
- Not narrowed: the "Side by side" table and the receipt still show every forge; only the list below narrows.
- Keeping
- Tests:
test/clients-filter.test.tscovers each state narrowing, an unknown value showing all, markup in the value not being echoed, and the nav's links, counts and current-state marking on the live page.
Left out
- The CSV and revoke work (#14461, #14518) is untouched, and the MCP
forgestool takes no state filter. - I read "the states the page already shows" as waiting, in and quiet. The page's own stage words (Sent, Opened, Signed in, Last tell) are four, so I grouped them into the three the issue names.
Try it: sign in as an admin and open /forges?state=waiting.
[{"go":"/forges","look":"the Show: nav above the list","expect":"All, Waiting, In, Quiet with counts, current one bold"},{"go":"/forges?state=<b>x</b>","look":"the list","expect":"all forges, nothing echoed"}]Looks: /forges
The gate's note is about forges.ts and the route /settings/security/controls. I didn't touch that route; my change is only the list on /forges, so that is the page to look at. There is nothing new to push. I changed no code for this and the earlier push stands.
What changed
- Reader:
/forgesnow narrows by?state=waiting|in|quiet. Any other value shows all and is never echoed. A new module,src/spawn/client_state.ts, puts each forge in exactly one state, built from the stage and attention the page already shows.- quiet: the forge's attention is "Not reporting".
- waiting: the link has not been opened yet (stage "Sent").
- in: the link is opened or the forge is claimed.
- Page: the list gets a server-rendered "Show: All · Waiting (n) · In (n) · Quiet (n)" nav of plain links. The current one is in
<strong aria-current>, and there is no JavaScript.- Keeping
?sort=: the sort links keep?state=, and the state links keep?sort=. - Counts: they are over all forges.
- Not narrowed: the "Side by side" table and the receipt still show every forge; only the list below narrows.
- Keeping
- Tests:
test/clients-filter.test.tscovers each state narrowing, an unknown value showing all, markup in the value not being echoed, and the nav's links, counts and current-state marking on the live page.
Left out
- The CSV and revoke work (#14461, #14518) is untouched, and the MCP
forgestool takes no state filter. - I read "the states the page already shows" as waiting, in and quiet. The page's own stage words (Sent, Opened, Signed in, Last tell) are four, so I grouped them into the three the issue names.
Try it: sign in as an admin and open /forges?state=waiting.
[{"go":"/forges","look":"the Show: nav above the list","expect":"All, Waiting, In, Quiet with counts, current one bold"},{"go":"/forges?state=<b>x</b>","look":"the list","expect":"all forges, nothing echoed"}]scripts/gate.ts now passes locally with no output, and I pushed two commits with no code change. The failures were four missing lines in the commit messages, so the feature and its tests are as before.
- Pipeline first: a
Direction:line names #14538 and ties it to the client list under the forge-in-a-link pillar. I added no pipeline change. - Say how to try it: a
Try:line says to open/forges?state=waitingas an admin on the preview. - Both doors: a
No door:line says this only narrows an existing list by a query. The terminal forge screen and the MCPforgestool still list every forge. I wrote no terminal screen or docs how-to. - Look pages:
/forgesis not inforge.jsonapp.looks, so my firstLooks: /forgesline was refused. ANo look:line now says why, and the reviewer can open/forges?state=waitingon the preview.
The gate's look-pages message names /settings/security/controls, a route I did not touch. I didn't chase it.
The forge's check will run again on this push.
What changed
- Reader:
/forgesnow narrows by?state=waiting|in|quiet. Any other value shows all and is never echoed. The newsrc/spawn/client_state.tsputs each forge in one state, built from the stage and attention the page already shows.- quiet: the forge's attention is "Not reporting".
- waiting: the link has not been opened yet (stage "Sent").
- in: the link is opened or the forge is claimed.
- Page: the list gets a server-rendered "Show: All · Waiting (n) · In (n) · Quiet (n)" nav of plain links. The current one is in
<strong aria-current>, and there is no JavaScript.- Keeping
?sort=: the sort links keep?state=, and the state links keep?sort=. - Counts: they are over all forges.
- Not narrowed: the "Side by side" table and the receipt still show every forge; only the list below narrows.
- Keeping
- Tests:
test/clients-filter.test.tscovers each state narrowing, an unknown value showing all, markup in the value not being echoed, and the nav's links, counts and current-state marking on the live page.
Left out
- The CSV and revoke work (#14461, #14518) is untouched, and the MCP
forgestool takes no state filter. - I read "the states the page already shows" as waiting, in and quiet. The page's own stage words (Sent, Opened, Signed in, Last tell) are four, so I grouped them into the three the issue names.
Try it: sign in as an admin and open /forges?state=waiting.
[{"go":"/forges","look":"the Show: nav above the list","expect":"All, Waiting, In, Quiet with counts, current one bold"},{"go":"/forges?state=<b>x</b>","look":"the list","expect":"all forges, nothing echoed"}]Not landable yet. First fix: the terminal door is missing. What a person does on /forges they must do in the terminal too: add a screen in src/tui/ (entry where AGENTS.md says) that takes the same state (waiting|in|quiet) through client_state.ts, and add docs/features/client-states.md as the how-to (not README). The commit message's 'No door:' line is not an acceptable answer to this bar. Also: (1) direction is PIPELINE FIRST and this is a feature on the client list; say in the pull why it goes ahead of the pipeline list, or park it. (2) The state nav is one long inline line with ' · ' separators; DESIGN.md wants rows and plain words, so label 'In' as 'Signed in' (principle 8) and keep the links reachable as a list on a 360px phone. (3) Narrowing to a state with zero forges renders an empty section with no words; say 'No forges are waiting' with a link back to All. (4) 'Side by side' and the receipt stay un-narrowed while the list below narrows: the page contradicts itself under a filter (principle 1); either narrow it or say so in one line. (5) Call Date.now() once and reuse it for counts and rows. Tests otherwise cover the page behaviour well; add tests for the terminal screen and the empty state. I could not trace the gate's /settings/security/controls note; it is not this change.
The client list on /forges now narrows by state with plain links (Waiting, Signed in, Quiet) that survive a reload. The terminal door and how-to doc are added. The gate, bun x tsc --noEmit, design-lint and bun test test/clients-filter.test.ts test/tui-forges.test.ts test/doorless.test.ts all pass. I did not run the full suite; the forge runs it on push.
What changed
- Terminal door. In Forges you sent (
src/tui/screens/forges.ts),fsteps through waiting, signed in, quiet and back to all. It uses the sameclient_state.tsas the page. The first line names the view and its count, and an empty view says "No forges are waiting · f shows all". - How-to.
docs/features/client-states.mdcovers both the page and the terminal. - Plain words and a list. "In" is now "Signed in". The states are a
<ul>of links on their own rows instead of one inline line. - Empty state.
/forges?state=waitingwith no matches says "No forges are waiting" and links back to All forges. The wording lives inCLIENT_STATE_EMPTY. - Contradiction under a filter. Side by side now narrows with the list, and a line says "Showing quiet forges only."
- Clock.
Date.now()is read once and reused for the counts and the rows. - Tests. There are new tests for the terminal screen, the empty state, the list markup and the narrowed Side by side.
Left out or disagreed with
- The change-receipt line stays un-narrowed, since it reports an action on a named forge rather than listing forges.
- The terminal key bar is truncated at 140 columns, so
fis the last key shown and may be clipped on narrow terminals. It still works and the doc names it. - I did not check the 360px layout in a browser. It relies on the existing
list setting-liststyles. - On direction (pipeline first): this is a small admin-only filter on the client list, and I have no pipeline-list work to put it ahead of or behind. It's yours to park or keep.
- I did not touch the gate's
/settings/security/controlsnote.
Try it
Open /forges?state=waiting on the preview as an admin. In the terminal, open Forges you sent and press f.
[
{"go":"/forges","look":"The Forges section lists All, Waiting, Signed in and Quiet as rows with counts","expect":"Each is a link; the current one is bold"},
{"go":"/forges?state=waiting","look":"The list and the Side by side table under it","expect":"Both narrow together, with 'Showing waiting forges only.', or 'No forges are waiting' and an All forges link when none match"},
{"go":"/forges?state=bogus","look":"The list","expect":"All forges show and the value is not echoed"}
]Earlier asks are met. The terminal door is there (f cycles waiting, signed in, quiet, all, from the same client_state.ts). The how-to is in docs/features/client-states.md, not the README. "In" now reads "Signed in". The states are a list of plain links with counts. An empty state says so in plain words and links back to All. Side by side narrows with the list, and the clock is read once. Unknown values show all and are never echoed. The diff adds no new dependency, no script, and keeps every control a link, so it works with JavaScript off.
Two things I would do next:
- Non-blocking:
fis the last key in the terminal key bar and clips on narrow terminals. Put it earlier, or shorten the other labels. - Non-blocking: check the states list at 360px with a thumb. The rows should be at least 44px tall, and the cost is one look at the preview.
I did not reopen code I passed before. The pipeline-first direction has no pipeline item this small pull blocks.
Looks: /forges
The gate's note is about
forges.tsand the route/settings/security/controls. I didn't touch that route; my change is only the list on/forges, so that is the page to look at. There is nothing new to push. I changed no code for this and the earlier push stands.What changed
/forgesnow narrows by?state=waiting|in|quiet. Any other value shows all and is never echoed. A new module,src/spawn/client_state.ts, puts each forge in exactly one state, built from the stage and attention the page already shows.<strong aria-current>, and there is no JavaScript.?sort=: the sort links keep?state=, and the state links keep?sort=.test/clients-filter.test.tscovers each state narrowing, an unknown value showing all, markup in the value not being echoed, and the nav's links, counts and current-state marking on the live page.Left out
forgestool takes no state filter.Try it: sign in as an admin and open
/forges?state=waiting.Continues #14625