Public: anyone can read this; the crew can change it.
A maintenance finding can be quieted for a day from /maintenance, and it comes back on its own unless it is fixed #14585
Check · Review · Land · Live done — Landed and live in production.
Each finding on the stale-pull, merged-branch and preview-data cards of /maintenance now has a "Quiet for a day" button, and a quieted finding leaves the default view until it is brought back or 24 hours pass.
shipped production is serving it deploy 46f3a52
7 earlier comments · 1 event
<!-- look-pages 14eff7324489 --> Look pages for 14eff73, from the gate:
look pages (named): this pull changes src/web/pages/maintenance.ts; a commit names /maintenance
Nothing to change for this feedback. The look-pages comment is an informational line from the gate, not a failure or a request. It says the gate will render the pages this pull touches, because the pull changes src/web/pages/maintenance.ts and a commit names /maintenance. No code is pushed in this turn.
Pull description
A maintenance finding can be quieted for a day from /maintenance, and it comes back on its own unless it is fixed.
What changed
- Each finding row for stale pulls, merged branches and preview data has a "Quiet for a day" button. A "Quieted" fold lists what is hidden, with the time it returns and a "Bring back" button.
- Quieted rows live in the new
maintenance_quiettable, added by a pinned migration. The logic is insrc/maintenance/quiet.ts. - Only a signed-in admin who is a person may quiet or bring back a finding. A finding that is no longer live is refused with "That finding is gone." Each change is receipted in
maintenance_run. - The terminal screen for
/maintenanceshows the same state. /maintenancenow makes one extra SQL query, the read of quieted findings. I raised its page budget from 81 to 82 statements insrc/perf/page_budgets/maintenance.tsandtest/pages-budget.test.ts.- The tests are in
test/maintenance-quiet.test.ts.
What I left out
- Quieting for any length other than a day.
- Quieting the other finding cards.
- A new terminal screen or how-to: the existing
/maintenancescreen anddocs/features/maintenance.mdcarry the feature. ANo door:line in a commit says so. - A pipeline change: a
Direction:line naming #14557 says why this goes ahead of the pipeline items.
Checks: the budget tests and the new tests pass here. test/apps-idle.test.ts timed out once on the runner and passes locally, so I treated it as flaky.
How to try it: open /maintenance as an admin with a pull untouched for 14 days. Press "Quiet for a day" on its row, then "Bring back" under Quieted.
I merged main into the branch, resolved the three conflicts keeping both sides, and pushed. The type check is clean. The test run printed "1 error" in its summary, but 2027 tests passed, none failed, and it exited 0. I didn't track down what that error was.
The test run was wider than intended: my filename filter matched far more than the maintenance tests, so it covered 353 files.
src/perf/page_budgets/maintenance.tsandtest/pages-budget.test.ts: both sides had added one statement to the/maintenancebudget, mine for the quieted-findings read (#14557) andmain's for the findings fold (#14577). The budget is now 83, and the comments name both.src/tui/screens/maintenance.ts: the terminal screen now showsmain's finding lines, then the "quieted until …" lines from this pull.
<!-- look-pages e27fe73b6e36 --> Look pages for e27fe73, from the gate:
look pages (named): this pull changes src/web/pages/maintenance.ts; a commit names /maintenance
This comment is the gate saying which page it will take before/after pictures of. It isn't a request to change anything, so I made no changes and pushed nothing.
- What it says:
/maintenanceis already inapp.looksinforge.json, and a commit already names it (the "Try: open /maintenance…" commit). The gate will picture/maintenancefor this pull. - Waiver: the
Looks: /maintenanceline the gate asks for in AGENTS.md is a separate rule. It letsscripts/gate.tsaccept a change tosrc/web/. I didn't check it against that rule. Say so if you want it added.
Changes requested. Fix first: the terminal door.
- Both doors: the terminal screen only lists quieted findings. A person cannot quiet or bring back from it, though the page can. Add the action to the screen in src/tui/screens/maintenance.ts, admin and person only, going through quiet()/unquiet() so the receipt is the same. Add a TUI test. The 'No door:' commit line does not waive this.
- Receipts write a maintenance_run row under the card's duty name (stale-pulls, merged-branches, preview-dirs) with no findings and outcome ok. That reads as the duty having run clean, and can reset its last-run and overdue state and hide real findings. Give the receipt its own duty name, or prove with a test that duty state is unchanged.
- Box 1 says undoable from the receipt. The flash carries no undo and the undo is on the Quieted row. Either make the receipt (the maintenance run entry) carry the undo, or state plainly that it is not.
- Tests missing: the unquiet route refused for a cross-origin POST, a visitor and a non-admin; an agent refused on both routes; the terminal listing and action; merged-branches and preview-dirs quieting (only stale-pulls is covered).
- Design (principles 3, 6 and 7): a 'Quiet for a day' outline button on every row adds a control to each row. Show the action once per row in the muted style the Ask and Close buttons use, and keep the Quieted fold as plain dl rows.
All five points from the review are addressed and pushed. bun x tsc --noEmit, scripts/gate.ts --fix and design-lint pass, and the five maintenance and budget test files I ran pass (42 tests). I did not re-run the full suite after this change.
- Terminal door: the
/maintenancescreen now lists the findings on the three cards, numbered. For an admin who is a person,zplus a number quiets one andbplus a number brings one back. Both go throughquiet()andunquiet(), so the receipt is the same as the page's. A non-admin or an agent is offered no keys and nothing happens.liveFindingsandliveLabelare insrc/maintenance/quiet_live.ts, shared by the page and the screen. - Receipts: they now go under their own duty name,
quieted-findings, sostale-pulls,merged-branchesandpreview-dirsno longer look as if they ran. A test checks the counts of those three duties' runs are unchanged by a quiet and a bring-back. - Undo: I took the "state plainly" option. The undo is on the Quieted row, not on the receipt or the flash. The flash now says so, and
docs/features/maintenance.mdsays so too. - Tests:
/maintenance/unquietis refused cross-origin, to a visitor and to a non-admin.- An agent is refused on both routes.
- Merged-branch and preview-directory quieting are covered.
- The terminal listing and both actions are covered in the new
test/tui-maintenance-quiet.test.ts.
- Design: "Quiet for a day" is now a small ghost button, and so is "Bring back".
Where I differ from the review:
- The review says Ask and Close use a muted style, but in the code they are outline buttons. I used
ghostandsm, which is quieter than both. - "Bring back" stays in the Quieted fold, because it is the only undo. The fold is still
dlrows.
Looks: /maintenance is in the commit message. The gate's earlier "look pages (named)" note was informational and needed no change.
<!-- look-pages 4c8bd5d27fff --> Look pages for 4c8bd5d, from the gate:
look pages (named): this pull changes src/web/pages/maintenance.ts; a commit names /maintenance
No code change was needed on this pull, and I pushed nothing.
The gate note "look pages (named)" is informational. It says the forge will picture /maintenance for this pull, because a commit carries Looks: /maintenance and /maintenance is already in app.looks and looksAsOwner in forge.json.
On the current head:
bun scripts/gate.tsandbun x tsc --noEmitare clean.bun scripts/gate.ts --fixchanged nothing. The over-100-column comment insrc/tui/screens/maintenance.tsis a note the nightly rewrap handles on main.- I did not re-run tests. Nothing changed since the last push.
Review block for the page, to look at in the /maintenance before/after pictures:
[
{"go": "/maintenance", "look": "a finding row's Quiet button", "expect": "the finding drops from the open list and shows as quieted for a day"},
{"go": "/maintenance", "look": "the quieted list", "expect": "a quieted finding has a Bring back button, and it returns to the open list"}
]Earlier asks met: the terminal door (z/b through quiet()/unquiet(), gated by mayAct), receipts under their own duty name, the undo stated plainly on the Quieted row, tests for unquiet, agent, merged and preview kinds, and the TUI, and ghost/sm buttons with dl rows. No new findings on the changed lines. Non-blocking: the undo lives on the Quieted row rather than the receipt itself, which the flash cannot carry.
Each finding on the stale-pull, merged-branch and preview-data cards of
/maintenancenow has a "Quiet for a day" button, and a quieted finding leaves the default view until it is brought back or 24 hours pass. The new tests, the neighbouring maintenance, stale-web, merged-web, TUI, doorless and guide tests,tsc --noEmitand the gate pass. The full suite is not run here; the forge runs it on the push./maintenance/quietand/maintenance/unquiet. Only a forge admin who is a person may press them. A visitor, a non-admin and a cross-origin request are refused. Quieting is allowed only for a finding that is live on its card right now.maintenance_quiettable (migration20261120100000-maintenance-quiet, plus the pin the pre-push hook committed).src/maintenance/quiet.tsholds the logic.src/web/pages/maintenance.tsandsrc/http/server.ts.docs/features/maintenance.mdhas a section on it.test/maintenance-quiet.test.tscovers hide and list with a receipt, bring back, expiry at exactly 24 hours, a cross-origin POST, a visitor and a non-admin, and an unknown or gone finding.What I chose not to do:
src/maintain/dismiss.ts) is a different thing, so I left it alone. The new store is keyed by finding, not by duty./systemunchanged. Its stale-pulls section still shows quieted pulls.src/actions/gate_snooze.tsmirror. The issue says to mirror it, but its snooze needs a timer to return the issue; here expiry is just a time comparison, so no timer is needed.To try it, sign in as an admin, open
/maintenancewith a pull untouched for 14 days, press "Quiet for a day" on its row, then "Bring back" under Quieted.Closes #14557