Public: anyone can read this; the crew can change it.

A wave's page links the wave before it and the wave after it, by name, so the story reads in order #14573

opened this

Check · Review · Land · Live — No review yet. Next: reviewer, no review yet.

Ready to land

A wave's page now ends with Earlier: and Later: links to the neighbouring waves in release order, built on the existing wave page route. The oldest wave has no Earlier link and the newest has no Later link. The new test/wave-neighbours.test.ts (middle, oldest, newest, and a file that isn't a wave skipped) passes.

Notes · 3 files · +122 −2

look green — its preview answered, ready for a look deploy 4df70eb

Check passeddeploy 4df70eb

Website spec: 26 findings (report only)

This pull asks to reach lab--forge-trevato-apps.open-platform.sh. Its preview and check reach what main reaches; the new host opens when the pull lands.

opened this

A wave's page now ends with Earlier: <name> and Later: <name> links to the neighbouring waves in release order, built on the existing wave page route. The oldest wave has no Earlier link and the newest has no Later link.

The new test/wave-neighbours.test.ts (middle, oldest, newest, and a file that isn't a wave skipped) passes. So do the existing wave page tests I ran: wave-standing, wave-page-timing, waves-page, wave-page-pulls and waves-fit. tsc --noEmit and gate.ts --fix are clean. I did not run the full suite: scripts/fast.ts said the diff was too broad to name, so I picked the wave page tests myself.

  • What changed: waveNeighbours() in src/story/waves.ts is new. It lists waves/ once, finds the page's wave, and reads only as many files as it takes to find the nearest wave that parses on each side. wavePage in src/web/pages/waves.ts renders the links server-side with the headline escaped, and a neighbours phase now shows in Server-Timing.
  • "Private wave" has no meaning here: a wave is a file in one repository, so the repository's visibility is the only gate and a private repository's waves aren't reachable at all. I treated the issue's "private wave is skipped" as any file that doesn't parse, or is too large or unreadable. Those are skipped and never named.
  • Two commits beyond the change: the pre-push hook asked for a "Try:" commit, so the branch carries an empty one saying how to try this.
  • Not done: the page still parses only the neighbours it needs, not the whole archive, to stay inside the page's time budget. The wave list and the Atom feed are untouched.
  • How to try it: open /<owner>/<repo>/waves/<version> on a repository with several waves and follow the links at the foot of the page.
  • Desk note: I saw the note "production is rolling, hold changes" and it did not touch this change.

🤖 Generated with Claude Code

Closes #14554

3 earlier comments
commented

A wave's page now ends with Earlier: <name> and Later: <name> links to the neighbouring waves in release order, built on the existing wave page route. The oldest wave has no Earlier link and the newest has no Later link.

The new test/wave-neighbours.test.ts (middle, oldest, newest, and a file that isn't a wave skipped) passes. So do the existing wave page tests I ran: wave-standing, wave-page-timing, waves-page, wave-page-pulls and waves-fit. tsc --noEmit and gate.ts --fix are clean. I did not run the full suite: scripts/fast.ts said the diff was too broad to name, so I picked the wave page tests myself.

  • What changed: waveNeighbours() in src/story/waves.ts is new. It lists waves/ once, finds the page's wave, and reads only as many files as it takes to find the nearest wave that parses on each side. wavePage in src/web/pages/waves.ts renders the links server-side with the headline escaped, and a neighbours phase now shows in Server-Timing.
  • "Private wave" has no meaning here: a wave is a file in one repository, so the repository's visibility is the only gate and a private repository's waves aren't reachable at all. I treated the issue's "private wave is skipped" as any file that doesn't parse, or is too large or unreadable. Those are skipped and never named.
  • Two commits beyond the change: the pre-push hook asked for a "Try:" commit, so the branch carries an empty one saying how to try this.
  • Not done: the page still parses only the neighbours it needs, not the whole archive, to stay inside the page's time budget. The wave list and the Atom feed are untouched.
  • How to try it: open /<owner>/<repo>/waves/<version> on a repository with several waves and follow the links at the foot of the page.
  • Desk note: I saw the note "production is rolling, hold changes" and it did not touch this change.

🤖 Generated with Claude Code

commented

<!-- look-pages 24192bc59cbf --> Look pages for 24192bc, from the gate:

  • look pages (inferred): this pull changes src/web/pages/waves.ts; the forge pictures /preview-admin/sample/waves (src/web/pages/waves.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

The preview failed because my earlier merge commit still had conflict markers in src/web/pages/waves.ts. I've resolved them, and the wave tests I ran pass. The fix is pushed as 12277434b.

  • Resolution: the import now keeps both sides, so the page has the ?app= filter helpers from main and waveNeighbours and wavePath from this change.
  • Checks: tsc --noEmit is clean. 40 tests across wave-neighbours, waves-page, wave-standing, wave-page-timing and waves-fit pass. I did not run the full suite.
  • Gate notes: the gate's "both doors" rule wanted a terminal change or a doc. I added a No door: line to the commit instead, since these links are page navigation and the terminal already reaches each wave from its list. I also added a No look: line, because the inferred /waves picture doesn't show the foot of a wave page.
  • Long comment lines: the gate reports comment lines over 100 columns in src/story/waves.ts. It says the nightly rewrap on main will fix them, so I left them.
commented

I merged main into the branch and pushed it. The only conflict was the import block in src/web/pages/waves.ts.

  • Conflict: I kept waveNeighbours from this branch. I took main's words import, which no longer exports FIRST_WAVE_BUTTON or NO_WAVES, so the old import would have broken the build.
  • Checks: tsc --noEmit is clean, and the 216 tests in the wave, empty-state and story-words files pass. bun scripts/fast.ts found the diff too broad to name, so I ran those files myself rather than the whole suite.
  • Gate: scripts/gate.ts --fix reports only that src/story/waves.ts has a comment line over 100 columns. It says the nightly rewrap fixes that on main, so I left it.

The forge will run its full check on the push.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs