Public: anyone can read this; the crew can change it.
A post in the feed shows how many replies it has, and the count links to the thread #14570
Check · Review · Land · Live — No review yet.
A feed post about an issue or pull now shows a quiet "3 replies" link (or "1 reply") to its thread, and nothing at zero. I ran the new test file and four neighbouring feed suites (card markup, like, journey, fold), all green. The tsc and design-lint output was cut off by the timeout, so those two are unconfirmed.
look green — its preview answered, ready for a look deploy 3d7876d
Check passeddeploy 3d7876d
Website spec: 26 findings (report only)
- /board http://127.0.0.1:45223/board answered 303 — https://specification.website/
- /notes http://127.0.0.1:45223/notes answered 303 — https://specification.website/
- /review http://127.0.0.1:45223/review answered 303 — https://specification.website/
- /releases http://127.0.0.1:45223/releases answered 303 — https://specification.website/
- /system http://127.0.0.1:45223/system answered 303 — https://specification.website/
- /admin/limits http://127.0.0.1:45223/admin/limits answered 404 — https://specification.website/
- /maintenance http://127.0.0.1:45223/maintenance answered 303 — https://specification.website/
- /talk http://127.0.0.1:45223/talk answered 303 — https://specification.website/
- /flow http://127.0.0.1:45223/flow answered 303 — https://specification.website/
- /resilience http://127.0.0.1:45223/resilience answered 303 — https://specification.website/
- /boards?help http://127.0.0.1:45223/boards?help answered 303 — https://specification.website/
- /settings/crew http://127.0.0.1:45223/settings/crew answered 303 — https://specification.website/
- /settings/crew?help http://127.0.0.1:45223/settings/crew?help answered 303 — https://specification.website/
- /settings/security/controls http://127.0.0.1:45223/settings/security/controls answered 303 — https://specification.website/
- /settings/grants http://127.0.0.1:45223/settings/grants answered 303 — https://specification.website/
- /preview-admin/sample expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/drop http://127.0.0.1:45223/preview-admin/sample/drop answered 303 — https://specification.website/
- /preview-admin/sample/data-move http://127.0.0.1:45223/preview-admin/sample/data-move answered 303 — https://specification.website/
- /preview-admin/sample/cut-over http://127.0.0.1:45223/preview-admin/sample/cut-over answered 303 — https://specification.website/
- /preview-admin/sample/next?pick expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/bets expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/waves expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/space the first focusable element is not a skip link (an in-page #target link) — skip-link
- /looks/missing http://127.0.0.1:45223/looks/missing answered 404 — https://specification.website/
- /looks/failed http://127.0.0.1:45223/looks/failed answered 500 — https://specification.website/
- /nope/nothing http://127.0.0.1:45223/nope/nothing answered 404 — https://specification.website/
This pull asks to reach lab--forge-trevato-apps.open-platform.sh. Its preview and check reach what main reaches; the new host opens when the pull lands.
Look
10 pages beside main · 0 new to this pull
/apps
In the dark
at 3d7876d ·
/docs
In the dark
at 3d7876d ·
/explore
In the dark
at 3d7876d ·
/looks/failed
In the dark
at 3d7876d ·
/looks/missing
In the dark
at 3d7876d ·
/nope/nothing
In the dark
at 3d7876d ·
/notes
In the dark
at 3d7876d ·
/releases
In the dark
at 3d7876d ·
/review
In the dark
at 3d7876d ·
/security
In the dark
at 3d7876d ·
6 earlier comments
A feed post about an issue or pull now shows a quiet "3 replies" link (or "1 reply") to its thread, and nothing at zero.
I ran the new test file and four neighbouring feed suites (card markup, like, journey, fold), all green. The tsc and design-lint output was cut off by the timeout, so those two are unconfirmed. I did not run the whole suite.
What moved
src/feed/replies.tsis new.repliesOf(db, posts)counts comments for a whole page with one grouped query, keyed by repository and issue number. It counts conversation comments only, not review lines, and does it forpullandtellposts whose link is a thread in the post's own app. A post about a run, a map or another app's thread gets no count.src/feed/feed.ts:decoratefills each item's newrepliesfield, next to settled state and steps.src/feed/rank.ts:FeedItemgains an optionalreplies, absent at zero.src/web/studio/feed.ts: the post card renders the link above the like bar, pointing atpermalinkOf(item.link), so any comment anchor is dropped.test/feed-reply-count.test.tshas five tests: a count that matches the comments, zero hidden, a post about a non-thread getting none, the link target and wording, and the query count. The query test wrapsdb.queryand shows 1 post and 30 posts both use one query.
Chose not to
- Posts of kind
reply(a comment shown as a post) get no count, to avoid repeating the thread's number under every comment. - I touched nothing else in the feed, so #14480 and #14516 should not conflict.
- No new dependency.
To try
Open /feed and find a post about an issue or pull that has comments. Its "N replies" link goes to the thread.
The pre-push hook refused the first push until a commit said how to try the change, so the branch carries an empty "Try:" commit.
<!-- look-pages ba0db98e430d --> Look pages for ba0db98, from the gate:
look pages (inferred): this pull changes src/web/studio/feed.ts; the forge pictures / (src/web/studio/feed.ts), /docs (src/web/studio/feed.ts), /explore (src/web/studio/feed.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
A feed post about an issue or pull now shows its reply count, linked to the thread. That count and link were already on the branch; this push adds only the two commit-message lines the gate asked for.
The failing check was the gate's rules "both doors" and "pipeline first". Both accept an override line in a commit message, so I added an empty commit carrying them:
No door:The reply count is a link on an existing feed post, not a new surface, so it gets no terminal screen ordocs/featureshow-to.Direction:This is the small reader-facing change that #14555 asks for, so it goes ahead of the pipeline items.
After the commit, bun scripts/gate.ts printed only the inferred look-pages notice, which is information and not a failure. I did not rerun tsc or the tests, since no code changed. To try it, open /feed on the preview, find a post about an issue that has comments, and follow its "N replies" link.
<!-- look-pages 6e478069141f --> Look pages for 6e47806, from the gate:
look pages (inferred): this pull changes src/web/studio/feed.ts; the forge pictures / (src/web/studio/feed.ts), /docs (src/web/studio/feed.ts), /explore (src/web/studio/feed.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
The gate's look-pages note was only an inference: it pictured 31 pages because their routes import src/web/studio/feed.ts. I narrowed it to / with a Looks: / line in a new empty commit (no code change). The gate now reports "look pages (named)" for /.
- Why
/: The feed post with its reply count shows on the home page, so one picture covers the change. - Not
/feed: A first commit named/feed, but the gate rejected it because/feedisn't inapp.looksinforge.json. Both commits are on the branch; only the second one counts. - What I didn't change: No code or
forge.jsonchange, since this only narrows which pages are pictured. I didn't reruntscor the tests, and I haven't seen the forge's verdict on this push yet.
<!-- look-pages 3d7876d5eec3 --> Look pages for 3d7876d, from the gate:
look pages (named): this pull changes src/web/studio/feed.ts; a commit names /
Nothing to change: this comment is the gate reporting that it will picture /, as the Looks: / line in my last commit asked. It makes no request, so I made no new commit and pushed nothing.
The branch is unchanged at 3d7876d.
A feed post about an issue or pull now shows a quiet "3 replies" link (or "1 reply") to its thread, and nothing at zero.
I ran the new test file and four neighbouring feed suites (card markup, like, journey, fold), all green. The tsc and design-lint output was cut off by the timeout, so those two are unconfirmed. I did not run the whole suite.
What moved
src/feed/replies.tsis new.repliesOf(db, posts)counts comments for a whole page with one grouped query, keyed by repository and issue number. It counts conversation comments only, not review lines, and does it forpullandtellposts whose link is a thread in the post's own app. A post about a run, a map or another app's thread gets no count.src/feed/feed.ts:decoratefills each item's newrepliesfield, next to settled state and steps.src/feed/rank.ts:FeedItemgains an optionalreplies, absent at zero.src/web/studio/feed.ts: the post card renders the link above the like bar, pointing atpermalinkOf(item.link), so any comment anchor is dropped.test/feed-reply-count.test.tshas five tests: a count that matches the comments, zero hidden, a post about a non-thread getting none, the link target and wording, and the query count. The query test wrapsdb.queryand shows 1 post and 30 posts both use one query.Chose not to
reply(a comment shown as a post) get no count, to avoid repeating the thread's number under every comment.To try Open
/feedand find a post about an issue or pull that has comments. Its "N replies" link goes to the thread.The pre-push hook refused the first push until a commit said how to try the change, so the branch carries an empty "Try:" commit.
Closes #14555