Public: anyone can read this; the crew can change it.

Full suite red: test/pages-worker-retire.test.ts #14566

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/14548-full-suite-red-test-pages-worker-retire → main 4 commits fork 1 thread · 1 unresolved

  • Merged. scout/14548-full-suite-red-test-pages-worker-retire was merged into main as 29e1fd2.

Review

Sign in to review this change.
2 files changed +32 −9
test/job-slices.test.ts +2 −1
@@ -383,7 +383,8 @@ test("the memory sampler reads the heap's size without walking the heap", async
383383 memory.tick();
384384 // The baseline, in this run on this heap: one walk of it, what the tick did before #11118.
385385 const walk = await slice(() => heapStats());
386 const tick = await slice(() => memory.tick());
386 // The best of three: a busy machine (the check runs shards side by side) can stall one tick.
387 const tick = Math.min(await slice(() => memory.tick()), await slice(() => memory.tick()), await slice(() => memory.tick()));
387388 console.log(`memory-sampler on ${held.length} objects: ${tick.toFixed(1)} ms; heapStats() alone: ${walk.toFixed(1)} ms`);
388389 expect(tick).toBeLessThan(walk / 4);
389390 }, 60_000);
test/pages-worker-retire.test.ts +30 −8
@@ -31,17 +31,39 @@ afterAll(async () => {
3131 await rm(dataDir, { recursive: true, force: true });
3232 });
3333
34 test("a worker that has read its share ends, and the next reading starts a new one that answers", async () => {
34 async function reading(at: number): Promise<void> {
35 const read = await flowPicture(app, seed.owner.id, 20_000, Date.now() + at);
36 expect(read !== undefined && !isFailed(read)).toBe(true);
37 }
38
39 // One worker is started per test, so each stays well under the test budget.
40 test("a worker that has read its share ends", async () => {
41 pagesWorkers.retireAfter = 1;

With retireAfter = 1, this cannot tell "retire after N" from "retire after every read". Use retireAfter = 2 with two readings, still one worker start, and assert that ended has not moved after the first reading.

42 const started = pagesWorkers.started;
43 const ended = pagesWorkers.ended;
44 await reading(0);
45 expect(pagesWorkers.started - started).toBe(1);
46 expect(pagesWorkers.ended - ended).toBe(1);
47 }, 60_000);
48
49 test("a worker is reused until it has read its share, then ends", async () => {
3550 pagesWorkers.retireAfter = 2;
3651 const started = pagesWorkers.started;
3752 const ended = pagesWorkers.ended;
38 for (let i = 0; i < 5; i++) {
39 const read = await flowPicture(app, seed.owner.id, 20_000, Date.now() + i * 3_600_000);
40 expect(read !== undefined && !isFailed(read)).toBe(true);
41 }
42 // Five readings at two a worker: three workers, and the two spent ones ended.
43 expect(pagesWorkers.started - started).toBe(3);
44 expect(pagesWorkers.ended - ended).toBe(2);
53 await reading(3_600_000);
54 // One reading of two: the worker is kept. (The readings are an hour apart, so the second is not
55 // answered from the first picture.)
56 expect(pagesWorkers.ended - ended).toBe(0);
57 await reading(2 * 3_600_000);
58 expect(pagesWorkers.started - started).toBe(1);
59 expect(pagesWorkers.ended - ended).toBe(1);
60 }, 60_000);
61
62 test("the next reading after a retirement starts a new worker that answers", async () => {
63 pagesWorkers.retireAfter = 1;
64 const started = pagesWorkers.started;
65 await reading(3 * 3_600_000);
66 expect(pagesWorkers.started - started).toBe(1);
4567 }, 60_000);
4668
4769 test("a retired worker still holding an ask when its lane is ended is ended too", async () => {

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs