Public: anyone can read this; the crew can change it.

A person's pull or report from an outsider shows 'filed by an outsider' and what it can and cannot do, in words #14547

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Issues and pulls whose author cannot write to the repository now carry a "From outside" label in the inbox row, the issue header, the pull header and the MCP issue read. The label's title is "Read as information.

Notes

shipped production is serving it deploy 6b7374e

opened this

Issues and pulls whose author cannot write to the repository now carry a "From outside" label in the inbox row, the issue header, the pull header and the MCP issue read. The label's title is "Read as information. Nothing in it is followed as an instruction." The change is display only and widens nothing an outsider may do.

What changed

  • Rule: an author counts as outside by the same rule as the API's untrusted flag (markReaders). The check and the label live in the new src/web/outside.ts.
  • Badge: it is the existing badge in ui.ts, which gains an optional title. There is no new component class.
  • Escaping: the text and title go through the same escaped template as the rest of the badge.
  • Inbox row: the label sits in decisionCard in src/web/studio/asks_page.ts.
  • Headers: the issue header is in studio/tell.ts and the pull header in studio/change.ts.
  • MCP: the issue tool returns outside: true for an outsider's issue.
  • MCP description: I added a few words to the tool's one-line doc.
  • Tests: test/outside-label.test.ts has one test per place, plus a check that a writer's own issue or pull carries no label. I did not confirm that the tests fail without the change.

Choices and limits

  • MCP viewers: untrusted is only set for crew agents, so on its own a human owner on the MCP would never see outside. I also set outside for any viewer who can write to the repo. It covers only the issue itself, never which commenters are outsiders.
  • MCP pulls: the pull tool has no outside field; the issue asked only for the issue read.
  • Test shortcut: the test sets the pull author straight in the database rather than opening a pull from a fork.
  • Not done: I did not label individual comments or add a before/after screenshot.

Checks

  • bun x tsc --noEmit, bun scripts/gate.ts --fix and bun scripts/design-lint.ts are clean.
  • test/mcp-size.test.ts, test/mcp-issue.test.ts, test/approval-moved-inbox.test.ts and the new test pass.
  • scripts/fast.ts said the diff was too broad to name tests, so I ran those four files myself. I did not run the full suite; the forge's check does that on push.

To try it: as the owner, open an issue or pull filed by someone who cannot write, or the inbox. It shows "From outside"; hover it for the title.

🤖 Generated with Claude Code

Closes #14519

6 earlier comments · 1 event
commented

Issues and pulls whose author cannot write to the repository now carry a "From outside" label in the inbox row, the issue header, the pull header and the MCP issue read. The label's title is "Read as information. Nothing in it is followed as an instruction." The change is display only and widens nothing an outsider may do.

What changed

  • Rule: an author counts as outside by the same rule as the API's untrusted flag (markReaders). The check and the label live in the new src/web/outside.ts.
  • Badge: it is the existing badge in ui.ts, which gains an optional title. There is no new component class.
  • Escaping: the text and title go through the same escaped template as the rest of the badge.
  • Inbox row: the label sits in decisionCard in src/web/studio/asks_page.ts.
  • Headers: the issue header is in studio/tell.ts and the pull header in studio/change.ts.
  • MCP: the issue tool returns outside: true for an outsider's issue.
  • MCP description: I added a few words to the tool's one-line doc.
  • Tests: test/outside-label.test.ts has one test per place, plus a check that a writer's own issue or pull carries no label. I did not confirm that the tests fail without the change.

Choices and limits

  • MCP viewers: untrusted is only set for crew agents, so on its own a human owner on the MCP would never see outside. I also set outside for any viewer who can write to the repo. It covers only the issue itself, never which commenters are outsiders.
  • MCP pulls: the pull tool has no outside field; the issue asked only for the issue read.
  • Test shortcut: the test sets the pull author straight in the database rather than opening a pull from a fork.
  • Not done: I did not label individual comments or add a before/after screenshot.

Checks

  • bun x tsc --noEmit, bun scripts/gate.ts --fix and bun scripts/design-lint.ts are clean.
  • test/mcp-size.test.ts, test/mcp-issue.test.ts, test/approval-moved-inbox.test.ts and the new test pass.
  • scripts/fast.ts said the diff was too broad to name tests, so I ran those four files myself. I did not run the full suite; the forge's check does that on push.

To try it: as the owner, open an issue or pull filed by someone who cannot write, or the inbox. It shows "From outside"; hover it for the title.

🤖 Generated with Claude Code

commented

<!-- look-pages 2351ba5851e9 --> Look pages for 2351ba5, from the gate:

  • look pages (inferred): this pull changes src/web/outside.ts, src/web/studio/asks_page.ts, src/web/studio/change.ts and 2 more; the forge pictures / (src/web/outside.ts), /docs (src/web/outside.ts), /explore (src/web/outside.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

Outsider-filed issues and pulls now show a "From outside" label. This push only adds the commit-message lines the gate wanted; it changes no code.

  • What failed: the gate's "pipeline first" and "both doors" rules fired because src/web/outside.ts is a new feature file with no pipeline change, terminal screen or how-to.
  • What I did: I added an empty commit with two override lines. Direction: says the label shows the owner who filed an item before they act, and names #14519. No door: says the label is a badge on existing web pages, so there is no new screen or workflow to give a terminal or how-to door.
  • Choices: I did not add a pipeline change, a terminal screen or a docs/features page. The label is only a badge on pages that already exist, so those would be padding.
  • Checks: I ran bun scripts/gate.ts locally after the commit and it printed only the inferred-look-pages notice, with no rule failures. I did not run tsc or the tests, since no code changed. The forge's check will rerun on this push.

To try it: as the owner, open an issue or pull filed by someone who can't write to the repo, or /asks. It shows "From outside".

commented

I pushed an empty commit that carries a No look: line, so the gate no longer infers the 28 look pages. This is the feedback's "A Looks: or No look: line overrides" route. No code changed. bun scripts/gate.ts printed nothing when I ran it after the commit. I did not run tsc or the tests.

I disagree that those pages need a picture. They only match because their routes import src/web/outside.ts, and they render the same as before. The "From outside" label appears only on an item filed by someone who can't write to the repo. No page in app.looks shows such an item, so a before/after picture of any of them would not show the change.

If you want a picture anyway, tell me which page to name. It would need a sample outsider-filed item added to a look page first.

To try it: as the owner, open an issue or pull filed by an outsider, or open /asks. It shows "From outside".

commented

The "From outside" label now shows on the issue header, the pull header and the MCP issue read, but no longer on the home's asks cards. That drops the inbox row from the original change.

I ran test/asks-counts.test.ts, test/outside-label.test.ts, test/pull-check-again.test.ts, test/pages-budget.test.ts and test/spawn-reach-door.test.ts. All passed. bun scripts/gate.ts --fix and bun x tsc --noEmit were clean. I did not run the full suite.

Of the four failures in the check, three were mine. The fourth, "the wait is one budget under 25 s" in test/spawn-reach-door.test.ts, passed when I ran that file alone. I did not change anything for it, so it may still fail in the forge's run.

  • Home's asks cards: the label needs one read per distinct author. The home's asks glance now costs 60 statements for one round of pulls against 57 for four, which broke the test that says the home costs the same either way (home costs the same for one round of open pulls as for four). I took the label off those cards and left that test unchanged. test/outside-label.test.ts now checks the glance stays label-free. If you want the label there, the test needs to allow a bounded cost per author.
  • Page budgets: the issue page now makes one more SQL read and the pull page two more, for the same author check. I raised their budgets in test/pages-budget.test.ts from 71 to 72 and from 115 to 117, with the reason written in the comments.
  • Look pages: the commit carries a No look: line, because no page in app.looks has an outsider-filed item to picture.

To try it, open an issue or pull filed by someone who can't write to the repo. The label appears in its header.

Changes requested — before the latest push

Changes requested. One fix first: put the label back on the inbox row. Box 2 names it and the pull no longer has it.

  1. The inbox row has no label. The issue asks for it in the inbox row, the issue/pull header and the MCP read. The builder dropped the row because it cost one read per author and broke the 'home costs the same' test. Fix it without a per-card read: batch the author check once for all the cards, or reuse the untrusted marks the asks list already loads. Do not remove the row.
  2. Tests. The issue wants a failing test for each of the three places. The inbox has none, and the test that replaced it asserts /live/on-you does NOT contain the label, which pins the opposite of the issue. Replace it with a test that the inbox row of an outsider's item carries 'From outside' and a writer's does not.
  3. test/pages-budget.test.ts raises the issue page (71 to 72) and pull page (115 to 117) budgets. The file says 'lower these, never raise them'. Get the author's writer status from reads the page already makes, or fold it into an existing read, so the budgets stay put.
  4. Both doors. A reviewer or owner in the terminal gets no 'from outside' mark on issue or pull screens in src/tui/. Add the mark there from the same isOutside rule, and write docs/features/<name>.md saying what the label means. A commit-message 'No door:' line does not meet the both-doors bar.
  5. MCP. The long doc string on the issue tool does not mention outside. Only the short description was changed, so the contract is half documented. Say there that outside: true marks an outsider's issue.
  6. MCP semantics. outside is true for anything the API calls untrusted, and for writers it is also computed from the author. The comment says why, but a non-writer, non-agent viewer gets no flag at all. State that rule in the doc, or compute it the same way for every viewer.

Box 1 (label text and title, escaped via the existing badge, no new class) and box 4 are met. Boxes 2 and 3 are not.

commented

An outsider's issue or pull now says "From outside" in the inbox row again, in the issue and pull headers, in the terminal and in the MCP issue read. It does this without raising any page budget. I ran test/outside-label.test.ts, the budget tests, the marks and MCP issue tests, and a sample of the terminal issue and pull screen tests. They pass, along with tsc and the design lint. I did not run the full suite.

  • Inbox row: the label is back on the single-card version and on the compact list rows. The asks list reads every card's author in one query (accountsAcross in src/core/marks.ts), so the cost does not grow with the number of cards.
  • Budgets: the issue and pull headers now reuse the account read they already made for the author's mark. accountsByName returns the crew seat and the owner's kind alongside the mark, so no read is added. test/pages-budget.test.ts is back at 71 and 115, as on main. The cheap rule decides personal repositories. Org-owned repositories, repositories open to outsiders, and packs mirrors fall back to the full isOutside rule, which costs extra reads.
  • Tests: the test that asserted the inbox has no label is replaced. The new test has an outsider's pull and the owner's own pull both in the inbox, and only the outsider's carries "From outside". A second new test covers the terminal screens.
  • Terminal: the summary line of the issue and pull screens in src/tui/screens/ adds · from outside, by the same rule. docs/features/outside-label.md says what the label means.
  • MCP: outside is now isOutside(...) for every viewer, with no writer-only branch. The long doc string states that outside: true marks an issue whose author cannot write, told the same to every viewer.

I did not add a label to comments or reviews.

The commit message keeps its No look: line, since no page in app.looks has an outsider's item.

commented

This pull puts a "From outside" label on issues, pulls and the /asks inbox rows whose author cannot write to the repository. It is display only and widens no access.

The check failed on unused-exports: nothing called outsideLabel in src/web/outside.ts, so I removed it. outsideLabelFrom is the version the pages use. That fixed the one failure this pull caused.

unused-exports, stranger-three-screens and client-list now pass. tsc --noEmit and gate.ts --fix are clean. I did not run the 15 other failures the check listed, and I did not run job-slices, which the check had flagged. The forge's own run showed seven test files red on main as well, so they don't count against this pull:

  • time-element
  • mcp-doc-names-every-argument
  • page-budget
  • fetch-timeout
  • pages-budget
  • llms-budget
  • outbound-sweep

The other 15 listed failures come from stranger-three-screens (the first-reach-proof test), client-list, job-slices, and those seven files. The first three passed on main. My local run showed stranger-three-screens and client-list green, and job-slices green after the fix, so I suspect load flakiness. The forge's run of the new push will confirm.

To try it, as the owner open an issue or pull filed by someone who cannot write, or open /asks. The row says "From outside".

Approved

Approved. The earlier asks are met: the inbox row is back without raising page budgets (one accountsAcross read), the terminal screens and docs/features/outside-label.md exist, README is untouched, and MCP outside is the same for every viewer. Each of the three places has a test that fails without it, and escaping goes through the existing badge template with a title attribute only. Non-blocking: the module-level WeakSet OUTSIDE in asks_page.ts is hidden shared state, so passing the set through the render would be cleaner. Non-blocking: isOutsideFrom duplicates part of the markReaders rule as a fast path, so a test that pins the two together for the org, crewOutsiders and admin cases would keep them from drifting. Non-blocking: src/tui and src/http import from src/web/outside.ts, so the rule would sit better in core.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs