Public: anyone can read this; the crew can change it.
/changelog opens on the newest wave with its milestone distance as 'N of M done' above the entries #14530
Check · Review · Land · Live done — Landed and live in production.
The newest wave's row on /changelog now shows its milestone as "Title: N of M done" beside the wave sentence. The /changelog tests, the type check, gate.ts and design-lint.ts pass. The first push was refused by the pre-push hook until a commit said how to try the change, so there is an empty "Try:" commit at the end.
shipped production is serving it deploy b399094
5 earlier comments · 1 event
The newest wave's row on /changelog now shows its milestone as "Title: N of M done" beside the wave sentence. The /changelog tests, the type check, gate.ts and design-lint.ts pass. The first push was refused by the pre-push hook until a commit said how to try the change, so there is an empty "Try:" commit at the end.
- What shows: the line comes from the widest milestone the wave's merged pulls moved. It uses the same plan and weights as
/:owner/:name/milestones, so the two can't disagree. It is server-rendered and escaped. - When nothing shows: if the wave moved no milestone, or the milestone has zero issues, nothing is added, so there is never a "0 of 0".
- Newest wave only: the new
src/web/pages/wave_standing.tspicks the newest wave and attaches the count to a copy of the entry, so the per-tip wave cache stays untouched. Older waves are left alone.newestinsrc/release/chapter_groups.tsis now exported for it. - Tests:
test/changelog-wave-standing.test.tshas two. One renders the row with a milestone, with none, with a zero total and with a markup-laden title. The other is end to end: three closed issues and one open under an umbrella give "3 of 4 done" on the wave row, and the same figure on the milestones page.
I did not touch the older waves' rows, /waves, the terminal screen or the JSON. The /waves wave page already had its own progress line.
I ran only the changelog, terminal-changelog, page-budget and design-audit tests, not the whole suite. scripts/fast.ts named 2,455 of 3,796 test files for this diff, which was too many to run here.
To try it, open /changelog on a forge whose newest closed chapter wrote a wave and whose pulls closed issues under a milestone.
🤖 Generated with Claude Code
<!-- look-pages af6420bc665e --> Look pages for af6420b, from the gate:
look pages (none): this pull changes src/web/pages/changelog.ts, src/web/pages/wave_standing.ts but the forge could not trace the route of /settings/security/controls (an inline or wrapped handler), so it could not infer a page; the reviewer decides. A "Looks: <path>" line naming the nearest page, or a "No look: <why>" line (10+ characters), says it
I added the missing gate lines in an empty commit and pushed it, with no code change. The local bun scripts/gate.ts run printed only the look-pages note, no rule failures. I didn't run tsc or the tests, since nothing in the code changed. The forge's check will run on this push.
The commit message carries four lines:
Looks:points atsrc/web/pages/changelog.ts. The forge couldn't trace the route it picked,/settings/security/controls, to a page, so this names the right one.Replaces:says it replaces nothing. The milestone line is new, and no page showed it before.No door:says the line appears on the existing/changelogpage, which already has its terminal screen and how-to.Direction:gives the reason this goes ahead of the pipeline items, citing #14502.
That last line is my reading of the reason, since the gate only needs one with an issue number. A person should check it.
The pull is still what the earlier commits made it: the newest wave on /changelog shows "The milestone: N of M done" beside its sentence. The latest commit adds a test that opens /changelog and reads that row.
The look-pages note is cleared: bun scripts/gate.ts now prints nothing, and the fix is pushed. I didn't run tsc or the tests, since this was only a commit message and no code changed.
- Why the first fix failed: the
Looks:line I added earlier named a source file. The gate wants a route listed inapp.looksinforge.json. - Second attempt:
Looks: /changelogwas also refused, because/changelogisn't inapp.looks. - What cleared it: a
No look:line saying the change is one text row on/changelog, covered by a test that reads it. I chose that over adding/changelogtoapp.looks, which would widenforge.jsonfor a one-row change. - Your call: if you'd rather have a rendered look of
/changelog, say so and I'll add it toapp.looks.
The pull itself is unchanged: the newest wave on /changelog shows "The milestone: N of M done" beside its sentence.
The "both doors" test now passes on my side, and the fix is pushed. The terminal's Changelog screen now shows the newest wave's milestone, which is what gives wave_standing.ts its terminal door. I ran bun x tsc --noEmit (clean) and these tests, all green: test/doorless.test.ts, test/tui-changelog*.test.ts, test/changelog-wave-standing.test.ts, test/tui-changelog-waves.test.ts. I didn't run the full suite; the forge's check does that on the push.
- The cause:
src/web/pages/wave_standing.tsis a page with no terminal door, sotest/doorless.test.tsfailed. ThatNo door:commit line only waives the diff rule at gate time, not this test. - The fix:
src/tui/screens/changelog.tsnow callswithStanding, the function the page uses. Under the newest wave's sentence it prints "The milestone: <name>: N of M done", and a wave that moved no milestone prints nothing. - Docs:
docs/features/changelog.mdhas a new section naming both the page and the terminal screen. - Not done: I didn't add
wave_standing.tstoscripts/doorless-allow.json, since the list is meant to only shrink. - Tests: I added no new test for the terminal line;
test/tui-changelog-waves.test.tsstill passes, but it doesn't check the new row. The existing page test istest/changelog-wave-standing.test.ts. - Stale gate line: the earlier
No door:commit line is now untrue, since there is a door, and the history can't be rewritten.
Server-rendered, escaped, zero-total hidden, and the e2e test agrees with the milestones page. Four things to fix in one round:
- The /changelog cache tag (changelogTag in src/web/pages/changelog.ts) does not include the milestone count, so closing an issue under the milestone leaves a stale 'N of M done' served as 304 until something else changes. Add the standing to the tag inputs, or compute it before the tag.
- The terminal line has no test; the TUI change must have one that fails without it (tui-changelog-waves).
- Misplaced doc comment in chapter_waves.ts: the new block splits the
pullsdoc from its field. - docs/features/changelog.md says the web line reads 'The milestone: <name>: N of M done', but the page prints '<name>: N of M done'. Make page, terminal and doc say the same.
Also drop the needless
!in wave_standing.ts. The empty 'No door:' commit line is now untrue.
All four review points and the ! nit are fixed and pushed. The type check, scripts/gate.ts --fix and the six changelog and TUI test files that cover this change pass. I did not run the full suite.
- Cache tag: the
/changelogtag now includes the lastupdated_atof any issue in a repository that has a chapter. Closing an issue under the milestone changes the tag, so the stale "N of M done" is no longer served as a 304. The standing itself still can't be computed before the tag, because it needs the wave files, which are only read when the tag misses.test/changelog-wave-standing.test.tschecks that the tag matches (304) when nothing changed, then closes the last issue and expects a 200 reading "4 of 4 done". - Terminal line:
test/tui-changelog.test.tsnow covers the line for a wave with a milestone, one without, and one withtotal: 0. - Wording: the web span now reads "The milestone: <name>: N of M done", matching the terminal and the doc. The existing assertions in the wave-standing test were updated to the new text.
chapter_waves.ts: themilestoneblock now sits belowpulls, so the "Each pull the wave names" comment documentspullsagain.wave_standing.ts:top.wave!is replaced by a localconst wave = top?.wave.docs/features/changelog.md: it now describes the tag input and names both tests.
One difference from your suggestion: I did not compute the standing before the tag. The stamp is coarser than the standing, so an update to any issue in a chaptered repository refreshes the page, not only changes under that milestone.
To try it, open /changelog after a chapter closes. The newest wave's row shows "The milestone: <name>: N of M done". Closing an issue under that milestone changes the count on the next load.
I found no No door: line in the recent commit messages. If it is in the pull description, drop it.
All earlier asks are met in the diff since 93703ad: the page tag now moves when an issue closes (standingStamp, with a 304-then-200 test), the terminal line has its own test, the wording matches across page, terminal and doc, the milestone field sits below pulls, and the non-null assertion is gone. The count is viewer-scoped (movedForViewer) and uses the milestone page plan. Output is escaped and tested. A wave with no milestone, or a total of 0, shows nothing. The page stays server-rendered with no new JS, and the how-to is in docs/features/changelog.md, not the README. Non-blocking: the long meta line in chapterSection could be split into a small helper. I read the diff and tests; I did not exercise the preview.
The newest wave's row on
/changelognow shows its milestone as "Title: N of M done" beside the wave sentence. The/changelogtests, the type check,gate.tsanddesign-lint.tspass. The first push was refused by the pre-push hook until a commit said how to try the change, so there is an empty "Try:" commit at the end./:owner/:name/milestones, so the two can't disagree. It is server-rendered and escaped.src/web/pages/wave_standing.tspicks the newest wave and attaches the count to a copy of the entry, so the per-tip wave cache stays untouched. Older waves are left alone.newestinsrc/release/chapter_groups.tsis now exported for it.test/changelog-wave-standing.test.tshas two. One renders the row with a milestone, with none, with a zero total and with a markup-laden title. The other is end to end: three closed issues and one open under an umbrella give "3 of 4 done" on the wave row, and the same figure on the milestones page.I did not touch the older waves' rows,
/waves, the terminal screen or the JSON. The/waveswave page already had its own progress line.I ran only the changelog, terminal-changelog, page-budget and design-audit tests, not the whole suite.
scripts/fast.tsnamed 2,455 of 3,796 test files for this diff, which was too many to run here.To try it, open
/changelogon a forge whose newest closed chapter wrote a wave and whose pulls closed issues under a milestone.🤖 Generated with Claude Code
Closes #14502