Public: anyone can read this; the crew can change it.
The maintenance board names the one stalled step in the flow and the single action that unblocks it #14527
Check · Review · Land · Live done — Landed and live in production.
/maintenance now shows at most one "Stalled" card at the top, naming the oldest stalled step, its age and one button. The new test passes, tsc and design-lint are clean, and gate --fix rewrapped comments in two files, which are committed.
shipped production is serving it deploy 9504585
7 earlier comments · 2 events
The maintenance board now shows the one stalled step as a row (the pull, how long it was quiet, one button), and it also has a terminal door. I pushed a fix for the one failure this pull caused. test/counts.test.ts, test/tui-maintenance-stalled.test.ts, tsc, scripts/gate.ts --fix and design-lint all pass locally. I did not run the full suite; the forge does that on the push.
- Failing test: "an issue listing costs the same for 5 rows as for 50" was timing-dependent, not broken by the stalled-step code. Locally it failed 2 runs in 8 (once with 17 statements for the first request against 8 for the second), so I think a cold first request or background work was landing in its window. The test now makes one throwaway request before it counts. It passed 4 runs in a row after the change; I did not reproduce the original failure on main.
- Merge: I merged
origin/maininto the branch.src/web/pages/maintenance.tsconflicted, and I kept both sides: the stalled-step card and main'smaintenanceJsonandmaintenancePagehandlers. - Other five failures: the sweep of src, the pages budget, the
llms.txtbudget, the first-page SQL statement budget and the fetch timeouts. The check log says they are red on main at c0abde6 too, so I left them alone. - Left open:
scripts/gate.tsflaggedopenMaintenanceintest/helpers/tui-maintenance.tsas 0.64 similar toterminalintest/flow-waiting.test.ts, and I did not merge the two.
[{"go":"/maintenance","look":"a pull that has been quiet too long shows a Stalled row above the board with one outline button","expect":"the row names the pull and how long it was quiet; pressing the button posts once; with no stalled pull there is no row"}]
🤖 Generated with Claude Code
<!-- look-pages cd39404e392c --> Look pages for cd39404, from the gate:
look pages (named): this pull changes src/web/pages/maintenance.ts; a commit names /maintenance
Nothing in the pull's own code was red this time, so I changed no code. I merged the latest origin/main into the branch and pushed; the check will run again on that.
The only failure the check blamed on this pull was "POST /api/v1/apps names its phases and answers under 1 s", from test/new-app-post-timing.test.ts. It missed its 1 s budget by 6 ms (1006 ms) while the full suite ran across shards. Three local runs of it passed, and this pull doesn't touch the apps API. I didn't loosen the test. If it fails again on a quiet run, the cause is somewhere else, not this pull.
The other six failures (the page budgets, the llms.txt budget, the outbound-fetch sweep, the <time> check and the fetch timeouts) are red on main at 42e919a too, so the check doesn't count them against this pull.
After the merge, tsc is clean. test/new-app-post-timing.test.ts, test/tui-maintenance-stalled.test.ts and test/counts.test.ts pass together (12 tests). scripts/gate.ts still flags openMaintenance in test/helpers/tui-maintenance.ts as similar to terminal in test/flow-waiting.test.ts; I haven't merged them.
I merged main into the branch and pushed. The only conflict was test/counts.test.ts.
Both sides had fixed the same timing flake in "an issue listing costs the same for 5 rows as for 50". I kept main's fewestStatements version and dropped the warm-up request I had added earlier, so the pull no longer touches that test.
tsc is clean, and test/counts.test.ts and test/tui-maintenance-stalled.test.ts pass together (10 tests). I did not run the rest of the suite; the forge's check does that on the push.
<!-- look-pages 3f2462deb034 --> Look pages for 3f2462d, from the gate:
look pages (named): this pull changes src/web/pages/maintenance.ts; a commit names /maintenance
Earlier asks are met. The stalled step is now a plain Stalled row in the board status-row pattern. The wording says only what is known ("untouched for 1 day"), with no review claim. The terminal has a door: the first line on the Maintenance screen, key a through the same nudge, admin people only and left out of the calm view. The how-to is docs/features/maintenance-stalled.md, README is untouched, and the test helpers are shared instead of copied. Tests cover no card, one card with its POST form, a refused cross-origin press, a receipt, and the TUI for admin versus other users.
Non-blocking: remove the doubled blank line after stalledCard in src/web/pages/maintenance.ts. Non-blocking: openMaintenance in test/helpers/tui-maintenance.ts is similar to the terminal helper in test/flow-waiting.test.ts; fold them together later.
The two next things I would do: show the card on /system too, and add a Close action alongside Ask.
I removed the doubled blank line after stalledCard in src/web/pages/maintenance.ts and pushed. tsc is clean and test/tui-maintenance-stalled.test.ts passes (3 tests).
- Look pages: the gate's note ("a commit names /maintenance") needs no change. The new commit's subject names
/maintenance, and the page to look at is/maintenance. - Not done: I did not fold
openMaintenanceintest/helpers/tui-maintenance.tsinto theterminalhelper intest/flow-waiting.test.ts. @juniper marked that non-blocking and for later. The gate still flags the pair as similar. - Not done: I did not show the card on
/systemor add a Close action. These were suggested as next steps, not as part of this pull.
<!-- look-pages 760a3f6c877f --> Look pages for 760a3f6, from the gate:
look pages (named): this pull changes src/web/pages/maintenance.ts; a commit names /maintenance
Since 3f2462d the only change is a removed doubled blank line after stalledCard; my earlier asks stand met (copy from one place, the terminal door and its how-to in docs/features, the shared nudge route with its same-origin check and receipt). Nothing new to raise. Two things I would do next: (1) Non-blocking: fold openMaintenance in test/helpers/tui-maintenance.ts into the terminal helper in test/flow-waiting.test.ts, which the gate still flags as similar. (2) Non-blocking: show the same row on /system, and offer Close beside Ask if still wanted.
Nothing needs changing, so I made no commit or push this time. @juniper's approval has no blocking items, and the look-pages comment from the gate is the same note as before. The page to look at is /maintenance, and a commit on the branch already names it.
The desk hold says production is rolling and changes to it should wait until it settles. This pull doesn't touch production. It's a branch with a preview, and a person merges it, so the hold only matters at merge time. It's worth waiting until the release settles before merging.
I left @juniper's two non-blocking follow-ups for later pulls:
- Fold the helpers:
openMaintenanceintest/helpers/tui-maintenance.tsinto theterminalhelper intest/flow-waiting.test.ts, which the gate still flags as similar. - Extend the row: show the same Stalled row on
/system, and offer Close beside Ask.
/maintenancenow shows at most one "Stalled" card at the top, naming the oldest stalled step, its age and one button. The new test passes,tscanddesign-lintare clean, andgate --fixrewrapped comments in two files, which are committed. I ran only the tests around this change (test/maintenance-stalled.test.ts,test/maintain-stale-web.test.ts,test/maintenance-page.test.ts,test/maintenance-filed.test.ts,test/a11y-landmarks.test.ts), not the full suite. The push went through on the second try, after a pre-push hook asked for a commit saying how to try the change.What I took "the stalled step" to mean. The issue doesn't define it, so I chose the one the board can already measure: an open pull with no push, comment or review for 14 days, which waits on a person. If you meant another step (a tell nobody picked up, or the drain during maintenance), this needs a different finder and button.
stalledStepinsrc/maintenance/stalled.ts, and the card is insrc/web/pages/maintenance.ts./maintenance/stale/:id/nudge. That route already does the same-origin check, the admin check, a comment on the pull, and a receipt in the flash and the maintenance runs. An agent-kind admin sees the card without the button, as with the existing stale-pulls fold.test/maintenance-stalled.test.tschecks no card with no stalled pull, then with two stale pulls checks one card, its age, the count, and a single POST form. It also checks that a cross-origin press is refused and that a same-origin press redirects (303) and writes a maintenance-run receipt.Left out:
/system.Try it: as an admin with a pull untouched for 14 days, open
/maintenanceand press "Ask if still wanted".🤖 Generated with Claude Code
Closes #14504