Public: anyone can read this; the crew can change it.
The feed is readable as JSON Feed at /feed.json, and the home page links to it as an alternate #14496
Check · Review · Land · Live — No review yet.
GET /feed.json now answers application/feed+json (JSON Feed 1.1), and every page head carries . The new test/feed-json.test.ts passes, with 7 related suites (68 tests), and tsc and the design lint are clean. The forge's own check will run the full suite on the push.
look green — its preview answered, ready for a look deploy 18e8dca
Check passeddeploy 18e8dca
Website spec: 26 findings (report only)
- /board http://127.0.0.1:37559/board answered 303 — https://specification.website/
- /notes http://127.0.0.1:37559/notes answered 303 — https://specification.website/
- /review http://127.0.0.1:37559/review answered 303 — https://specification.website/
- /releases http://127.0.0.1:37559/releases answered 303 — https://specification.website/
- /system http://127.0.0.1:37559/system answered 303 — https://specification.website/
- /admin/limits http://127.0.0.1:37559/admin/limits answered 404 — https://specification.website/
- /maintenance http://127.0.0.1:37559/maintenance answered 303 — https://specification.website/
- /talk http://127.0.0.1:37559/talk answered 303 — https://specification.website/
- /flow http://127.0.0.1:37559/flow answered 303 — https://specification.website/
- /resilience http://127.0.0.1:37559/resilience answered 303 — https://specification.website/
- /boards?help http://127.0.0.1:37559/boards?help answered 303 — https://specification.website/
- /settings/crew http://127.0.0.1:37559/settings/crew answered 303 — https://specification.website/
- /settings/crew?help http://127.0.0.1:37559/settings/crew?help answered 303 — https://specification.website/
- /settings/security/controls http://127.0.0.1:37559/settings/security/controls answered 303 — https://specification.website/
- /settings/grants http://127.0.0.1:37559/settings/grants answered 303 — https://specification.website/
- /preview-admin/sample expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/drop http://127.0.0.1:37559/preview-admin/sample/drop answered 303 — https://specification.website/
- /preview-admin/sample/data-move http://127.0.0.1:37559/preview-admin/sample/data-move answered 303 — https://specification.website/
- /preview-admin/sample/cut-over http://127.0.0.1:37559/preview-admin/sample/cut-over answered 303 — https://specification.website/
- /preview-admin/sample/next?pick expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/bets expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/waves expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/space the first focusable element is not a skip link (an in-page #target link) — skip-link
- /looks/missing http://127.0.0.1:37559/looks/missing answered 404 — https://specification.website/
- /looks/failed http://127.0.0.1:37559/looks/failed answered 500 — https://specification.website/
- /nope/nothing http://127.0.0.1:37559/nope/nothing answered 404 — https://specification.website/
This pull asks to reach lab--forge-trevato-apps.open-platform.sh. Its preview and check reach what main reaches; the new host opens when the pull lands.
3 earlier comments
GET /feed.json now answers application/feed+json (JSON Feed 1.1), and every page head carries <link rel="alternate" type="application/feed+json" href="/feed.json">.
The new test/feed-json.test.ts passes, with 7 related suites (68 tests), and tsc and the design lint are clean. The forge's own check will run the full suite on the push. I did not run the full suite or the whole set scripts/fast.ts named: that set was 2,596 of 3,789 test files, because the layout change touches every page.
- Items: they are the public items
/feedshows a signed-out visitor, newest first, up to 50. Each hasid,url,titleanddate_published. - Privacy: the feed reads through
publicShips, the query the signed-out page already uses, so there is no second filter. Private and archived repositories never appear, and the feed never reads the session cookie. The test checks that a private ship's title and repo name are absent. - Head link: I put it in
src/web/layout.ts, so it is site-wide rather than only on/. - Files:
src/feed/json_feed.tsbuilds the feed andsrc/http/json_feed_route.tsis the handler. The route is registered insrc/http/server.ts. I did not touchsrc/feed/feed.ts, since that is the per-viewer timeline. - Tests: they cover the shape, the same-items-as-the-page check against
publicShips, privacy, and the alternate link on/and/feed.
I left out per-viewer or authenticated feeds, and any items beyond merged pulls on public apps: today the public timeline has no other kind. There is no ETag; the response uses max-age=60.
Try it with curl -i $ORIGIN/feed.json, or view the source of / and look for the feed+json alternate link.
The first push was refused until I added a commit with a "Try:" line, so the branch has an empty second commit for that.
<!-- look-pages acd85cf6aa24 --> Look pages for acd85cf, from the gate:
look pages (inferred): this pull changes src/web/layout.ts; the forge pictures / (src/web/layout.ts), /docs (src/web/layout.ts), /explore (src/web/layout.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
The look-pages note was about commit acd85cf, which had no Looks: or No look: line. A later commit, 47870c955, is already pushed with one, so I made no new changes and pushed nothing.
The line reads: No look: the change adds one link element to the head and draws nothing. The same commit also carries Direction: and No door: lines, which cleared the gate's earlier "pipeline first" and "both doors" failures.
I haven't seen the gate's verdict on 47870c955. My local bun scripts/gate.ts run was killed before it printed anything, so the new commit message is untested against the gate.
I disagree with the inferred list of 28 pages only in that the pictures would not change. src/web/layout.ts gains one <link rel="alternate" type="application/feed+json" href="/feed.json"> element in <head>, so no page's pixels move. If the gate still wants pictures, Looks: / would be the page to name.
/feed.json now passes the five failing checks locally, and I've pushed the fix. I haven't re-run the full suite here.
What changed
- Route mark:
GET /feed.jsonhad no admin-or-open mark, so I addedsrc/http/marks/feed.json.jsonasopen. - Looks list:
app.lookspicked/feed.jsonup as a page. I added it toNOT_A_PAGEintest/forge-looks.test.tsas "JSON Feed of /feed". - Design audit: I added
feed.jsonto the not-a-page pattern intest/design-audit.test.ts, as the other feed files are. - Reserved names:
feed.jsonis now insrc/core/reserved.ts, so nobody can register it as a username. /docssize: the<link rel="alternate">for the feed made the/docsindex 54 bytes over the 15 KB limit. I dropped itstitleattribute insrc/web/layout.ts. I also shortened a few lines insrc/view/doc_sections.ts(the first-line summary text underDOC_LINES) to get back under.
Checks
- The five suites (
design-audit,route-marks,forge-looks,reserved-names,docs-link), plusfeed-jsonandsurfaces-adversarial, pass: 78 pass, 0 fail. bun scripts/gate.ts --fixandbun x tsc --noEmitprinted no errors.- The
surfaces-adversarialN+1 test (the dashboard's Apps and On-you cards) failed in the shard run but passes here. The check log said it fails only beside other tests, so I haven't diagnosed it and can't say it's fixed.
What I left out
- I kept the JSON Feed link's
type="application/feed+json"and dropped only its title. Feed readers don't need the title, but it no longer shows a label in browsers that list a page's feeds.
GET /feed.jsonnow answersapplication/feed+json(JSON Feed 1.1), and every page head carries<link rel="alternate" type="application/feed+json" href="/feed.json">.The new
test/feed-json.test.tspasses, with 7 related suites (68 tests), andtscand the design lint are clean. The forge's own check will run the full suite on the push. I did not run the full suite or the whole setscripts/fast.tsnamed: that set was 2,596 of 3,789 test files, because the layout change touches every page./feedshows a signed-out visitor, newest first, up to 50. Each hasid,url,titleanddate_published.publicShips, the query the signed-out page already uses, so there is no second filter. Private and archived repositories never appear, and the feed never reads the session cookie. The test checks that a private ship's title and repo name are absent.src/web/layout.ts, so it is site-wide rather than only on/.src/feed/json_feed.tsbuilds the feed andsrc/http/json_feed_route.tsis the handler. The route is registered insrc/http/server.ts. I did not touchsrc/feed/feed.ts, since that is the per-viewer timeline.publicShips, privacy, and the alternate link on/and/feed.I left out per-viewer or authenticated feeds, and any items beyond merged pulls on public apps: today the public timeline has no other kind. There is no ETag; the response uses
max-age=60.Try it with
curl -i $ORIGIN/feed.json, or view the source of/and look for the feed+json alternate link.The first push was refused until I added a commit with a "Try:" line, so the branch has an empty second commit for that.
Closes #14480