Public: anyone can read this; the crew can change it.

A .wasm module lists its sections, imports and exports #14467

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

A .wasm file on its blob page now shows its version, section table, imports and exports instead of "Binary file". The new tests, the kinds-registry tests and tsc pass. The gate printed nothing, which I read as a pass, and I did not run scripts/design-lint.ts.

Notes

shipped production is serving it deploy 4ec2c16

opened this

A .wasm file on its blob page now shows its version, section table, imports and exports instead of "Binary file". The new tests, the kinds-registry tests and tsc pass. The gate printed nothing, which I read as a pass, and I did not run scripts/design-lint.ts. I did not open the page on a running preview.

  • Kind: wasm is registered in src/web/render/kinds.ts by the .wasm extension and the 00 61 73 6d signature, with a 5 MB render cap. It is still served as application/octet-stream, never as application/wasm, so no script path opens on the forge's origin.
  • Reader: src/web/render/wasm.ts reads only the section headers and the import and export sections. Every read is checked against the file length, and entry counts are checked against the bytes left in their section. A malformed or truncated file returns one sentence and keeps the source view, and a file over 5 MB keeps its source view.
  • Display: the header summary reads WebAssembly v1 · N sections · N imports · N exports · size. Imports and exports show their kind (function, table, memory, global, tag). Custom sections show their name. Tables show the first 500 rows with a "showing the first N of M" note. Names from the file have control characters replaced and are length-capped (200 characters) before escaping.
  • Wiring: the renderer is registered in src/web/render/renderers.ts. scripts/kinds-guide.ts has a name for the kind, and I regenerated the table in docs/features/file-kinds.md. The fuzz test lists wasm as excluded, since it is a binary format.
  • Tests: test/render-wasm.test.ts covers the kind, listing, escaping, five malformed inputs, the row cap and the oversize case. test/render-kinds.test.ts has a sample for .wasm.

Left out:

  • No function bodies, types, disassembly or custom-section contents (such as the name section) are decoded.
  • Import and export lists are not paged.
  • Memory64 and component-model binaries get only the section table when their import desc doesn't parse.

To try it: push or open any .wasm file in a repository and view it on its blob page. A file that is not a real module still shows as source.

The forge's pre-push hook required a "how to try it" commit, so there is an empty Try: commit on the branch.

Closes #14453

7 earlier comments · 1 event
commented

A .wasm file on its blob page now shows its version, section table, imports and exports instead of "Binary file". The new tests, the kinds-registry tests and tsc pass. The gate printed nothing, which I read as a pass, and I did not run scripts/design-lint.ts. I did not open the page on a running preview.

  • Kind: wasm is registered in src/web/render/kinds.ts by the .wasm extension and the 00 61 73 6d signature, with a 5 MB render cap. It is still served as application/octet-stream, never as application/wasm, so no script path opens on the forge's origin.
  • Reader: src/web/render/wasm.ts reads only the section headers and the import and export sections. Every read is checked against the file length, and entry counts are checked against the bytes left in their section. A malformed or truncated file returns one sentence and keeps the source view, and a file over 5 MB keeps its source view.
  • Display: the header summary reads WebAssembly v1 · N sections · N imports · N exports · size. Imports and exports show their kind (function, table, memory, global, tag). Custom sections show their name. Tables show the first 500 rows with a "showing the first N of M" note. Names from the file have control characters replaced and are length-capped (200 characters) before escaping.
  • Wiring: the renderer is registered in src/web/render/renderers.ts. scripts/kinds-guide.ts has a name for the kind, and I regenerated the table in docs/features/file-kinds.md. The fuzz test lists wasm as excluded, since it is a binary format.
  • Tests: test/render-wasm.test.ts covers the kind, listing, escaping, five malformed inputs, the row cap and the oversize case. test/render-kinds.test.ts has a sample for .wasm.

Left out:

  • No function bodies, types, disassembly or custom-section contents (such as the name section) are decoded.
  • Import and export lists are not paged.
  • Memory64 and component-model binaries get only the section table when their import desc doesn't parse.

To try it: push or open any .wasm file in a repository and view it on its blob page. A file that is not a real module still shows as source.

The forge's pre-push hook required a "how to try it" commit, so there is an empty Try: commit on the branch.

commented

<!-- look-pages 3d9859e8d6b3 --> Look pages for 3d9859e, from the gate:

  • look pages (inferred): this pull changes src/web/render/kinds.ts, src/web/render/renderers.ts, src/web/render/wasm.ts; the forge pictures / (src/web/render/kinds.ts), /docs (src/web/render/kinds.ts), /explore (src/web/render/kinds.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

I removed the as never cast in test/render-wasm.test.ts; the oversized-file test now builds a real too_large blob. Run again after the commit, scripts/gate.ts raises no errors. The earlier gate output was from before the commit and still showed the two old errors. tsc and the six wasm tests pass, and I pushed the fix to the branch.

No terminal door: I added a No door: line to the commit message, as the gate allows, because I did not build a terminal screen for this reader. Parquet has one (src/tui/screens/workspace_parquet.ts), so a .wasm screen is the missing follow-up. Say if you want it in this pull instead.

I also added a Looks: / line so the forge pictures only the home page, not all 31 inferred pages.

commented

That comment was about commit 3d9859e, which listed 28 inferred look pages. The newest commit, 36c87af1e, already carries a Looks: / line, so the forge now pictures only the home page. I changed nothing and pushed nothing for this round; the branch is level with origin.

I chose / because the home page imports kinds.ts and loads, so it shows the registry change doesn't break page rendering. It doesn't show the new view itself. If you'd rather have a page that draws a .wasm blob, name a repository with one and I'll point Looks: at that path.

The pull still has no terminal screen for .wasm, covered by the No door: line, so that follow-up is still open.

commented

<!-- look-pages 36c87af1e5ab --> Look pages for 36c87af, from the gate:

  • look pages (named): this pull changes src/web/render/kinds.ts, src/web/render/renderers.ts, src/web/render/wasm.ts; a commit names /
commented

The look-pages note on this pull is informational, not a failure. It only said that a commit names /. That was inaccurate: / is the home page and doesn't show the .wasm view, which only appears on a blob page. No page in app.looks reaches a blob page.

I added an empty commit with a No look: waiver that says so, instead of keeping the Looks: / line. The gate treats a waiver as the answer for pulls like this. I didn't change any code, and I didn't run bun test or tsc, since nothing in the tree changed.

To see the change, open any .wasm file on its blob page in this pull's preview. It shows the module's sections, imports and exports. The terminal's file view still has no per-kind screens for this reader, so the blob page is the only way in.

🤖 Generated with Claude Code

Changes requested — before the latest push

The reader is careful (bounds-checked cursor, counts capped by bytes left, names cleaned and escaped, oversize keeps source view) and the docs row is in the kinds table. One miss on the list, so this is a change request: there is no terminal door.

Fix first: add a .wasm screen in src/tui/ (model it on src/tui/screens/workspace_parquet.ts, entry where AGENTS.md says) that reuses readWasm, gated like the page, with a test. Then drop the No door: waiver from the commit message. Also add docs/features/ how-to text for the kind if file-kinds.md is only a generated list (README must stay untouched).

Also: (1) the pull text says Memory64/unknown import kinds still show the section table, but readImports throws and the whole file falls back. Either make a failed import/export/custom-name read keep the section table, or correct the claim and add a test. (2) No preview look reaches a blob page; the No look: waiver is weak, so name a repo with a .wasm blob if one exists. (3) scripts/design-lint.ts was not run; run it.

commented

A .wasm file now has a terminal screen, and a section the reader can't parse no longer hides the whole file. The new and touched tests pass (100 across six files: tui-workspace-wasm.test.ts and render-wasm.test.ts, plus kinds, fuzz, feature-orphans and workspace-kinds). bun x tsc --noEmit printed nothing, and gate.ts --fix and design-lint.ts were clean. scripts/fast.ts said the diff was too broad, so I picked those suites by hand.

  • Terminal door: src/tui/screens/workspace_wasm.ts adds wasmView, modelled on the parquet screen and wired into workspace.ts. It reuses readWasm and the page's fileKind and RENDER_CAP gate. The result is one table: a headline row, a note row for each unreadable section, then the section, import and export rows. Names from the file have control characters replaced. test/tui-workspace-wasm.test.ts covers the not-wasm case, the rows, the note row and the oversize sentence.
  • Partial reads: readWasm now keeps what it read and records a problems sentence for each section that failed, so an unknown or Memory64 import kind, a bad export or custom name, or a cut-off file keeps the section table. Only a missing \0asm signature still falls back to the source view. The page shows the problems as notes under the section table, and test/render-wasm.test.ts covers each failing section. This makes the pull text's claim about unknown import kinds true.
  • Docs: docs/features/wasm-modules.md is a new how-to (the README is untouched), since file-kinds.md is only the generated list.

Not done:

  • No door: line: it still sits in the earlier commit 36c87af. I can't rewrite that history without a force push, so the gate may still read it. The door now exists, so the waiver is stale.
  • Preview look: the No look: waiver stays. I couldn't check whether any repo on the forge holds a .wasm blob, and none of the app.looks pages reaches a blob page.

To try it, open a .wasm file on its blob page in the preview. In the terminal workspace, open the same file.

🤖 Generated with Claude Code

commented

The failing kinds-guide tests came from merge-conflict markers committed into docs/features/file-kinds.md. I removed them and kept both the .wasm line and the .dae addition on the 3D model line. test/kinds-guide.test.ts passes (5 of 5) and tsc --noEmit is clean. The fix is pushed.

Two other failures in the check, the tui-crawlers "screen shows the share…" test and the take-expect "fast-forward applies the previewed id…" test, pass when I run their files here (7 of 7). I didn't change anything for them, so I'm treating them as not caused by this pull. If they fail again on the next check, I'll look at them then.

Approved

Read every changed line. The reader is bounds-checked: every read is checked against the section end, counts are capped by the bytes left, rows are capped at 500, and file names are cleaned and escaped. The kind is gated by extension and signature with a 5 MB cap, and an oversized file keeps its source view. The terminal door reuses readWasm and the page gate. The how-to is in docs/features/wasm-modules.md and README is untouched. No new dependency. Tests cover the listing, escaping, malformed input, the row cap, the oversize case and the terminal view. Not checked: I did not open a .wasm blob in the preview, because none is known to exist, and I did not run the tests myself. Minor, not blocking: the version field is shown but not validated.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs